Unify static/non-static check for magic methods

And promote it to be fatal.

Add missing arg num check for __set_state

Clean up zend_check_magic_method_implementation

Let everything go through a common function, which fixes some
consistency issues.

Use consistent types

uint32_t type for argument count
size_t for length of char*
zend_bool for a zval bool arg

Closes GH-5845

Review the usage of apostrophes in error messages

Closes GH-5590

Add zend_wrong_parameter_error to reduce the size of ZPP macro

Closes GH-5831.

Voidify some ZEND_API functions

Closes GH-5805

Remove no_separation flag

Add string or object ZPP macros

Closes GH-5788

Cache __unserialize() instead of unserialize()

We should use these cache slots for the new object serialization
mechanism rather than the old one.

Make zend_argument_error_variadic static

Closes GH-5687

Constify char * arguments of APIs

Closes GH-5676.

Fix expression warnings and break warnings

Close GH-5675.

Add Attributes

Co-authored-by: Martin Schröder <m.schroeder2007@gmail.com>

Make Exception::$trace typed array property

This is a private property, so we are allowed to add a type.
The new declaration of the property is:

private array $trace = [];

Make Exception::$trace typed array property

This is a private property, so we are allowed to add a type.
The new declaration of the property is:

private array $trace = [];

This ensures that Exception::getTrace() does indeed return an array.

Userland code that was modifying the property through refleciton
may have to be adjusted to assign an array (instead of null,
for example).

Closes GH-5636.

show more ...

Improve type error messages when an object is given

From now on, we always display the given object's type instead of just reporting "object".
Additionally, make the format of return typ

Improve type error messages when an object is given

From now on, we always display the given object's type instead of just reporting "object".
Additionally, make the format of return type errors match the format of argument errors.

Closes GH-5625

show more ...

Refactor ZPP API to use uint32_t as everywhere else

Closes GH-5609

Add support for the mixed type

RFC: https://wiki.php.net/rfc/mixed_type_v2
Closes GH-5313

Co-authored-by: Dan Ackroyd <danack@basereality.com>

Improve error messages for invalid property access

Closes GH-5446
Co-authored-by: Nikita Popov <nikita.ppv@gmail.com>

Assert on unknown type in zend_get_type_by_const()

Rename zend_zval_get_type() API

We have a bunch of APIs for getting type names and it's sometimes
hard to keep them apart ... make it clear that this is the one
you definitely do not

Rename zend_zval_get_type() API

We have a bunch of APIs for getting type names and it's sometimes
hard to keep them apart ... make it clear that this is the one
you definitely do not want to use.

show more ...

Add Fast ZPP string|int type check

Completely remove disabled functions from function table

Currently, disabling a function only replaces the internal
function handler with one that throws a warning, and a few
places

Completely remove disabled functions from function table

Currently, disabling a function only replaces the internal
function handler with one that throws a warning, and a few
places in the engine special-case such functions, such as
function_exists. This leaves us with a Schrödinger's function,
which both does not exist (function_exists returns false) and
does exist (you cannot define a function with the same name).
In particular, this prevents the implementation of robust
polyfills, as reported in https://bugs.php.net/bug.php?id=79382:

if (!function_exists('getallheaders')) {
function getallheaders(...) { ... }
}

If getallheaders() is a disabled function, this code will break.

This patch changes disable_functions to remove the functions from
the function table completely. For all intents and purposes, it
will look like the function does not exist.

This also renders two bits of PHP functionality obsolete and thus
deprecated:

* ReflectionFunction::isDisabled(), as it will no longer be
possible to construct the ReflectionFunction of a disabled
function in the first place.
* get_defined_functions() with $exclude_disabled=false, as
get_defined_functions() now never returns disabled functions.

Fixed bug #79382.

Closes GH-5473.

show more ...

Remove redundant addref+dtor

Pass existing lcname to check_magic_method_implementation