first shot remove TSRMLS_* things

Fixed bug #68583 Crash in timeout thread

This replaces the GUI element used for execution timeout handling
on Windows. Instead a timer queue technique is used, which is indeed
a thre

Fixed bug #68583 Crash in timeout thread

This replaces the GUI element used for execution timeout handling
on Windows. Instead a timer queue technique is used, which is indeed
a thread pool. A timer queue timer is a lightweight object handled
but that thread pool and the timer thread spends most of the time
sleeping and waiting for an alert.

Please note also that this introduces neither binary nor source
breach. The custom timeout thread functions are deleted, however
they was not exported throug DLL, so couldn't be used by any
external code. As well they couldn't be used anywhere in the core
except in executor api, because those custom timeout thread
functions they used to operate on static variables which would
be overwritten (and that would blow).

So instead a relatively modern technique is used for the timeout
handling. It's still not perfect because the executor still has to
check EX(timed_out). This can be a topic for an improvement in
master. But brobably can be tricky as currently it seems to be not
possible to signal an individual thread. Also note another issue
that static variables aren't thread safe, but the current timer
implementation is.

show more ...

fix datatype mismatches

moved most of the core to use static tsrm ls cache pointer

plus apache2handler, cli and cgi

bring back all the TSRMLS_FETCH() stuff

for better comparability with the mainstream

DLL export several APIs needed for phpdbg

Update get_class_name semantics

* get_class_name is now only used for displaying the class name
in debugging functions like var_dump, print_r, etc. It is no
longer used in get

Update get_class_name semantics

* get_class_name is now only used for displaying the class name
in debugging functions like var_dump, print_r, etc. It is no
longer used in get_class() etc.
* As it is no longer used in get_parent_class() the parent
argument is now gone. This also fixes incorrect parent classes
being reported in COM.
* get_class_name is now always required (previously some places
made it optional and some required it) and is also required
to return a non-NULL value.
* Remove zend_get_object_classname. This also fixes a number of
potential leaks due to incorrect usage of this function.

show more ...

fix the empty_strings SAPI shutdown leak in TS build

still the NTS variant is somewhat different as it needs
zend_new_interned_string_int because the normal callbacks might
be not in

fix the empty_strings SAPI shutdown leak in TS build

still the NTS variant is somewhat different as it needs
zend_new_interned_string_int because the normal callbacks might
be not initialized, but at least no leaks anymore and some more
structure

show more ...

fix leaking the empty_string in TS builds

Remove <% and <script language="php"> tags

As per https://wiki.php.net/rfc/remove_alternative_php_tags.

Removes:
* <% opening tag
* %> closing tag
* <%= short opening

Remove <% and <script language="php"> tags

As per https://wiki.php.net/rfc/remove_alternative_php_tags.

Removes:
* <% opening tag
* %> closing tag
* <%= short opening tag
* /<script\s+language\s*=\s*(php|"php"|'php')\s*>/i opening tag
* /</script>/i closing tag
* asp_tags ini directive

show more ...

using pointer to the tsrm ls cache instead of a function call

yet another approach

cleanup TSRMLS_FETCH

reworked the patch, less new stuff but worky

TLS is already used in TSRM, the way exporting the tsrm cache through
a thread local variable is not portable. Additionally, the current

reworked the patch, less new stuff but worky

TLS is already used in TSRM, the way exporting the tsrm cache through
a thread local variable is not portable. Additionally, the current
patch suffers from bugs which are hard to find, but prevent it to
be worky with apache. What is done here is mainly uses the idea
from the RFC patch, but

- __thread variable is removed
- offset math and declarations are removed
- extra macros and definitions are removed

What is done merely is

- use an inline function to access the tsrm cache. The function uses
the portable tsrm_tls_get macro which is cheap
- all the TSRM_* macros are set to placebo. Thus this opens the way
remove them later

Except that, the logic is old. TSRMLS_FETCH will have to be done once
per thread, then tsrm_get_ls_cache() can be used. Things seeming to be
worky are cli, cli server and apache. I also tried to enable bz2
shared and it has worked out of the box. The change is yet minimal
diffing to the current master bus is a worky start, IMHO. Though will
have to recheck the other previously done SAPIs - embed and cgi.

The offsets can be added to the tsrm_resource_type struct, then
it'll not be needed to declare them in the userspace. Even the
"done" member type can be changed to int16 or smaller, then adding
the offset as int16 will not change the struct size. As well on the
todo might be removing the hashed storage, thread_id != thread_id and
linked list logic in favour of the explicit TLS operations.

show more ...

Simply make_printable_zval

it's possible to remove make_printable_zval at all
but it will be a API break

native tls initial patch

Fixed built on OSX

Avoid double IS_INTERNED() check

Fix for Clang

that's not char * but zend_string *

ups, this is not needed

fix CG(empty_string) init in ZTS

Switch (un)mangle property name to size_t and zend_string

Also use the _ex variants where possible.

Use more accurate sizeof

This is allocating an array of zval*s, not zval**s.

made Visual Studio to understand that zend_error_noreturn() will not return

- windows only, on linux gcc would cause a warning that the function returns,
as no noreturn functions are u

made Visual Studio to understand that zend_error_noreturn() will not return

- windows only, on linux gcc would cause a warning that the function returns,
as no noreturn functions are used
- ZEND_NORETURN works on windows as well now, using __declspec(noreturn),
which is useful for the other cases
- one more function call will be needed, which is not critical for the
error reporting
- the way is open to enable the same for gcc as soon as it's not causing a warning

show more ...

Reintroduce fix from pull #770 in a PHP 7 way