Use separate typedef for bucket comparison function

Avoid performing the same casting dance inside each sort compare
function.

Require all internal functions to have arginfo

[skip ci] Fix typos in UPGRADING

Closes GH-5183

Make ASSIGN, ASSIGN_OP, INC and DEC opcodes to return IS_TMP_VAR instead of IS_VAR.

This helps to avoid unnecessary IS_REFERENCE checks.
This changes some notices "Only variables should

Make ASSIGN, ASSIGN_OP, INC and DEC opcodes to return IS_TMP_VAR instead of IS_VAR.

This helps to avoid unnecessary IS_REFERENCE checks.
This changes some notices "Only variables should be passed by reference" to exception "Cannot pass parameter %d by reference".

Also, for consistency, compile-time fatal error "Only variables can be passed by reference" was converted to exception "Cannot pass parameter %d by reference"

show more ...

Apply custom format/length modifier removal to spprintf

This mimicks the changes made to the custom snprintf implementation
by removing the custom 'v' format and custom 'I' length modifi

Apply custom format/length modifier removal to spprintf

This mimicks the changes made to the custom snprintf implementation
by removing the custom 'v' format and custom 'I' length modifier
from the spprintf implementation.

Closes GH-5108

show more ...

Drop the custom 'v' format from snprintf custom implementation.

Extensions should instead use the standard 's' format.

Closes GH-5100

Drop the custom I length modifier from snprintf custom implementation.

Extensions should rather use the ZEND_LONG_FMT, ZEND_ULONG_FMT and
ZEND_XLONG_FMT macros defined in php-src/Zend/ze

Drop the custom I length modifier from snprintf custom implementation.

Extensions should rather use the ZEND_LONG_FMT, ZEND_ULONG_FMT and
ZEND_XLONG_FMT macros defined in php-src/Zend/zend_long.h

Closes GH-5089

show more ...

uint/ulong removal may affect other platforms as well

Fix typo [ci skip]

Comparison cleanup:

- introduce zend_compare() that returns -1,0,1 dirctly (without intermediate zval)
- remove compare_objects() object handler, and keep only compare() handler

[ci skip] Update UPGRADING.INTERNALS

Cf. <http://git.php.net/?p=php-src.git;a=commit;h=0c7124e6beff0a7b0540691db370148be06d242a>.

upgrading notes for ValueError/zend_value_error()

Simplify TMP/VAR operand releasing

Add upgrading entries

[ci skip]

Fix internals upgrading log

Update changelog

Update changelogs

Update changelog

Update changelog

Update changelog

Symbol HAVE_PCRE has been removed

Update changelogs

- PHP-7.4 alpha, beta, RC versions already include bugs logged in the
NEWS
- some links to RFCs
- php_error_docref0

Throw notice on array access on illegal type

No notice is thrown for list() accesses, because we did not come
to an agreement regarding patterns like

while ([$key, $value] =

Throw notice on array access on illegal type

No notice is thrown for list() accesses, because we did not come
to an agreement regarding patterns like

while ([$key, $value] = yield $it->next()) { ... }

where silent null access may be desirable.

No effort is made to suppress multiple notices in access chains
likes $x[0][0][0], because the technical complexity this causes
does not seem worthwhile.

RFC: https://wiki.php.net/rfc/notice-for-non-valid-array-container

show more ...

Catch up with recent changes [ci skip]

- RFC about password_hash portability improvements added
- build system minor updates noted
- typos

Replace ZEND_ASSIGN_ADD (and others) by ZEND_ASSIGN_OP, ZEND_ASSIGN_DIM_OP, ZEND_ASSGIN_OBJ_OP and ZEND_ASSIGN_STATIC_PROP_OP