Fix run-tests.php hanging when a worker process dies without notice (#9931)

run-tests.php with `-jN` can hang if a parallel worker dies without notice. This
can happen due to fatal error

Fix run-tests.php hanging when a worker process dies without notice (#9931)

run-tests.php with `-jN` can hang if a parallel worker dies without notice. This
can happen due to fatal errors in the worker, or if the worker is killed.

- run-tests.php (main process)
\_ run-tests.php (worker #0) // main process hangs if this one crashes
\_ test-001.php (test-001.phpt)

show more ...

Migrate i386 to GitHub actions

Closes GH-9856

Make run-tests.php check for tcp fwrite edge cases (#9242)

When the recipient is busy or the payload is large, fwrite can block
or return a value smaller than the length of the stream.

Make run-tests.php check for tcp fwrite edge cases (#9242)

When the recipient is busy or the payload is large, fwrite can block
or return a value smaller than the length of the stream.

workers in run-tests.php communicates over tcp sockets with the manager.

https://cirrus-ci.com/task/5315675320221696?logs=tests#L130
showed notices for fwrite/unserialize

This is a similar approach to the approach used in
https://github.com/phan/phan/blob/v5/src/Phan/LanguageServer/ProtocolStreamWriter.php
for the tcp language server writing.

show more ...

Do not require opcache.preload_user in cli SAPIs

Fix run-tests.php for explicitly given test cases

The recent improvement to list skipped extensions explicitly[1] missed
to properly initialize `$ignored_by_ext` for the case where an ex

Fix run-tests.php for explicitly given test cases

The recent improvement to list skipped extensions explicitly[1] missed
to properly initialize `$ignored_by_ext` for the case where an explicit
set of test cases are given; this was not a problem previously, since
the undefined *global* variable was coerced to int. We fix this by
initializing the variable earlier.

[1] <https://github.com/php/php-src/commit/baef47ef3eafc37a4e69ef4ca530206517425768>

Closes GH-9617.

show more ...

List skipped extensions explicitly

We also fix the summary alignment for 10k+ tests.

Closes GH-8363.

Use external diff tool if TEST_PHP_DIFF_CMD env var is set

Fix run-tests.php --no-progress flag for non-parallel testing

Add --[no-]progress option to run-tests.php (#9255)

Previously, adding the -g argument would disable progress, even locally.
Now it needs to be disabled explicitly.

Hide skipped tests in CI (#9163)

Add opcache.preload_user=root to run-tests.php if root

This prevents breaking the testsuite when running it as root.

[run-tests.php] echo call performance optimization

[run-tests.php] Combine multiple `str_replace` calls to a single `strtr` call

Makes the replacement easier to see, neatly aligned, and only takes one function call.
This is safe because

[run-tests.php] Combine multiple `str_replace` calls to a single `strtr` call

Makes the replacement easier to see, neatly aligned, and only takes one function call.
This is safe because none of the combined replacement values contain tokens that would be recursively replaced.

This also improves the readability on how the regular expressions in `EXPECTF` matcher is constructed.

Co-authored-by: Michael Voříšek <mvorisek@mvorisek.cz>

show more ...

[run-tests.php] Replace backtick operator string literals with `shell_exec()` calls

The rationale is that `shell_exec()` is identical to the backtick operator (both of which are disabled whe

[run-tests.php] Replace backtick operator string literals with `shell_exec()` calls

The rationale is that `shell_exec()` is identical to the backtick operator (both of which are disabled when `shell_exec` function is disabled) makes it very clear that it is a shell execution, and eases security audits too.

show more ...

[run-tests.php] Merge multiple `unset()` calls to a single call

[run-tests.php] Minor optimizations in `if` blocks by placing simple expressions first

[run-tests.php] Improve non-optimal nested `if`/`elseif`/`else` blocks with happy path optimizations

Simplifies and improves the readability of multiple `if`/`elseif`/`else` blocks by removi

[run-tests.php] Improve non-optimal nested `if`/`elseif`/`else` blocks with happy path optimizations

Simplifies and improves the readability of multiple `if`/`elseif`/`else` blocks by removing them when an earlier branch exists the execution flow by either returning or terminating the script.

show more ...

Fix --CGI-- support of run-tests.php

The `--CGI--` section is supposed to be just a marker, and to be empty
as such. However, a previous refactoring[1] broke that.

[1] <https:/

Fix --CGI-- support of run-tests.php

The `--CGI--` section is supposed to be just a marker, and to be empty
as such. However, a previous refactoring[1] broke that.

[1] <https://github.com/php/php-src/commit/9140c9038a83ff55a78f357f8485de086d83d94e>

Closes GH-9061.

show more ...

Fix "%f" regex in run-tests.php (#8965)

"-.0.0" and "0." is no longer matched wrongly

Fix GH-8691 Add required extensions for redirected tests

Avoid accessing undefined variables in run-tests.php (#8669)

The $php_cgi and $phpdbg cases here are definitely real bugs, and
caused the script to bail out under certain ini settings.

Avoid accessing undefined variables in run-tests.php (#8669)

The $php_cgi and $phpdbg cases here are definitely real bugs, and
caused the script to bail out under certain ini settings.

The other paths may actually be unreachable in practice, but were
highlighted by PhpStorm.

show more ...

[ci skip] Drop ability to send QA reports by email (#8657)

This fails regularly and on top of that we don't look at these reports.

Deprecate ${} string interpolation

https://wiki.php.net/rfc/deprecate_dollar_brace_string_interpolation

typo

run-tests.php: fix TypeError: Unsupported operand types: string * int <n> is mandatory for --show-slow and --set-timeout use <n> in help message instead of confusing [n]