Use RETURN_THROWS() after zend_throw_exception() in most of the extensions

Use RETURN_THROWS() after zend_throw_error()

Use RETURN_THROWS() after zend_type_error()

Use RETURN_THROWS() after zend_value_error()

Use RETURN_THROWS() when an exception is thrown

Closes GH-5036

Speed up array_intersect/array_diff/array_filter

Use zend_hash_update instead of zend_hash_add.

These are taking a subset of keys from an array with unique keys,
so the result s

Speed up array_intersect/array_diff/array_filter

Use zend_hash_update instead of zend_hash_add.

These are taking a subset of keys from an array with unique keys,
so the result should also have unique keys.
(this is already done for array_map())

Also, speed up array_intersect and array_diff slightly by
using ZEND_HASH_FOREACH macros.
This way, it doesn't need to load the same buckets and array counts
from memory every time (compiler previously couldn't infer they won't change)

```php
<?php
// $n=10000 now takes 0.095 seconds instead of 0.102
function test_bench(int $n) {
$values = range(0,1000);
$other = range(0,1000);
unset($other[500]);
unset($values[400]);

$total = 0;
for ($i = 0; $i < $n; $i++) {
$total += count(array_intersect_key($values, $other));
}
return $total;
}
```

show more ...

Capitalize first character of error message.

Convert Errors to ValueErrors

Closes GH-4930

Merge branch 'PHP-7.4'

* PHP-7.4:
Fixed bug #78759

Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
Fixed bug #78759

Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
Fixed bug #78759

Fixed bug #78759

Handle INDIRECT values in array.

Fix consistency issues with array accesses warnings/exceptions

* Change a number of "resource used as offset" notices to warnings,
which were previously missed.
* Throw the "res

Fix consistency issues with array accesses warnings/exceptions

* Change a number of "resource used as offset" notices to warnings,
which were previously missed.
* Throw the "resource used as offset" warning for isset() as well.
* Make array_key_exists() behavior with regard to different key
types consistent with isset() and normal array accesses. All key
types now use the usual coercions and array/object keys throw
TypeError.

Closes GH-4887.

show more ...

Remove support for array_key_exists() with objects

Update documentation/comment for GH-4860

Fix folding for the new helper method.

Clarify comment in UPGRADING:
The performance on associative arrays would also improve,
as lo

Update documentation/comment for GH-4860

Fix folding for the new helper method.

Clarify comment in UPGRADING:
The performance on associative arrays would also improve,
as long as no offsets were unset (no gaps).
Packed arrays can have gaps.

Closes GH-4873.
[ci skip]

show more ...

Optimize array_slice for packed arrays with large offsets

If the offset is 100000, and there are no gaps in the packed/unpacked array,
then advance the pointer once by 100000,
instea

Optimize array_slice for packed arrays with large offsets

If the offset is 100000, and there are no gaps in the packed/unpacked array,
then advance the pointer once by 100000,
instead of looping and skipping 100000 times.

Add a new test of array_slice handling unset offsets.

Closes GH-4860.

show more ...

Allow array_splice() length to be null

Add Z_PARAM_LONG_OR_NULL macro

Comparison cleanup:

- introduce zend_compare() that returns -1,0,1 dirctly (without intermediate zval)
- remove compare_objects() object handler, and keep only compare() handler

Fix required number of arguments in stubs

* get_parent_class() argument is optional
* Mark array_filter() $callback as optional
* The $base of gmp_strval() is optional
* DateTime

Fix required number of arguments in stubs

* get_parent_class() argument is optional
* Mark array_filter() $callback as optional
* The $base of gmp_strval() is optional
* DateTime constructor also accepts zero arguments
* hash_update_file() stream context is optional
* xmlwriter_write_dtd_entity() $isparam argument is optional

show more ...

Remove most uses of ZEND_PARSE_PARAMETERS_END_EX()

As ZPP now throws, it makes no sense to specify an explicit return
value.

Promote warnings to error in array_flip()

Closes GH-4576.

Promote warnings to errors in array_push()

This is in line with the engine change from
https://wiki.php.net/rfc/engine_warnings.

Remove mention of PHP major version in Copyright headers

Closes GH-4732.

Indicate entry is skipped in error message