Fix GH-14290: Member access within null pointer in extension spl

php_pcre_replace_impl() can fail and return NULL. We should take that
error condition into account. Because other failure

Fix GH-14290: Member access within null pointer in extension spl

php_pcre_replace_impl() can fail and return NULL. We should take that
error condition into account. Because other failures return false, we
return false here as well.

At first, I also thought there was a potential memory leak in the error
check of replacement_str, but found that the error condition can never
trigger, so replace that with an assertion.

Closes GH-14292.

show more ...

general signatures discrepencies fixes (#13122)

Minor pcre optimizations (#12923)

* Update signature of pcre API

This changes the variables that are bools to actually be bools instead
of ints, which allows some additional opt

Minor pcre optimizations (#12923)

* Update signature of pcre API

This changes the variables that are bools to actually be bools instead
of ints, which allows some additional optimization by the compiler (e.g.
removing some ternaries and move extensions).

It also gets rid of the use_flags argument because that's just the same
as flags == 0. This reduces the call frame.

* Use zend_string_release_ex where possible

* Remove duplicate symbols from strchr

* Avoid useless value conversions

* Use a raw HashTable* instead of a zval

* Move condition

* Make for loop cheaper by reusing a recently used value as start iteration index

* Remove useless condition

This can't be true if the second condition is true because it would
require the string to occupy the entire address space.

* Upgrading + remark

show more ...

Remove dead stores from ext/spl (#12550)

ext/spl: Use new F ZPP modifier

Use new ZSTR_INIT_LITERAL macro (#10879)

Use zend_result in ext/spl where appropriate (#10734)

* Convert functions in spl_heap to return zend_result

* Convert functions in spl_iterators to return zend_result

chore: standardize the visibility of functions. (#10708)

Co-authored-by: Marcos Marcolin <marcos@ixcsoft.com.br>

Handle trampolines correctly in new FCC API + usages (#9877)

Refactor SPL Callback filter to only use FCC

Remove most usages of zend_fcall_info_args()

This reallocates the PHP array when one can just use the named_params fields to pass the positional arguments instead.

Only usage of zen

Remove most usages of zend_fcall_info_args()

This reallocates the PHP array when one can just use the named_params fields to pass the positional arguments instead.

Only usage of zend_fcall_info_args(_ex) remains in PDO.

show more ...

Use zend_call_function_with_return_value() in SPL iterators

Fix reference returned from CallbackFilterIterator::accept()

Fixes oss-fuzz #58181

Revert "Port all internally used classes to use default_object_handlers"

This reverts commit 94ee4f9834743ca74f6c9653863273277ce6c61a.

The commit was a bit too late to be included i

Revert "Port all internally used classes to use default_object_handlers"

This reverts commit 94ee4f9834743ca74f6c9653863273277ce6c61a.

The commit was a bit too late to be included in PHP 8.2 RC1. Given it's a massive ABI break, we decide to postpone the change to PHP 8.3.

show more ...

Port all internally used classes to use default_object_handlers

Signed-off-by: Bob Weinand <bobwei9@hotmail.com>

Declare ext/spl constants in stubs (#9226)

RFC: Make the `iterator_*()` family accept all `iterable`s (#8819)

https://wiki.php.net/rfc/iterator_xyz_accept_array

Fix GH-8235: iterator_count() may run indefinitely

We need to prevent integer overflow to eventually stop the iteration.

A test case doesn't appear sensible for this, because even o

Fix GH-8235: iterator_count() may run indefinitely

We need to prevent integer overflow to eventually stop the iteration.

A test case doesn't appear sensible for this, because even on 32bit
architectures a respective test easily runs for a few minutes.

Closes GH-8447.

show more ...

SPL: minor refactoring (#8341)

Use more appropriate types and return macros

Stop including php_pcre.h from spl_iterators.h

This fixes GH-7774.

spl_iterators.h was including php_pcre.h so that one object intern struct could
reference a pcre_cache_entry.

Stop including php_pcre.h from spl_iterators.h

This fixes GH-7774.

spl_iterators.h was including php_pcre.h so that one object intern struct could
reference a pcre_cache_entry. These object interns should not be public, so they
can be moved out of the header file.

This change moves the object interns ouf of spl_iterators.h so that php_pcre.h
doesn't need to be included from there.

show more ...

Fix leak when iterating uninitialized RecursiveIteratorIterator

Add RETURN/RETVAL_COPY_DEREF() macros

These were missing from the set...

I think quite a few of these usages don't actually need the DEREF,
but I've just kept things as is for n

Add RETURN/RETVAL_COPY_DEREF() macros

These were missing from the set...

I think quite a few of these usages don't actually need the DEREF,
but I've just kept things as is for now.

show more ...

Fix RecursiveIteratorIterator segfault for invalid aggregate

The code was assuming that the returned value is an object.
Reuse the logic from IteratorIterator.

Revert "IteratorIterator::getInnerIterator() can't return null"

This reverts commit c252420d0842b1f7ea3891695bb6de3c9ec9a57c.

This (currently) does not hold for invalid AppendIterat

Revert "IteratorIterator::getInnerIterator() can't return null"

This reverts commit c252420d0842b1f7ea3891695bb6de3c9ec9a57c.

This (currently) does not hold for invalid AppendIterators,
revert for now.

show more ...

IteratorIterator::getInnerIterator() can't return null

If ther IteratorIterator is initialized (which we check), then
zobject cannot be undef and the return value cannot be null.