Return false from failed mb_convert_variables()

If we fail to detect the encoding return false, just like
mb_convert_encoding() does, and the implementation here clearly
intended. Pr

Return false from failed mb_convert_variables()

If we fail to detect the encoding return false, just like
mb_convert_encoding() does, and the implementation here clearly
intended. Previously the "pass" pseudo-incoding was returned.

show more ...

Fix assertion failure when failing to detect encoding

Looks like prior to 7.3 this just passed the original string
through. Since 7.3 it returns false. Let's stick with that
behavior.

Remove persistent allocators from libmbfl

These functions are not used, and I don't think we have any plans
to ever use them.

Improve a last couple of argument error messages

Closes GH-5404

Improve some TypeError and ValueError messages

Closes GH-5377

Adapt assertion as mbfl_strwidth returns a size_t

Convert if blocks to assertions and adapt stubs accordingly

Revert "Fix Bug #79448 0 is a valid Unicode codepoint, but mb_substitute_character(0) fails"

This commit brings some substantial changes in behaviour due to the weird implementation.
Thi

Revert "Fix Bug #79448 0 is a valid Unicode codepoint, but mb_substitute_character(0) fails"

This commit brings some substantial changes in behaviour due to the weird implementation.
This will be fixed in master due to BC concerns.

This reverts commit 1333b46d6dc0c293c1fd626803f91bc69743eb79.

show more ...

Generate function entries for another batch of extensions

Closes GH-5352

Promote invalid case mode to ValueError in mb_case_converter

Add assertions to check the return value is not NULL as this indicates a bug.
Add identical assertion to mb_strtoupper and mb

Promote invalid case mode to ValueError in mb_case_converter

Add assertions to check the return value is not NULL as this indicates a bug.
Add identical assertion to mb_strtoupper and mb_strtolower.
This means these functions can't return false anymore, ammend stubs accordingly.

show more ...

mb_scrub() can't return false anymore

Also drop the intermediary function which was only used here

Promote some warnings to ValueError in mbstring

Promoted warnings are:
* Empty encoding lists
* Unknown language
* Start and Width out of bound

Convert some if blocks to assertions

Fix Bug #79448 0 is a valid Unicode codepoint, but mb_substitute_character(0) fails

Promote unknown encoding throws in encoding array/string list

For the string list we emit still emit a warning by comparing arg_num to 0

Closes GH-5337

Refactor mb_substr_count()

Promote empty needle warning to ValueError
Convert if branch into an assertion as if mbfl_substr_count fails this now implies a bug
Thus mb_substr_count()

Refactor mb_substr_count()

Promote empty needle warning to ValueError
Convert if branch into an assertion as if mbfl_substr_count fails this now implies a bug
Thus mb_substr_count() can only return int now, fix stubs accordingly

show more ...

Convert if branch to assertion in mb_strlen

This operation should never fail, therefore it's converted to an assertion.
Thus this mb_strlen() can now only return int, fix stubs according

Convert if branch to assertion in mb_strlen

This operation should never fail, therefore it's converted to an assertion.
Thus this mb_strlen() can now only return int, fix stubs accordingly

show more ...

Promote mb_str_split warning to ValueError

Also add a TODO about documenting this funcion on PHP.net
Convert some checks to assertions as if they don't hold something went wrong during m

Promote mb_str_split warning to ValueError

Also add a TODO about documenting this funcion on PHP.net
Convert some checks to assertions as if they don't hold something went wrong during memory allocation
Due to these changes this function cannot return false anymore, fix stubs accordingly

show more ...

Merge mb_strstr() variants under a common implementation

This reduces heavy ducplicate code

Improve code flow

These nested if-else blocks are unnecessary since we return early.

Promote empty string warning to ValueError in mb_ord()

Fix bug 79441

Promote unsupported encoding warnings to ValueError

Use php_mb_get_encoding instead of mbfl_name2encoding to get encoding

This reduces the number of places where the error message template is used.
Also promote the mb_check_encoding() war

Use php_mb_get_encoding instead of mbfl_name2encoding to get encoding

This reduces the number of places where the error message template is used.
Also promote the mb_check_encoding() warning to ValueError and add a test to cover the behaviour.

show more ...

Move encoding fetching out of php_mb_convert_encoding()