Apply tidy formatting

Mostly reindent PHP scripts to spaces.

Add WHITESPACE_SENSITIVE run-tests section

This is used to indicate that the test should not be changed by
automated formatting changes.

Don't use CRLF when generating diffs

Use smaller batch size in run-tests.php when appropriate

- When valgrind is used, communication overhead is relatively small,
so just use a batch size of 1.
- If this is running a

Use smaller batch size in run-tests.php when appropriate

- When valgrind is used, communication overhead is relatively small,
so just use a batch size of 1.
- If this is running a small enough number of tests,
reduce the batch size to give batches to more workers.
(Previously, if there were 90 tests and -j8,
only 3 of 8 workers would get a batch of size 32 or less.
After this change, the batch size is 12 or less)

Closes GH-5098

show more ...

Don't start unnecessary processes with run-tests.php -j

If there's only 2 files to test, then only start 2 workers instead of N.

If there's only 1 file, then avoid parallelism entir

Don't start unnecessary processes with run-tests.php -j

If there's only 2 files to test, then only start 2 workers instead of N.

If there's only 1 file, then avoid parallelism entirely.
A separate option such as `--force-parallel` could be added
if this turns out to be something developers would want to do
when debugging test failures.

show more ...

Avoid some @count() suppressions in run-tests.php

Use IS_WINDOWS

Replace fakemail with minimal PHP script

Unify mail related tests for *nix and Windows

Currently mail related tests are split for *nix and Windows (if there
are even Windows versions). The basic difference is that the *nix

Unify mail related tests for *nix and Windows

Currently mail related tests are split for *nix and Windows (if there
are even Windows versions). The basic difference is that the *nix
variants set the INI directive sendmail_path to just write the email to
disk, while the Windows tests use ext/imap. The latter tests are way
more verbose, and such duplicated tests are generally a pain point.
Furthermore, the Windows tests are much slower, and could not be run
without ext/imap being available.

We therefore introduce a small fakemail application, which basically
works like `tee <path> >/dev/null`, and which will be shipped with the
Windows tests packs. fakemail.exe would also need to be added to the
PHP binary SDK, so these tests could be run during developments.

To cater to the remaining differences, we also introduce support for
`{MAIL:<path>}` placeholders in the INI sections to run-tests.php. How
to use this can be seen in mail_basic.phpt, which is currently the only
modified test case, because these tests are yet supposed to fail on
Windows, due to the missing fakemail.exe in the PHP SDK.

show more ...

Set zend.exception_ignore_args=0 in run-tests.php

Any existing tests are going to be written under this assumption...

Make test runner runnable without arguments

The default PHP executable was not set when no args were provided.

Closes GH-4894.

Define IS_WINDOWS in the test runner

Avoid code duplication

Closes GH-4866.

Set display_startup_errors=0 when running skipif

Now that we're displaying errors in skipif, suppress this particular
category. Otherwise we get warnings in the SKIPIF of tests with

Set display_startup_errors=0 when running skipif

Now that we're displaying errors in skipif, suppress this particular
category. Otherwise we get warnings in the SKIPIF of tests with
EXTENSION where the extension does not exist, and there's no way
to suppress them.

show more ...

Bail out if JUNIT is not enabled

Otherwise we would try to access an array element of `false`, which
issues a notice as of PHP 7.4.0. This would happen, for instance, for
bug63447_0

Bail out if JUNIT is not enabled

Otherwise we would try to access an array element of `false`, which
issues a notice as of PHP 7.4.0. This would happen, for instance, for
bug63447_001.phpt if CGI is not available.

show more ...

Delete temporary .post files of run-tests.php

Commit 5649267[1] changed run-tests.php to only delete .post files for
passing tests. However, that code wouldn't be exercised at all, sinc

Delete temporary .post files of run-tests.php

Commit 5649267[1] changed run-tests.php to only delete .post files for
passing tests. However, that code wouldn't be exercised at all, since
`run_test()` already returned, so we move the deletion upwards.

[1]
<http://git.php.net/?p=php-src.git;a=commit;h=5649267b257c78e46a934434c0bff894e0b5b694>

show more ...

Require a space ofter run-tests "warn"

We don't want to treat a PHP "Warning: " as a run-tests warn.

Mark test as borked when skipif produces invalid output

SKIPIF section should either output nothing, or start with a
supported keyword like "skip". Mark all tests that don't do so as

Mark test as borked when skipif produces invalid output

SKIPIF section should either output nothing, or start with a
supported keyword like "skip". Mark all tests that don't do so as
BORKED.

show more ...

Remove mention of PHP major version in Copyright headers

Closes GH-4732.

Fix reporting of redirect test failures in junit

These were being reported under the wrong name ... which means that
they don't show up as failures on azure :(

Fix handling of succeeding XFAIL tests

Due to a typo in commit e1151c9[1], succeeding XFAIL test without an
EXPECTF or EXPECTREGEX section have been reported reported as passed
inste

Fix handling of succeeding XFAIL tests

Due to a typo in commit e1151c9[1], succeeding XFAIL test without an
EXPECTF or EXPECTREGEX section have been reported reported as passed
instead of warned.

[1] <http://git.php.net/?p=php-src.git;a=commit;h=e1151c9549cf5a7235c1609019f79bbb1bbcdbea>

show more ...

Remove .post files only for passing tests

This allows the sh script for failing tests with --POST-- to work

Cleanup of remaining E_STRICT in tests

Fix failed tests for phar

- when $status is boolean, E_NOTICE appears and tests fail
- opcache is never enabled on these tests anyway.
- Add opcache.revalidate_freq=0 to testing scri

Fix failed tests for phar

- when $status is boolean, E_NOTICE appears and tests fail
- opcache is never enabled on these tests anyway.
- Add opcache.revalidate_freq=0 to testing script

Instead of checking this in the tests files it can be used directly in
the main testing script. Also this fixes failed tests.

- Use opcache_invalidate() instead of sleep() delay in some tests. Some
delays are still used since the opcache_invalidate seems to be buggy
and not working as expected.

Closes GH-4392

show more ...

Deprecate alternative array access syntax

RFC: https://wiki.php.net/rfc/deprecate_curly_braces_array_access

Remove remaining lightnings from run-tests.php

The classic Windows console only supports the Unicode BMP, so it can't
handle the LIGHTNING MOOD character (U+1F5F2). It also seems that

Remove remaining lightnings from run-tests.php

The classic Windows console only supports the Unicode BMP, so it can't
handle the LIGHTNING MOOD character (U+1F5F2). It also seems that
common fonts do not support the LIGHTNING (U+2607) character, so a
general removal is appropriate.

However, Windows is already "ready for the future"[1], but PHP for
Windows is not (yet).

[1] <https://devblogs.microsoft.com/commandline/windows-command-line-unicode-and-utf-8-output-text-buffer/>

show more ...