Fixed JIT for LONG->DOUBLE conversion when optimizer disabled

Fixed incorrect JIT compilation

Optimize $x === null into is_null($x)

Fixed JIT for TYPE_CHECK opcode (exception handling in case of undefined argument)

Implement union types

According to RFC: https://wiki.php.net/rfc/union_types_v2

The type representation now makes use of both the pointer payload
and the type mask at the same t

Implement union types

According to RFC: https://wiki.php.net/rfc/union_types_v2

The type representation now makes use of both the pointer payload
and the type mask at the same time. Additionall, zend_type_list is
introduced as a new kind of pointer payload, which is used to store
multiple class types. Each of the class types is a tagged pointer,
which may be either a class name or class entry. The latter is only
used for typed properties, while arguments/returns will instead use
cache slots. A type list can contain a mix of both names and CEs at
the same time, as not all classes may be resolvable.

One thing this is missing is support for union types in arginfo
and stubs, which I want to handle separately.

I've also dropped the special object code from the JIT implementation
for now -- I plan to add this back in a different form at a later time.
For now I did not want to include non-trivial JIT changes together
with large functional changes.

Another possible piece of follow-up work is to implement "iterable"
as an internal alias for "array|Traversable". I believe this will
eliminate quite a few special-cases that had to be implemented.

Closes GH-4838.

show more ...

Make zend_type a 2-field struct

We now store the pointer payload and the type mask separately. This
is in preparation for union types, where we will be using both at
the same time.

Make zend_type a 2-field struct

We now store the pointer payload and the type mask separately. This
is in preparation for union types, where we will be using both at
the same time.

To avoid increasing the size of arginfo structures, the
pass_by_reference and is_variadic fields are now stored as part of
the type_mask (8-bit are reserved for custom use).

Different types of pointer payloads are distinguished based on bits
in the type_mask.

show more ...

Don't check $this existence in object opcodes

We are now guaranteed that $this always exists inside methods, as
well as insides closures (if they use $this at all).

This removes

Don't check $this existence in object opcodes

We are now guaranteed that $this always exists inside methods, as
well as insides closures (if they use $this at all).

This removes checks for $this existence from the individual object
opcodes. Instead ZEND_FETCH_THIS is used in the cases where $this
is not guaranteed to exist, which is mainly the pseudo-main scope.

Closes GH-3822.

show more ...

Try to fix asan warning in scalar_constant_defaults.phpt

Doing the SAVE_VALID_OPLINE right before the call, because we
still need r0 before that.

JIT: Add option to disable SSA checks

JIT: Handle typed refs in assign dim

JIT: Fix handling of typed ref in assign dim op

JIT: Fix handling of typed ref in assign op

JIT: Check exception after jit_assign_dim_op_helper

Clenup "smart branch" handling

Fixed wrong shift

Relay on DO_ICALL/DO_UCALL opcode to avoid generation of useless code

Fixed exception handling

Clenup "smart branch" handling

Fixed exception source

Use "const" qualifier

Fixed incorrect JIT compilation

Fixed incorrect JIT compilation

Convert some notices to warnings

Part of https://wiki.php.net/rfc/engine_warnings.

Revert "Save opline before fallible arg type check in recv_init jit"

This reverts commit b09bddcaa5d6af94f0b94b324c1f52045c909d5e.

This causes test failures on macos -- presumably t

Revert "Save opline before fallible arg type check in recv_init jit"

This reverts commit b09bddcaa5d6af94f0b94b324c1f52045c909d5e.

This causes test failures on macos -- presumably the relevant
difference is that it has no global regs. I suspect that this
is related to the fact that SAVE_VALID_OPLINE may use r0 as
a scratch register, which is already in use. Reverting for now.

show more ...

Save opline before fallible arg type check in recv_init jit

The verify arg functions may throw an exception, so we need to save
the opline beforehand. Asan failures could be observed in

Save opline before fallible arg type check in recv_init jit

The verify arg functions may throw an exception, so we need to save
the opline beforehand. Asan failures could be observed in
Zend/tests/type_declarations/scalar_constant_defaults.phpt
with a ZTS build.

show more ...