Fix iterable return type optimization

Fix exif leak on duplicate copyright tags

Fix typo

`sizeof("data")-1` and `sizeof("date")-1` are both 4, so no change in behaviour

Increase timeout in test

Fix #76342: file_get_contents waits twice specified timeout

Add tilde to allowed status/ping path

Because of user specific webdirs it should be possible to set a
status/ping path like "/~username/status".

Closes GH-4698.

Fix opcache return type for get_headers in zend_func_info

https://www.php.net/manual/en/function.get-headers.php#refsect1-function.get-headers-examples
shows that it will return string k

Fix opcache return type for get_headers in zend_func_info

https://www.php.net/manual/en/function.get-headers.php#refsect1-function.get-headers-examples
shows that it will return string keys when the second argument is
non-zero. I've verified that this is the case.

This bug was there since the initial commit in c88ffa9a567.

Closes GH-4702.

show more ...

Fixed bug #78545

By using an explicit (double) cast.

Fix leak in SplObjectStorage unserialization

The result of php_var_unserialize always needs to be destroyed,
even if the call failed.

Stick with zend_long for ABI compatibility

Cf. <https://github.com/php/php-src/pull/4700#issuecomment-531515689>.

Fix #78535: auto_detect_line_endings value not parsed as bool

NEWS

Fixed bug #78442 ('Illegal component' on exif_read_data since PHP7)

Bump for 7.2.24

Raise minimal GCC version,
Test with 4.8 is OK
With 4.4: error: #pragma GCC diagnostic not allowed inside functions

Drop regression test

The state returned by `sodium_crypto_generichash_init()` has to be
regarded as opaque byte string; neither its size nor its exact
structure are fixed, and actual

Drop regression test

The state returned by `sodium_crypto_generichash_init()` has to be
regarded as opaque byte string; neither its size nor its exact
structure are fixed, and actually vary for diffent libsodium versions.
Therefore we drop the test altogether.

show more ...

Fix bug #72884 isCloneable() on SplFileObject should return false

Fix #78510: Partially uninitialized buffer returned by sodium_crypto_generichash_init()

Backport jedisct1/libsodium.php@28d13bf437cb969a0583031fc7ac54c5a8dc8116.

Fix #41997: SP call yields additional empty result set

When stored procedures are called, the "final result set is a status
result that includes no result set". Calling `::nextRowset()`

Fix #41997: SP call yields additional empty result set

When stored procedures are called, the "final result set is a status
result that includes no result set". Calling `::nextRowset()` on the
actual last result set should return FALSE, since there is actually no
further result set to be processed.

show more ...

Fix opcache return type for hash_update_stream

It can return false if the resource type is wrong.

```
php > var_export(hash_update_stream(hash_init('md5'),
imagecrea

Fix opcache return type for hash_update_stream

It can return false if the resource type is wrong.

```
php > var_export(hash_update_stream(hash_init('md5'),
imagecreate(1,1)));

Warning: hash_update_stream(): supplied resource is not a valid stream
resource in php shell code on line 1
false
```

The return types were initially added in
c88ffa9a5673cb3141660626ba1921671f0b84d6

show more ...

Fix #76577: outdated documentation concerning track_errors

Fix pkg-config version constraint for ICU

On PHP 7.2 our minimum ICU version is 4.0, not 40.

Fixed bug #78469

fcgi_accept_request function is supposed to call a FastCGI implementation's
on_accept hook when entering an "accepting" stage (that is right before
calling "accept")

Fixed bug #78469

fcgi_accept_request function is supposed to call a FastCGI implementation's
on_accept hook when entering an "accepting" stage (that is right before
calling "accept"). This hook implementation (fpm_request_accepting) updates
a worker state to an "accepting" state which is effectively an "Idle" state,
and updates counters on the scoreboard of the corresponding pool (idle++,
active--).

But this is not done when listening for client connections on a named pipe on
Windows platform. In that case a combination of
ConnectNamedPipe/WaitForSingleObject is used (to be able to catch in_shutdown
as far as I understand), but it is nonetheless functionally equivalent to
"accept" call. Also by not calling on_hook neither a worker's state is updated
to "accepting" state nor scoreboard counters are updated.

show more ...

Fix use-after-free of immediately invoked closure with extra args

Fix #78473: odbc_close() closes arbitrary resources

We have to bail out, if an invalid resource is given. For consistency
with the other `zend_fetch_resource(2)` calls, we return `FALSE

Fix #78473: odbc_close() closes arbitrary resources

We have to bail out, if an invalid resource is given. For consistency
with the other `zend_fetch_resource(2)` calls, we return `FALSE`.

show more ...