trailing whitespace removal

first shot remove TSRMLS_* things

s/PHP 5/PHP 7/

Avoid double IS_INTERNED() check

master renames phase 1

basic macro replacements, all at once

Followup fix to custom session save handlers

2d9885c introduced some regressions. This addresses those.

* Don't throw return type notice or session write failure when in an excep

Followup fix to custom session save handlers

2d9885c introduced some regressions. This addresses those.

* Don't throw return type notice or session write failure when in an exception
* Fix tests to properly return true/false since null is no longer falsy/successy
* Rerecord a few tests to accomodate difference in raised warnings

show more ...

Fix handling of session user module custom handlers.

According to the documentation, returning TRUE from
user based session handlers should indicate success,
while returning FALSE sh

Fix handling of session user module custom handlers.

According to the documentation, returning TRUE from
user based session handlers should indicate success,
while returning FALSE should indicate failure.

The existing logic relied on casting the return value
to an integer and returning that from the function.
However, the internal handlers use SUCCESS/FAILURE
where SUCCESS == 0, and FAILURE == -1, so the following
behavior map occurs:

return false; => return 0; => return SUCCESS
return true; => return 1; => return <undefined>

Since the session API checks against FAILURE,
both boolean responses wind up appearing like "not FAILURE".

This diff reasserts boolean responses to behave as
documented and introduces some special handling
for integer responses of 0 and -1 so that code can be
written for older and newer versions of PHP.

show more ...

Make they are in the same style of Z_ISREF

Fixed retval for ps_call_handler

Refactor session (incompleted)

Bump year

Bump year

Bump year

Reduce compilation noise during normal compilation:
php-5.5/ext/session/session.c:836: warning: unused variable ‘struc’
php-5.5/ext/session/session.c:836: warning: unused variable ‘nu

Reduce compilation noise during normal compilation:
php-5.5/ext/session/session.c:836: warning: unused variable ‘struc’
php-5.5/ext/session/session.c:836: warning: unused variable ‘num_key’
php-5.5/ext/session/session.c:836: warning: unused variable ‘key_length’
php-5.5/ext/session/session.c:836: warning: unused variable ‘key’
php-5.5/ext/session/session.c:835: warning: unused variable ‘key_type’
php-5.5/ext/session/session.c:834: warning: unused variable ‘_ht’
php-5.5/ext/session/session.c:857: warning: unused variable ‘has_value’
php-5.5/ext/session/session.c:856: warning: unused variable ‘namelen’
php-5.5/ext/session/session.c:853: warning: unused variable ‘name’
php-5.5/ext/session/session.c:852: warning: unused variable ‘p’

php-5.5/ext/session/mod_user.c:191: warning: unused variable ‘ret’

show more ...

kick unused var

Add create_sid to session_set_save_handler and SessionHandler

A lot of code already existed to allow a custom create_sid handler, but
lacked a specific implementation.

Therefore

Add create_sid to session_set_save_handler and SessionHandler

A lot of code already existed to allow a custom create_sid handler, but
lacked a specific implementation.

Therefore I have added a 7th (optional) argument
session_set_save_handler, to allow a user function to be supplied for
session id generation.

If a create_sid function is not supplied, the default function is
called in its absence to preserve backwards compatibility.

Likewise create_sid only added to SessionHandler class, and not the
interface to maintain backwards compatibility. If the result is not
overridden, the default is called.

show more ...

Happy New Year

Happy New Year

Happy New Year~

better fix & this test pass now

Fixed bug (segfault due to retval is not initialized)

Attempt to fix segfault due to retval is not initialized

improve the fix

Fixed bug (segfault due to PS(mod_user_implemented) not be reseted when closing handler call exit)