Fix bug #71604

Alternatively could throw some kind of uncatchable dummy exception
into the generator. Right now just checking for NULL in two places
seems simpler.

Forbid "yield from" in force closed generators

Same check we do for "yield", was missed when "yield from" was
added. We could make this more granular by only forbidding to
actually y

Forbid "yield from" in force closed generators

Same check we do for "yield", was missed when "yield from" was
added. We could make this more granular by only forbidding to
actually yield values and still allow something like "yield from []",
but this does not seem worthwhile.

show more ...

Fixed bug #72213 (Finally leaks on nested exceptions).

Squashed commit of the following:

commit 8461b0407fc9eab0869d43b84e6a92ba2fe06997
Author: Dmitry Stogov <dmitry@zend.com>

Fixed bug #72213 (Finally leaks on nested exceptions).

Squashed commit of the following:

commit 8461b0407fc9eab0869d43b84e6a92ba2fe06997
Author: Dmitry Stogov <dmitry@zend.com>
Date: Wed May 25 00:34:42 2016 +0300

Rmoved zend_try_catch_element.parent and walk through op_array.try_catch_array backward from the current try_cacth_offset.

commit 0c71e249649bed178bfbef30bb3e63c57f07af05
Author: Dmitry Stogov <dmitry@zend.com>
Date: Wed May 25 00:04:53 2016 +0300

Move SAVE_OPLINE() to its original place

commit 111432a4df738fcd65878a42f23194dc3c4983a2
Author: Dmitry Stogov <dmitry@zend.com>
Date: Wed May 25 00:01:10 2016 +0300

Separate the common part of ZEND_HANDLE_EXCEPTION and FAST_RET into zend_dispatch_try_catch_finally_helper.

commit 4f21c06c2ec17819a708bc037f318784554a6ecd
Author: Nikita Popov <nikic@php.net>
Date: Tue May 24 14:55:27 2016 +0200

Improve finally fix

commit da5c7274997b8308e682b5bf280124e3a1483086
Author: Dmitry Stogov <dmitry@zend.com>
Date: Tue May 24 10:36:08 2016 +0300

Fixed Zend/tests/try/bug70228_3.phpt and Zend/tests/try/bug70228_4.phpt

commit cfcedf2fb4f4fc1f7de9f7d53a3037fed7795f19
Author: Dmitry Stogov <dmitry@zend.com>
Date: Tue May 24 02:59:27 2016 +0300

Added test

commit 4c6aa93d43da941eb4fda15b48154bfb104bdc04
Author: Dmitry Stogov <dmitry@zend.com>
Date: Tue May 24 00:38:20 2016 +0300

Added tests

commit 8a8f4704b0eca2e460d42c1f253a363b0db8e510
Author: Dmitry Stogov <dmitry@zend.com>
Date: Mon May 23 23:27:34 2016 +0300

Fixed bug #72213 (Finally leaks on nested exceptions)

show more ...

Forbid dynamic calls to scope introspection functions

Per RFC:
https://wiki.php.net/rfc/forbid_dynamic_scope_introspection

Added specialized handler for ZEND_FETCH_DIM_R opcode with only numeric indexes.

Revert "Fixed Bug #72213 (Finally leaks on nested exceptions)"

This reverts commit 5037ebf058bdc94e4426240a6d35fcf427d2eee2.

Inlined fast paths of the freqently execute handlers for FETCH_DIM_R.

Specialize ZEND_ASSIGN_ADD and family according to value of opline->extended_value

Fixed Bug #72213 (Finally leaks on nested exceptions)

IS_CONST operands don't have to be separated. Use reference-counting instead of duplication.

- with opcache all IS_CONST operands are not refcounted (scalars, interned strings or immutable a

IS_CONST operands don't have to be separated. Use reference-counting instead of duplication.

- with opcache all IS_CONST operands are not refcounted (scalars, interned strings or immutable arrays)
- without opcache IS_CONST operands are not shared between processes or threads and may use common reference counters

show more ...

micro-optimisation

Check if generator object is created by GENERATOR_CREATE when throw exceptions from generator function

Revert "Check if generator object is created by GENERATOR_CREATE when throw exceptions from generator function."

This reverts commit a9b517c6143a8fab3f704448022e7381b02090ba.

Check if generator object is created by GENERATOR_CREATE when throw exceptions from generator function.

Fixed bug #72188 (Nested try/finally blocks losing return value)

Eliminated checks for (func->op_array.fn_flags & ZEND_ACC_GENERATOR) in fast path of DO_FCALL* handlers.
This slightly improves calls to regular function and method calls in cost of a bit slower

Eliminated checks for (func->op_array.fn_flags & ZEND_ACC_GENERATOR) in fast path of DO_FCALL* handlers.
This slightly improves calls to regular function and method calls in cost of a bit slower generator initialization.
Separate call frame for generators, allocated on heap, now created by ZEND_GENERATOR_CREATE instruction.

show more ...

Intern some known (and offten used) strings.

Reimplemented Bob's commit bac6fdb0c52c924e726c5a78de8858bf27b6586b without insignificant renaming and white-space changes

Revert "Refactor zval cleanup into single function"

This reverts commit bac6fdb0c52c924e726c5a78de8858bf27b6586b.

Refactor zval cleanup into single function

Also use zval_ptr_dtor_nogc() everywhere in Zend in favor of zval_dtor()

Micro-optimization

change fcall and statement handlers to accept frame

Fix leaks in QM_ASSIGN, JMP_SET and COALESCE

The QM_ASSIGN code was rewritten to use the standard pattern for
handling CVs and VARs.

Fix use after free on AST expressions in constant declarations

Fixed compilation warnings