Optimized zend_leave_helper()

Cache op_array->run_time_cache in zend_execute_data for faster access

Moved zend_literal->cache_slot right into zval.
It should be accessed using Z_CACHE_SLOT() macro.
zend_literal structure is removed.
API functions that accepted pointer to zend_literal no

Moved zend_literal->cache_slot right into zval.
It should be accessed using Z_CACHE_SLOT() macro.
zend_literal structure is removed.
API functions that accepted pointer to zend_literal now accept pointer to zval or cache_slot directly.
Calls of such functiond that now accept cache_slot need to be changed to pass -1 instead of NULL.

show more ...

Cleanup (1-st round)

Fix bug #66015 by reverting "Removed operations on constant arrays."

Fix ZTS build

This only makes it compile, it doesn't actually work, presumably
because interned strings are assumed in some places.

Refactored data structures to keep zend_object* instead of a whole zval in some places

Use CV variable offset instead of CV variable number

Fixed static data cleanup

Refactored EG(active_symbol_table) to be zend_array* instead of HashTable*

Don't include trailing zero into hash caclculation

Disallow use of positional args after unpacking

This commit disallows the use of trailing positional arguments
after argument unpacking was used. The following calls are no
longer va

Disallow use of positional args after unpacking

This commit disallows the use of trailing positional arguments
after argument unpacking was used. The following calls are no
longer valid:

fn(...$array, $var);
fn(...$array1, $var, ...$array2);

However, all of the following continue to be valid:

fn($var, ...$array);
fn(...$array1, ...$array2);
fn($var, ...$array1, ...$array2);

The reason behind this change is a stack allocation issue pointed
out by Dmitry: As of PHP 5.5 the stack necessary for pushing
arguments is precomputed and preallocated, as such the individual
SEND opcodes no longer verify that there is enough stack space.
The unpacked arguments will occupy some of that preallocated
space and as such following positional arguments could write past
a stack page boundary.

An alternative resolution for this issue is to ensure that there
is enough space for the remaining arguments in the UNPACK opcode.
However making this allocation precise (rather than using a
conversative over-estimate) would require some effort. Given that
this particular aspect of the feature wasn't very popular in the
first place, it doesn't seem worth the effort.

show more ...

Store arg_num in fcall entry

Instead of storing the argument number in the znode of the parameter
list, store it in fcall->arg_num. This mainly cleans up the parameter
parsing code,

Store arg_num in fcall entry

Instead of storing the argument number in the znode of the parameter
list, store it in fcall->arg_num. This mainly cleans up the parameter
parsing code, which previously had to duplicate all rules (this
becomes more excessive as more features are added, e.g. named params
would already require a minimum of 14 rules...)

show more ...

Introduce zend_function_call_entry structure

Instead of directly pushing the zend_function* onto the
function_call_stack, push this structure. This allows us to store
additional data

Introduce zend_function_call_entry structure

Instead of directly pushing the zend_function* onto the
function_call_stack, push this structure. This allows us to store
additional data on this stack.

show more ...

Revert "Use zend_string for arg_info to fixed segfault in Zend/tests/argument_restriction_003.phpt"

This reverts commit b96318105b8a908ec3cb294b8133e36d1b8cba7a.

Use zend_string for arg_info to fixed segfault in Zend/tests/argument_restriction_003.phpt

Use better data structures (incomplete)

Add __debugInfo() magic method

class Foo {
private $val = 'Random, meaningless data';

public function count() { return 42; }

public function __debugInfo() {

Add __debugInfo() magic method

class Foo {
private $val = 'Random, meaningless data';

public function count() { return 42; }

public function __debugInfo() {
return ['count' => $this->count()];
}
}

$f = new Foo;
var_dump($f);

show more ...

Use better data structures (incomplete)

Use better data structures (incomplete)

Use better data structures (incomplete) - refactored return_value handling

Use better data structures (incomplete)

Use better data structures (incomplete)

Implement argument unpacking

RFC: https://wiki.php.net/rfc/argument_unpacking

Bump year