Replace deprecated Text_Diff PEAR package with Horde Text_Diff

This patch replaces obsolete Text_Diff PEAR package with newer and still
maintained Horde Text_Diff version 2.2.0 as sugges

Replace deprecated Text_Diff PEAR package with Horde Text_Diff

This patch replaces obsolete Text_Diff PEAR package with newer and still
maintained Horde Text_Diff version 2.2.0 as suggested in the packages
descriptions.

Since bugs.php.net production is not ready for Composer installations yet,
the Text_Diff package is bundled in the Git repository directly. Its
classes are not compliant with PSR-4 yet so the classmap has been used
until future PSR-4 migration and refactorings.

show more ...

Refactor fetching versions

- Procedural code moved to OOP
- Added unit tests
- Added a more flexible tmp folder location and introduce var folder
(in production this won't work

Refactor fetching versions

- Procedural code moved to OOP
- Added unit tests
- Added a more flexible tmp folder location and introduce var folder
(in production this won't work yet, so we still use /tmp there).
For local development environments var directory in project root
is used for faster and easier project setup.
- Added initial extensible PSR-16-alike semi-compatible cache class
and refactored storing fetched versions.
- The versions list generator is now simpler and a bit more logical
what is happening. Versions sort order is the same as before.
- Added ComposerScripts utility/service class for creating required
directories (uploads and var/cache), and configuration file, when
installing application in development environment.

show more ...

Fix #77403: Issue tracker: Undefined status "Suspended"

Add template engine

This patch adds an initial simplistic template engine to separate logic
from the presentation.

Basic initial features:
- escaping via Context::noHtml() a

Add template engine

This patch adds an initial simplistic template engine to separate logic
from the presentation.

Basic initial features:
- escaping via Context::noHtml() and Context::e() methods
- blocks
- nesting options using includes and extending layouts
- PHP syntax
- variable scopes dedicated to template scope only
- Appending blocks (when JS files are in need to be appended)
- initial unit and functional tests
- Main index page refactored as an example of usage
- Very short intro docs how to use the template layer
- Thanks to @nhlm for the code review and numerous suggestions to
improve the usability and code stability,
- Thanks to @KalleZ and for the code review and numerous common sense
suggestions about templates themselves.
- Thanks to @Maikuolan for the code review and numerous suggestions
about the usability.
- Moved hash ids redirection to aseparate JavaScript file
- Use location instead of window.location in the JavaScript redirection

Discussions:
- http://news.php.net/php.webmaster/27603
- https://github.com/php/web-bugs/pull/66

show more ...

Bump Composer dependencies

- PHPUnit 7.4 upgraded to 7.5
- composer update

Fix #77355: Filing a ticket links to the Edit tab of potential duplicates

We should link to the ticket generally, instead of the Edit tab.

Refactor repository classes to use vanilla PDOStatement

Current goal is to use as close to PDO expected functionality without
overriding and making custom methods due to easier understan

Refactor repository classes to use vanilla PDOStatement

Current goal is to use as close to PDO expected functionality without
overriding and making custom methods due to easier understanding of
the app itself for people working on the code and contributors.

This patch refactors repository classes to use the expected
\PDOStatement without method chaining.

show more ...

Fix strict types issues

This makes sure arrays are always returned when calling
PDOStatement::fetch() in current repository classes.

Minor cleanup

Fix #76720: Contributor aids/readme improvements

This fixes mentioned issues together with previous patches done on this
file.

Remove display_bug_success() function

The display_bug_success() is a simple wrapper around the echo and has
HTML embedded in it.

Add Vote repository class

Move docs comments to repository

Move bugdb queries to repository

Move lists query to repository class

Remove unneeded check for database handle presence

This check(s) were once used in previous code for local testings.

Fix SQL string typo

Refactor bugs_get_bug() to repository

Refactor get_resolve_reasons() to repository class

Move fetching bug comments to a repository class

Changes:
- This moves fetching bug comments to a dedicated repository class
- It uses vanilla PDO as current direction of the databas

Move fetching bug comments to a repository class

Changes:
- This moves fetching bug comments to a dedicated repository class
- It uses vanilla PDO as current direction of the database usage
is applied in this app.
- When bug_id is set to preview types issues occur due to int type
hint. Should be refactored more in the future commits.

show more ...

Remove unused styles and web assets

Some of these styles and web assets were used in the past when bug
trackings for PECL and PHP were separated. Today PECL bugs are located
in the b

Remove unused styles and web assets

Some of these styles and web assets were used in the past when bug
trackings for PECL and PHP were separated. Today PECL bugs are located
in the bugs.php.net also. This patch removes outdated styles and images.

show more ...

Refactor PDO wrapper

Some considerations were raised on the mailing list that this PHP
application doesn't need a PDO wrapper at all.

Changes:
- ::fetchRow() method removed

Refactor PDO wrapper

Some considerations were raised on the mailing list that this PHP
application doesn't need a PDO wrapper at all.

Changes:
- ::fetchRow() method removed in favor of the vanilla PDOStatement::fetch()
- ::fetchAll() override removed in favor of the vanilla
PDOStatement::fetchAll()
- ::fetchCol() removed since it is not used and is only a wrapper for
the PDOStatement::fetchColumn()
- PDO fetch_style synced accross the app. When no fetch style is passed
the default PDO::FETCH_ASSOC is used as set when connecting to db.
- Remove Database::escape() method
The custom ::escape() method is a wrapper around PDO::quote() which
additionally trims leading and trailing quotes from the string. All
this should ideally be done via prepared statements only, except where
we can and need to use PDO::quote() this step can be done on the given
string or variable at hand directly.
- Remove escapeSQL() function
The escapeSQL function is a wrapper around the PDO::quote() and is
using $dbh from the global scope which is not testable nor good practice
further on. Removed and refactored into only PDO::quote() usages on
required places.
- Remove ::fetchOne() method
The fetchOne() method is a simple wrapper around the PDOStatement::fetch()
method with very minor tweaks so the usage can be simplified even more.
The PDOStatement::fetch(\PDO::FETCH_NUM)[0] will always return either a
result from the database column or when row is empty a null.
- Probably this should be refactored to the database tables respected
repositories further on.
- Remove PDO wrapper
The app's current goal is to lean on a vanilla PDO wrapper only.
Current set of features also don't require additional functionality
and extending PDO to a wrapper or create a database abstraction layer
yet.

show more ...

Added include/classes to the directory structure

PHP 7.0 is EOL

WS