Minor cleanup

Fix #76720: Contributor aids/readme improvements

This fixes mentioned issues together with previous patches done on this
file.

Remove display_bug_success() function

The display_bug_success() is a simple wrapper around the echo and has
HTML embedded in it.

Add Vote repository class

Move docs comments to repository

Move bugdb queries to repository

Move lists query to repository class

Remove unneeded check for database handle presence

This check(s) were once used in previous code for local testings.

Fix SQL string typo

Refactor bugs_get_bug() to repository

Refactor get_resolve_reasons() to repository class

Move fetching bug comments to a repository class

Changes:
- This moves fetching bug comments to a dedicated repository class
- It uses vanilla PDO as current direction of the databas

Move fetching bug comments to a repository class

Changes:
- This moves fetching bug comments to a dedicated repository class
- It uses vanilla PDO as current direction of the database usage
is applied in this app.
- When bug_id is set to preview types issues occur due to int type
hint. Should be refactored more in the future commits.

show more ...

Remove unused styles and web assets

Some of these styles and web assets were used in the past when bug
trackings for PECL and PHP were separated. Today PECL bugs are located
in the b

Remove unused styles and web assets

Some of these styles and web assets were used in the past when bug
trackings for PECL and PHP were separated. Today PECL bugs are located
in the bugs.php.net also. This patch removes outdated styles and images.

show more ...

Refactor PDO wrapper

Some considerations were raised on the mailing list that this PHP
application doesn't need a PDO wrapper at all.

Changes:
- ::fetchRow() method removed

Refactor PDO wrapper

Some considerations were raised on the mailing list that this PHP
application doesn't need a PDO wrapper at all.

Changes:
- ::fetchRow() method removed in favor of the vanilla PDOStatement::fetch()
- ::fetchAll() override removed in favor of the vanilla
PDOStatement::fetchAll()
- ::fetchCol() removed since it is not used and is only a wrapper for
the PDOStatement::fetchColumn()
- PDO fetch_style synced accross the app. When no fetch style is passed
the default PDO::FETCH_ASSOC is used as set when connecting to db.
- Remove Database::escape() method
The custom ::escape() method is a wrapper around PDO::quote() which
additionally trims leading and trailing quotes from the string. All
this should ideally be done via prepared statements only, except where
we can and need to use PDO::quote() this step can be done on the given
string or variable at hand directly.
- Remove escapeSQL() function
The escapeSQL function is a wrapper around the PDO::quote() and is
using $dbh from the global scope which is not testable nor good practice
further on. Removed and refactored into only PDO::quote() usages on
required places.
- Remove ::fetchOne() method
The fetchOne() method is a simple wrapper around the PDOStatement::fetch()
method with very minor tweaks so the usage can be simplified even more.
The PDOStatement::fetch(\PDO::FETCH_NUM)[0] will always return either a
result from the database column or when row is empty a null.
- Probably this should be refactored to the database tables respected
repositories further on.
- Remove PDO wrapper
The app's current goal is to lean on a vanilla PDO wrapper only.
Current set of features also don't require additional functionality
and extending PDO to a wrapper or create a database abstraction layer
yet.

show more ...

Added include/classes to the directory structure

PHP 7.0 is EOL

WS

Use closures over create_function()

Trim trailing whitespaces

Refactor get_pseudo_packages() to repository class

Changes:
- get_pseudo_packages() function is moved to its own repository class.
- Database::queryAll() removed since it is not used

Refactor get_pseudo_packages() to repository class

Changes:
- get_pseudo_packages() function is moved to its own repository class.
- Database::queryAll() removed since it is not used and the method
arguments don't match the number of used arguments anymore
- Project types configuration is moved to repository class for now.
- Some unused items removed
- Some template changes and show_project_options() helper function
integrated in the view layer directly since it is used in a simplified
way.

show more ...

Add contributing procedure

Add directory structure to README

Add .editorconfig file

This patch adds initial EditorConfig [1] file with sensible defaults
specific for future PHP code, HTML templates, and possible other file
types. It helps form

Add .editorconfig file

This patch adds initial EditorConfig [1] file with sensible defaults
specific for future PHP code, HTML templates, and possible other file
types. It helps formating code and new files in editors and IDEs that
utilize EditorConfig settings. Current state of EditorConfig provides
setting identation style and level, new lines types, files encodings,
and similar basic files and code configurations.

[1] https://editorconfig.org

show more ...

Add type declarations to Captcha class

Simplify GitHub pull request form

The form for attaching pull requests doesn't need to upload files.