stop spammy users

Remove unused functions

- admin_table_static
- admin_table_dynamic
- inline_content_menu

Move backtrace pages to templates

Convert all tabs to spaces

add new word to spam list

Remove display_bug_success() function

The display_bug_success() is a simple wrapper around the echo and has
HTML embedded in it.

Refactor bugs_get_bug() to repository

Refactor get_resolve_reasons() to repository class

Move fetching bug comments to a repository class

Changes:
- This moves fetching bug comments to a dedicated repository class
- It uses vanilla PDO as current direction of the databas

Move fetching bug comments to a repository class

Changes:
- This moves fetching bug comments to a dedicated repository class
- It uses vanilla PDO as current direction of the database usage
is applied in this app.
- When bug_id is set to preview types issues occur due to int type
hint. Should be refactored more in the future commits.

show more ...

Refactor PDO wrapper

Some considerations were raised on the mailing list that this PHP
application doesn't need a PDO wrapper at all.

Changes:
- ::fetchRow() method removed

Refactor PDO wrapper

Some considerations were raised on the mailing list that this PHP
application doesn't need a PDO wrapper at all.

Changes:
- ::fetchRow() method removed in favor of the vanilla PDOStatement::fetch()
- ::fetchAll() override removed in favor of the vanilla
PDOStatement::fetchAll()
- ::fetchCol() removed since it is not used and is only a wrapper for
the PDOStatement::fetchColumn()
- PDO fetch_style synced accross the app. When no fetch style is passed
the default PDO::FETCH_ASSOC is used as set when connecting to db.
- Remove Database::escape() method
The custom ::escape() method is a wrapper around PDO::quote() which
additionally trims leading and trailing quotes from the string. All
this should ideally be done via prepared statements only, except where
we can and need to use PDO::quote() this step can be done on the given
string or variable at hand directly.
- Remove escapeSQL() function
The escapeSQL function is a wrapper around the PDO::quote() and is
using $dbh from the global scope which is not testable nor good practice
further on. Removed and refactored into only PDO::quote() usages on
required places.
- Remove ::fetchOne() method
The fetchOne() method is a simple wrapper around the PDOStatement::fetch()
method with very minor tweaks so the usage can be simplified even more.
The PDOStatement::fetch(\PDO::FETCH_NUM)[0] will always return either a
result from the database column or when row is empty a null.
- Probably this should be refactored to the database tables respected
repositories further on.
- Remove PDO wrapper
The app's current goal is to lean on a vanilla PDO wrapper only.
Current set of features also don't require additional functionality
and extending PDO to a wrapper or create a database abstraction layer
yet.

show more ...

WS

Refactor get_pseudo_packages() to repository class

Changes:
- get_pseudo_packages() function is moved to its own repository class.
- Database::queryAll() removed since it is not used

Refactor get_pseudo_packages() to repository class

Changes:
- get_pseudo_packages() function is moved to its own repository class.
- Database::queryAll() removed since it is not used and the method
arguments don't match the number of used arguments anymore
- Project types configuration is moved to repository class for now.
- Some unused items removed
- Some template changes and show_project_options() helper function
integrated in the view layer directly since it is used in a simplified
way.

show more ...

Refactor patches uploading

This patch moves patches uploading functionality from the outdated
HTTP_Upload package to a dedicated service class in the app.

Additional changes in

Refactor patches uploading

This patch moves patches uploading functionality from the outdated
HTTP_Upload package to a dedicated service class in the app.

Additional changes in this context:
- Functionality concerning retrieving patches data from database has
been moved to a separate repository classes.
- Some missed bugs fixed when uploading patches and no developer info
were recorded.
- Obsoleting patches functionality is now working again.
- Added a simple unit test.

show more ...

Replace PEAR error handling with exceptions in pull requests

Remove unused errors handler function handle_pear_errors()

Function handle_pear_errors() has been made obsolete via
23298a123688443276f60143c1261f85a85873fe

Refactor each() function to foreach()

The each() function has been deprecated since PHP 7.2 and shouldn't be
used anymore:
- http://php.net/manual/en/function.each.php

Refactor long array() syntax to short []

Since site is using PHP 5.4+ already, the longer `array()` syntax can be
refactored to shorter `[]`. Also code is already using short array
s

Refactor long array() syntax to short []

Since site is using PHP 5.4+ already, the longer `array()` syntax can be
refactored to shorter `[]`. Also code is already using short array
syntax on some places.

show more ...

Update http to https

Changes:
- http links updated to https (those that work so far)
- us3.php.net mirror changed to php.net for fetching PHP versions
- some outdated links refre

Update http to https

Changes:
- http links updated to https (those that work so far)
- us3.php.net mirror changed to php.net for fetching PHP versions
- some outdated links refreshed

show more ...

Replace PEAR MDB2 constants with PDO constants

The changed constants are more understandable using PDO constants
nor are the dedicated definition needed anymore.

Attemt to fix pre-selected value

Turn categories into <optgroup>s and include the category as a package
within that category.

We still show disabled packages in a different background color
(b93c85b003).

$pseudo_pkgs now has an array of children as a third element.

If parent = '0' in the database, $pseudo_pkgs[2] is an array. If it is
nonzero (refers to a valid id of another row), $pseud

$pseudo_pkgs now has an array of children as a third element.

If parent = '0' in the database, $pseudo_pkgs[2] is an array. If it is
nonzero (refers to a valid id of another row), $pseudo_pkgs[2] is a
child and is null. We no longer need &nbsp;&nbsp;&nbsp;&nbsp; to
distinguish between parents and children. Nowhere do we count the length
of $pseudo_pkgs, so the extra element should not break anything.

show more ...

remove unused parameter and local variable

Get rid of preg /e

get all subscribers