Merge branch 'PHP-7.4'

* PHP-7.4:
Pass worker ID to clean scripts

Pass worker ID to clean scripts

On Windows, reusing/sharing of OPcache instances with different
configuration is not necessarily supported, so we have to make that it
does not happen

Pass worker ID to clean scripts

On Windows, reusing/sharing of OPcache instances with different
configuration is not necessarily supported, so we have to make that it
does not happen for the clean scripts, by using `$orig_ini_settings`
instead of `$clean_params`.

show more ...

Show eventual output of clean sections

This is a hack to investigate why mysqli_insert_packet_overflow.phpt
intermittently fails on AppVeyor, and will be reverted in due time.
See <h

Show eventual output of clean sections

This is a hack to investigate why mysqli_insert_packet_overflow.phpt
intermittently fails on AppVeyor, and will be reverted in due time.
See <https://github.com/php/php-src/pull/5447#issuecomment-620508790>.

show more ...

Fixed run-tests.php for PHP 7.2

Flexible heredoc syntax is only available since PHP 7.3.

Closes GH-5444.

Enhance test failure SH script to allow gdb, valgrind, rr as alternative modes.

Force short_open_tag=0 in run-tests.php

Make sure we don't accidentially add tests depending on short tags.

Use serialize_precision for var_dump()

var_dump() is debugging functionality, so it should print
floating-point numbers accurately. We do this by switching
to serialize_precision, wh

Use serialize_precision for var_dump()

var_dump() is debugging functionality, so it should print
floating-point numbers accurately. We do this by switching
to serialize_precision, which (by default) will print with
as much precision as necessary to preserve the exact value
of the float.

This also affects debug_zval_dump().

Closes GH-5172.

show more ...

Merge branch 'PHP-7.4'

* PHP-7.4:
Create a new console for each test worker on Windows

Create a new console for each test worker on Windows

The primary motivation to have each test worker running its own console
is to allow the windows_mb_path tests to run in parallel. A

Create a new console for each test worker on Windows

The primary motivation to have each test worker running its own console
is to allow the windows_mb_path tests to run in parallel. A nice side
effect is that this also prevents changing the code page of the
tester's console window (which can even cause its font to be changed).

To be able to do so, we introduce the `create_new_console` option for
`proc_open()`, which might occasionally be useful for other purposes
than testing.

show more ...

Merge branch 'PHP-7.4'

* PHP-7.4:
Apply tidy formatting

Apply tidy formatting

Mostly reindent PHP scripts to spaces.

Merge branch 'PHP-7.4'

* PHP-7.4:
Add WHITESPACE_SENSITIVE run-tests section

Add WHITESPACE_SENSITIVE run-tests section

This is used to indicate that the test should not be changed by
automated formatting changes.

Merge branch 'PHP-7.4'

* PHP-7.4:
Don't use CRLF when generating diffs

Don't use CRLF when generating diffs

Use smaller batch size in run-tests.php when appropriate

- When valgrind is used, communication overhead is relatively small,
so just use a batch size of 1.
- If this is running a

Use smaller batch size in run-tests.php when appropriate

- When valgrind is used, communication overhead is relatively small,
so just use a batch size of 1.
- If this is running a small enough number of tests,
reduce the batch size to give batches to more workers.
(Previously, if there were 90 tests and -j8,
only 3 of 8 workers would get a batch of size 32 or less.
After this change, the batch size is 12 or less)

Closes GH-5098

show more ...

Don't start unnecessary processes with run-tests.php -j

If there's only 2 files to test, then only start 2 workers instead of N.

If there's only 1 file, then avoid parallelism entir

Don't start unnecessary processes with run-tests.php -j

If there's only 2 files to test, then only start 2 workers instead of N.

If there's only 1 file, then avoid parallelism entirely.
A separate option such as `--force-parallel` could be added
if this turns out to be something developers would want to do
when debugging test failures.

show more ...

Merge branch 'PHP-7.4'

* PHP-7.4:
Avoid some @count() suppressions in run-tests.php

Avoid some @count() suppressions in run-tests.php

Use IS_WINDOWS

Replace fakemail with minimal PHP script

Unify mail related tests for *nix and Windows

Currently mail related tests are split for *nix and Windows (if there
are even Windows versions). The basic difference is that the *nix

Unify mail related tests for *nix and Windows

Currently mail related tests are split for *nix and Windows (if there
are even Windows versions). The basic difference is that the *nix
variants set the INI directive sendmail_path to just write the email to
disk, while the Windows tests use ext/imap. The latter tests are way
more verbose, and such duplicated tests are generally a pain point.
Furthermore, the Windows tests are much slower, and could not be run
without ext/imap being available.

We therefore introduce a small fakemail application, which basically
works like `tee <path> >/dev/null`, and which will be shipped with the
Windows tests packs. fakemail.exe would also need to be added to the
PHP binary SDK, so these tests could be run during developments.

To cater to the remaining differences, we also introduce support for
`{MAIL:<path>}` placeholders in the INI sections to run-tests.php. How
to use this can be seen in mail_basic.phpt, which is currently the only
modified test case, because these tests are yet supposed to fail on
Windows, due to the missing fakemail.exe in the PHP SDK.

show more ...

Merge branch 'PHP-7.4'

* PHP-7.4:
Set zend.exception_ignore_args=0 in run-tests.php

Set zend.exception_ignore_args=0 in run-tests.php

Any existing tests are going to be written under this assumption...

Merge branch 'PHP-7.4'