Optimize parallel test runner startup

Don't connect to each worker individually: First spawn all processes
and then establish connections in any order.

This avoids a ~1s wait wh

Optimize parallel test runner startup

Don't connect to each worker individually: First spawn all processes
and then establish connections in any order.

This avoids a ~1s wait when running on many cores.

show more ...

run-tests: refactor

run-tests: echo message and exit if no tests found

The test runner currently defaults to running the entire test suite if
no selected tests can be found. This can be unexpected.

run-tests: echo message and exit if no tests found

The test runner currently defaults to running the entire test suite if
no selected tests can be found. This can be unexpected.

For example the ext/mysqlnd/ directory has no tests, if you specify that
directory when testing the entire test suite will be run.

run-tests.php [options] ext/mysqlnd/

Closes GH-5605.

show more ...

Add --file-cache-prime/use options to run-tests

--file-cache-prime populates the file cache,
--file-cache-use uses the file cache.

And fix a number of tests to run under file ca

Add --file-cache-prime/use options to run-tests

--file-cache-prime populates the file cache,
--file-cache-use uses the file cache.

And fix a number of tests to run under file cache or disabled
timestamp validation.

show more ...

Slightly deduplicate run-tests code

Merge branch 'PHP-7.4'

Put Xdebug 3 into 'off' mode for run-tests.php

Put Xdebug 3 into 'off' mode for run-tests.php

run-tests: extract usage message

Put the usage message near the top of the script,
into a separate function.

Closes GH-5558.

run-tests: cs fixes (cleanup)

I used php-cs-fixer to do the cs fixes. The configuration I used is
posted below. The reason I disabled some of the rules is because they
create too muc

run-tests: cs fixes (cleanup)

I used php-cs-fixer to do the cs fixes. The configuration I used is
posted below. The reason I disabled some of the rules is because they
create too much noise and would make it difficult to review. But please
feel free to close this PR and run the php-cs-fixer yourself.

<?php

$config = PhpCsFixer\Config::create();
$config->setRiskyAllowed(false);
$config->setRules([
'@PSR2' => true,
'@Symfony' => true,
'array_syntax' => false,
'binary_operator_spaces' => false,
'blank_line_before_statement' => false,
'concat_space' => false,
'increment_style' => false,
'phpdoc_align' => false,
'single_quote' => false,
'trailing_comma_in_multiline_array' => false,
'unary_operator_spaces' => false,
'yoda_style' => false,
]);

$finder = PhpCsFixer\Finder::create();
$finder->in(getcwd());

$finder->exclude('Zend');
$finder->exclude('build');
$finder->exclude('ext');
$finder->exclude('pear');
$finder->exclude('sapi');
$finder->exclude('scripts');
$finder->exclude('win32');

$config->setFinder($finder);

return $config;

Closes GH-5557.

show more ...

run-tests: remove use of FILE_BINARY constant

The FILE_BINARY (and FILE_TEXT) constants are not really valid or useful
constants. It looks like they were added in 5.2.7 and have "no effe

run-tests: remove use of FILE_BINARY constant

The FILE_BINARY (and FILE_TEXT) constants are not really valid or useful
constants. It looks like they were added in 5.2.7 and have "no effect,
and are only available for forward compatibility."

See: https://www.php.net/manual/en/filesystem.constants.php

The default value of the file_put_contents() flags parameter is 0 and
FILE_BINARY is set to 0, so removing it doesn't change functionality.

P.S. Maybe those constants should be deprecated or removed in 8.0.

Closes GH-5556.

show more ...

Revert "Show eventual output of clean sections"

This reverts commit 5eb4ab07f27c82336d337afa01d02a7bf574adaf.
The temporary hack has served its purpose.

Merge branch 'PHP-7.4'

* PHP-7.4:
Pass worker ID to clean scripts

Pass worker ID to clean scripts

On Windows, reusing/sharing of OPcache instances with different
configuration is not necessarily supported, so we have to make that it
does not happen

Pass worker ID to clean scripts

On Windows, reusing/sharing of OPcache instances with different
configuration is not necessarily supported, so we have to make that it
does not happen for the clean scripts, by using `$orig_ini_settings`
instead of `$clean_params`.

show more ...

Show eventual output of clean sections

This is a hack to investigate why mysqli_insert_packet_overflow.phpt
intermittently fails on AppVeyor, and will be reverted in due time.
See <h

Show eventual output of clean sections

This is a hack to investigate why mysqli_insert_packet_overflow.phpt
intermittently fails on AppVeyor, and will be reverted in due time.
See <https://github.com/php/php-src/pull/5447#issuecomment-620508790>.

show more ...

Fixed run-tests.php for PHP 7.2

Flexible heredoc syntax is only available since PHP 7.3.

Closes GH-5444.

Enhance test failure SH script to allow gdb, valgrind, rr as alternative modes.

Force short_open_tag=0 in run-tests.php

Make sure we don't accidentially add tests depending on short tags.

Use serialize_precision for var_dump()

var_dump() is debugging functionality, so it should print
floating-point numbers accurately. We do this by switching
to serialize_precision, wh

Use serialize_precision for var_dump()

var_dump() is debugging functionality, so it should print
floating-point numbers accurately. We do this by switching
to serialize_precision, which (by default) will print with
as much precision as necessary to preserve the exact value
of the float.

This also affects debug_zval_dump().

Closes GH-5172.

show more ...

Merge branch 'PHP-7.4'

* PHP-7.4:
Create a new console for each test worker on Windows

Create a new console for each test worker on Windows

The primary motivation to have each test worker running its own console
is to allow the windows_mb_path tests to run in parallel. A

Create a new console for each test worker on Windows

The primary motivation to have each test worker running its own console
is to allow the windows_mb_path tests to run in parallel. A nice side
effect is that this also prevents changing the code page of the
tester's console window (which can even cause its font to be changed).

To be able to do so, we introduce the `create_new_console` option for
`proc_open()`, which might occasionally be useful for other purposes
than testing.

show more ...

Merge branch 'PHP-7.4'

* PHP-7.4:
Apply tidy formatting

Apply tidy formatting

Mostly reindent PHP scripts to spaces.

Merge branch 'PHP-7.4'

* PHP-7.4:
Add WHITESPACE_SENSITIVE run-tests section

Add WHITESPACE_SENSITIVE run-tests section

This is used to indicate that the test should not be changed by
automated formatting changes.