Remove obsolete check for missing fclose declaration (#13360)

SunOS 4.1.4 from 1994 didn't have fclose declared in standard header
stdio.h. This doesn't need to be checked anymore, as fc

Remove obsolete check for missing fclose declaration (#13360)

SunOS 4.1.4 from 1994 didn't have fclose declared in standard header
stdio.h. This doesn't need to be checked anymore, as fclose is part of
the C89+ standard and declaration is present on Solaris 10 (SunOS 5.10)
and later.

show more ...

Use a single version of mempcpy(3) (#12257)

While __php_mempcpy is only used by ext/standard/crypt_sha*, the
mempcpy "pattern" is used everywhere.

This commit removes __php_memp

Use a single version of mempcpy(3) (#12257)

While __php_mempcpy is only used by ext/standard/crypt_sha*, the
mempcpy "pattern" is used everywhere.

This commit removes __php_mempcpy, adds zend_mempcpy and transforms
open-coded parts into function calls.

show more ...

Remove always-true condition from php_copy_file_ctx()

srcstream is always checked before.

Fix GH-12151: str_getcsv ending with escape zero segfualt

Closes GH-12152

Fix GH-11982: str_getcsv returns null byte for unterminated quoted string

Closes GH-12047

Fix off-by-one bug when truncating tempnam prefix

The tempnam documentation currently states that "Only the first 63
characters of the prefix are used, the rest are ignored". However whe

Fix off-by-one bug when truncating tempnam prefix

The tempnam documentation currently states that "Only the first 63
characters of the prefix are used, the rest are ignored". However when
the prefix is 64 characters-long, the current implementation fails to
strip the last character, diverging from the documented behavior. This
patch fixes the implementation so it matches the documented behavior for
that specific case where the prefix is 64 characters long.

Closes GH-11870

Signed-off-by: George Peter Banyard <girgias@php.net>

show more ...

fix file() flags error-check

the old flag check was flawed and would miss some flags, for example:
file(__FILE__, FILE_APPEND);
is invalid, but the old flags error check would miss i

fix file() flags error-check

the old flag check was flawed and would miss some flags, for example:
file(__FILE__, FILE_APPEND);
is invalid, but the old flags error check would miss it: https://3v4l.org/b2W9u

Closes GH-11483

show more ...

Propagate STREAM_DISABLE_OPEN_BASEDIR src flag to php_stream_stat_path_ex

Otherwise we can get open_basedir warnings from the stat call while still
performing the actual copy.

F

Propagate STREAM_DISABLE_OPEN_BASEDIR src flag to php_stream_stat_path_ex

Otherwise we can get open_basedir warnings from the stat call while still
performing the actual copy.

Fixes GH-11138
Closes GH-11156

show more ...

[skip ci] Fix various typos and grammar issues (#11143)

Fix buffer-overflow in php_fgetcsv() with \0 delimiter and enclosure

Fixes oss-fuzz #57392
Closes GH-10923

Rename PHP_STREAM_TO_ZVAL to PHP_STREAM_FROM_ZVAL (#10065)

Declare ext/standard constants in stubs - part 2 (#9426)

Make php_fgetcsv() return a HashTale instead of in-out zval param (#8936)

Also refactor what happens on an empty line to return NULL instead of setting the array to [NULL] which makes no des

Make php_fgetcsv() return a HashTale instead of in-out zval param (#8936)

Also refactor what happens on an empty line to return NULL instead of setting the array to [NULL] which makes no design sense at all.
However, as this is the current behaviour create a BC Shim inline function to recreate this weird HashTable in the functions which currently use this API

show more ...

Disable the read buffer in file_get_contents()

The read buffer is useless here, it only hurts performance.

Closes GH-8547.

Fix [-Wundef] warnings in standard extension

Fix bug #66588: SplFileObject::fgetcsv incorrectly returns a row on premature EOF

Make sure the behavior is the same regardless of whether there is
a trailing newline and whether the inp

Fix bug #66588: SplFileObject::fgetcsv incorrectly returns a row on premature EOF

Make sure the behavior is the same regardless of whether there is
a trailing newline and whether the input is a stream or not.

Closes GH-7539.

show more ...

Use ASCII lower case for misc case folding

Use ASCII case conversion instead of locale-dependent case conversion in
the following places:

* grapheme_stripos() and grapheme_strri

Use ASCII lower case for misc case folding

Use ASCII case conversion instead of locale-dependent case conversion in
the following places:

* grapheme_stripos() and grapheme_strripos() in the "fast" path
* ldap_get_entries()
* oci_pconnect() for case folding of parameters when constructing a key
into the connection or session pool
* SoapClient: case folding of function names
* get_meta_tags(): case conversion of property names
* http stream wrapper: header names
* phpinfo(): anchor names
* php_verror(): docref URLs
* rfc1867.c: Content-Type boundary parameter name
* streams.c: stream protocol names

Using locale-dependent case folding for these cases is either
unnecessary or actively incorrect. These functions could have
misbehaved when used with certain locales (e.g. Turkish).

Closes GH-7511.

show more ...

Use zend_long for resource ID

Currently, resource IDs are limited to 32-bits. As resource IDs
are not reused, this means that resource ID overflow for
long-running processes is very

Use zend_long for resource ID

Currently, resource IDs are limited to 32-bits. As resource IDs
are not reused, this means that resource ID overflow for
long-running processes is very possible.

This patch switches resource IDs to use zend_long instead, which
means that on 64-bit systems, 64-bit resource IDs will be used.
This makes resource ID overflow practically impossible.

The tradeoff is an 8 byte increase in zend_resource size.

Closes GH-7436.

show more ...

Fix typo in file.c

apostrohpe -> apostrophe

Returned interned string from fgetc()

Make use of single-character interned strings.

Deprecate auto_detect_line_endings

Part of https://wiki.php.net/rfc/deprecations_php_8_1.

Deprecate FILE_BINARY and FILE_TEXT constants

These constants have no effect.

Part of https://wiki.php.net/rfc/deprecations_php_8_1.

Minor fgetcsv cleanup

Reduce some variable scopes.

Fixed some spaces used instead of tabs

Remove 'register' type qualifier (#6980)

The compiler should be smart enough to optimize this on its own