Merge branch 'PHP-7.4'

* PHP-7.4:
Use uint64_t for time_sleep_until calculations

Use uint64_t for time_sleep_until calculations

Make sure array_splice() always returns an array

Return an array even if the return value isn't used. This allows us
to add the arginfo return type.

Merge branch 'PHP-7.4'

Allow exceptions in __toString()

RFC: https://wiki.php.net/rfc/tostring_exceptions

And convert some object to string conversion related recoverable
fatal errors into Error excep

Allow exceptions in __toString()

RFC: https://wiki.php.net/rfc/tostring_exceptions

And convert some object to string conversion related recoverable
fatal errors into Error exceptions.

Improve exception safety of internal code performing string
conversions.

show more ...

Add return type to some array_* functions

Add return type for string functions

Add double return type for math functions

Add boolean return type for is_* functions

Update MAY_BE_NULL for parts of ext/standard

Also update proto comments to be more accurate.

Merge branch 'PHP-7.4'

Allow array_merge() / array_merge_recursive() without arguments

This allows writing

array_merge(...$arrays)

instead of

array_merge([], ...$arrays)

Allow array_merge() / array_merge_recursive() without arguments

This allows writing

array_merge(...$arrays)

instead of

array_merge([], ...$arrays)

and is in line with similar changes to array_push() and array_unshift()
in PHP 7.3.

Closes GH-4175.

show more ...

Add return type information to some ext/standard functions

Just the first few functions in basic_functions.c to get started.

If anyone is interested in continuing this, PRs to add t

Add return type information to some ext/standard functions

Just the first few functions in basic_functions.c to get started.

If anyone is interested in continuing this, PRs to add type info
will be accepted against master, with the following caveats:

* Return types only, we are not ready to add argument types yet.
* Only for functions. For methods the addition of return types is
BC breaking and needs to be carefully considered.
* Only in cases where we can actually express the return type, we
don't have int|false and similar.

show more ...

Use ZEND_TRY_ASSIGN_REF_... macros for arguments passed to internal function by reference

Use ZEND_TRY_ASSIGN_REF_... macros for arguments passed to internal function by reference

Use ZEND_TRA_ASSIGN_REF_... macros for by reference arguments of internal functions.

Add test for get_cfg_var with array variable

And fix incorrect variable shadowing in add_config_entry(). However,
the test doesn't hit this case, as it requires a nested array. I'm
n

Add test for get_cfg_var with array variable

And fix incorrect variable shadowing in add_config_entry(). However,
the test doesn't hit this case, as it requires a nested array. I'm
not sure if it's possible to produce nested arrays from ini?

show more ...

Add test for get_cfg_var with array variable

And fix incorrect variable shadowing in add_config_entry(). However,
the test doesn't hit this case, as it requires a nested array. I'm
n

Add test for get_cfg_var with array variable

And fix incorrect variable shadowing in add_config_entry(). However,
the test doesn't hit this case, as it requires a nested array. I'm
not sure if it's possible to produce nested arrays from ini?

show more ...

Merge branch 'PHP-7.4'

* PHP-7.4:
Remove checks for locale.h, setlocale, localeconv

Remove checks for locale.h, setlocale, localeconv

The `<loccale.h>` header file, setlocale, and localeconv are part of the
standard C89 [1] and on current systems can be used uncondition

Remove checks for locale.h, setlocale, localeconv

The `<loccale.h>` header file, setlocale, and localeconv are part of the
standard C89 [1] and on current systems can be used unconditionally.

Since PHP 7.4 requires at least C89 or greater, the `HAVE_LOCALE_H`,
`HAVE_SETLOCALE`, and `HAVE_LOCALECONV` symbols defined by Autoconf in
configure.ac [2] can be ommitted and simplifed.

The bundled libmagic (file) has also been patched already in version
5.35 and up in upstream location so when it will be patched also in
php-src the check for locale.h header is still left in the configure.ac
and in windows headers definition file.

[1] https://port70.net/~nsz/c/c89/c89-draft.html#4.4
[2] https://git.savannah.gnu.org/cgit/autoconf.git/tree/lib/autoconf/headers.m4

Omit the bundled libmagic files

show more ...

Merge branch 'PHP-7.4'

* PHP-7.4:
tsrm environment lock

tsrm environment lock

Merge branch 'PHP-7.4'

Remove function_table var from the caller

function_table var is not used in call_user_function macro anymore
hence replace the usage with NULL

Merge branch 'PHP-7.4'

* PHP-7.4:
Remove unused PHP_AC_BROKEN_SPRINTF and AC_ZEND_BROKEN_SPRINTF