Give a meaningful name

Micro-optmization

Merge branch 'PHP-7.2'

* PHP-7.2:
Update NEWs
Fixed bug #68553 (array_column: null values in $index_key become incrementing keys in result)

Conflicts:
ext/st

Merge branch 'PHP-7.2'

* PHP-7.2:
Update NEWs
Fixed bug #68553 (array_column: null values in $index_key become incrementing keys in result)

Conflicts:
ext/standard/array.c

show more ...

Merge branch 'PHP-7.1' into PHP-7.2

* PHP-7.1:
Fixed bug #68553 (array_column: null values in $index_key become incrementing keys in result)

Fixed bug #68553 (array_column: null values in $index_key become incrementing keys in result)

Avoid code duplication

Improve implementation of array_key_first() and array_key_last()

Firstly, we must not separate the $stack argument for performance
reasons. Secondly, we prefer `Z_ARRVAL_P` over `HASH_O

Improve implementation of array_key_first() and array_key_last()

Firstly, we must not separate the $stack argument for performance
reasons. Secondly, we prefer `Z_ARRVAL_P` over `HASH_OF` to clarify
our intention.

Thanks to Nikita, for catching these issues!

show more ...

Add implementation and tests for new methods - array_key_first(array $a) Returns the key of the first element or null - array_key_last(array $a) Returns the key of the last element or null

Uze ZVAL_COPY_DEREF() instead of ZVAL_DEREF() and ZVAL_COPY()

se zval_ptr_dtor_str() instead of zend_string_release_ex(Z_STR(*), 0)

Do not continue extract()ing after an exception has been thrown

Make behavior consistent with a loop of normal assignments.

This is not a big issue now, because $this is the only ca

Do not continue extract()ing after an exception has been thrown

Make behavior consistent with a loop of normal assignments.

This is not a big issue now, because $this is the only case that
may generate an error. However typed references introduce additional
error conditions, which would be silenced by this kind of behavior.

show more ...

Merge branch 'PHP-7.2'

* PHP-7.2:
Update NEWS
Fixed bug #76505 (array_merge_recursive() is duplicating sub-array keys)

Merge branch 'PHP-7.1' into PHP-7.2

* PHP-7.1:
Fixed bug #76505 (array_merge_recursive() is duplicating sub-array keys)

Fixed bug #76505 (array_merge_recursive() is duplicating sub-array keys)

Report unknown variables passed to compact()

Don't use UNREFs during array operations

Perform DEREFs instead. We were already doing this in some, but not
all places.

While UNREFs are supposed to be transparent, in practice

Don't use UNREFs during array operations

Perform DEREFs instead. We were already doing this in some, but not
all places.

While UNREFs are supposed to be transparent, in practice they have
rare observable side effects. Calling array_merge() on an array
should never change how that array behaves.

show more ...

Merge branch 'PHP-7.2'

* PHP-7.2:
Fixed bug #76410 (SIGV in zend_mm_alloc_small)
Fix bug #76390 - do not allow invalid strings in range()

Conflicts:
ext/stan

Merge branch 'PHP-7.2'

* PHP-7.2:
Fixed bug #76410 (SIGV in zend_mm_alloc_small)
Fix bug #76390 - do not allow invalid strings in range()

Conflicts:
ext/standard/array.c

show more ...

Fixed bug #76410 (SIGV in zend_mm_alloc_small)

Fix bug #76390 - do not allow invalid strings in range()

Merge branch 'PHP-7.1' into PHP-7.2

* PHP-7.1:
Fix bug #76390 - do not allow invalid strings in range()

Fix bug #76390 - do not allow invalid strings in range()

Avoid rehashing of "packed" array

Merge branch 'PHP-7.2'

* PHP-7.2:
Translate correct C++ version with suitable compiler
Fixed bug #76383 (array_map on $GLOBALS returns IS_INDIRECT)

Merge branch 'PHP-7.1' into PHP-7.2

* PHP-7.1:
Translate correct C++ version with suitable compiler
Fixed bug #76383 (array_map on $GLOBALS returns IS_INDIRECT)

Use zend_string_release_ex() instread of zend_string_release() in places, where we sure about string persistence.