Improve some ValueError messages

Closes GH-5340

Improve undefined variable error messages

Closes GH-5312

Improve argument error messages in ext/standard

Closes GH-5198

Use separate typedef for bucket comparison function

Avoid performing the same casting dance inside each sort compare
function.

Add ValueError for invalid mode in count()

Closes GH-5106

Fix double free in array_reduce

return_value needs to be explicitly nulled out in the failure case.

Remove unnecessary result variable

Instead directly use return_value. Hopefully this also works
around the "may be uninitialized" warning...

Eliminate uses of ZVAL_ZVAL and friends

Instead add RETURN_COPY(_VALUE) macros will the expected behavior.

RETURN_ZVAL doesn't make any sense since PHP 7, but has stuck
around,

Eliminate uses of ZVAL_ZVAL and friends

Instead add RETURN_COPY(_VALUE) macros will the expected behavior.

RETURN_ZVAL doesn't make any sense since PHP 7, but has stuck
around, probably because the alternative was to write directly to
the return_value variable.

show more ...

Make error messages more consistent by fixing capitalization

Closes GH-5066 As a first step, let's capitalize their initial letter when it is applicable.

Use RETURN_THROWS() in various places

Use RETURN_THROWS() after zend_throw_exception() in most of the extensions

Use RETURN_THROWS() after zend_throw_error()

Use RETURN_THROWS() after zend_type_error()

Use RETURN_THROWS() after zend_value_error()

Use RETURN_THROWS() when an exception is thrown

Closes GH-5036

Speed up array_intersect/array_diff/array_filter

Use zend_hash_update instead of zend_hash_add.

These are taking a subset of keys from an array with unique keys,
so the result s

Speed up array_intersect/array_diff/array_filter

Use zend_hash_update instead of zend_hash_add.

These are taking a subset of keys from an array with unique keys,
so the result should also have unique keys.
(this is already done for array_map())

Also, speed up array_intersect and array_diff slightly by
using ZEND_HASH_FOREACH macros.
This way, it doesn't need to load the same buckets and array counts
from memory every time (compiler previously couldn't infer they won't change)

```php
<?php
// $n=10000 now takes 0.095 seconds instead of 0.102
function test_bench(int $n) {
$values = range(0,1000);
$other = range(0,1000);
unset($other[500]);
unset($values[400]);

$total = 0;
for ($i = 0; $i < $n; $i++) {
$total += count(array_intersect_key($values, $other));
}
return $total;
}
```

show more ...

Capitalize first character of error message.

Convert Errors to ValueErrors

Closes GH-4930

Merge branch 'PHP-7.4'

* PHP-7.4:
Fixed bug #78759

Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
Fixed bug #78759

Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
Fixed bug #78759

Fixed bug #78759

Handle INDIRECT values in array.

Fix consistency issues with array accesses warnings/exceptions

* Change a number of "resource used as offset" notices to warnings,
which were previously missed.
* Throw the "res

Fix consistency issues with array accesses warnings/exceptions

* Change a number of "resource used as offset" notices to warnings,
which were previously missed.
* Throw the "resource used as offset" warning for isset() as well.
* Make array_key_exists() behavior with regard to different key
types consistent with isset() and normal array accesses. All key
types now use the usual coercions and array/object keys throw
TypeError.

Closes GH-4887.

show more ...

Remove support for array_key_exists() with objects

Update documentation/comment for GH-4860

Fix folding for the new helper method.

Clarify comment in UPGRADING:
The performance on associative arrays would also improve,
as lo

Update documentation/comment for GH-4860

Fix folding for the new helper method.

Clarify comment in UPGRADING:
The performance on associative arrays would also improve,
as long as no offsets were unset (no gaps).
Packed arrays can have gaps.

Closes GH-4873.
[ci skip]

show more ...