Declare tentative return types for ext/phar (#7052)

Merge branch 'PHP-8.0'

* Add a few missing RETURN_THROWS();
* Fix a few ext/phar return types

Add a few missing RETURN_THROWS();

Only PharFileInfo::compress() really needs it though.

Store base path as zend_string in Phar::buildFrom*

This also removes the need to check for length overflow, as the
length is now size_t.

Accept regex as zend_string in Phar::buildFromDirectory()

No need to copy it...

Use zend_string_equals_* API in a couple of more place

Closes GH-6979

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as 3.0 states "php 5.1.1, 4.1.1, and earlier".
3. In some license comments is "at through the world-wide-web" while most is without "at", so deleted.
4. fixed indentation in some files before |

show more ...

Introduce pseudo-keyword ZEND_FALLTHROUGH

And use it instead of comments

Change Zend Stream API to use zend_string* instead of char*.

This allows to eliminate re-calculation of string lenght and hash value.
See the detailed list of changes in UPGRADING.INTERN

Change Zend Stream API to use zend_string* instead of char*.

This allows to eliminate re-calculation of string lenght and hash value.
See the detailed list of changes in UPGRADING.INTERNALS.

show more ...

Improve SPL directory and stat() cache using zend_srting* instead of char*

Generate class entries from stubs for phar, posix, pspell, readline, reflection, session, shmop

Closes GH-6692

Merge branch 'PHP-8.0'

* PHP-8.0:
Make Phar $fileNotFoundScript nullable

Make Phar $fileNotFoundScript nullable

While "" is already treated the same way as absence, null is the
logically correct default here. Making this one argument non-nullable
is parti

Make Phar $fileNotFoundScript nullable

While "" is already treated the same way as absence, null is the
logically correct default here. Making this one argument non-nullable
is particularly pecular when considering that the preceding $alias
and $index arguments are both nullable.

show more ...

Merge branch 'PHP-8.0'

* PHP-8.0:
Fix #69279: Compressed ZIP Phar extractTo() creates garbage files

Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
Fix #69279: Compressed ZIP Phar extractTo() creates garbage files

Fix #69279: Compressed ZIP Phar extractTo() creates garbage files

When extracting compressed files from an uncompressed Phar, we must not
use the direct file pointer, but rather get an u

Fix #69279: Compressed ZIP Phar extractTo() creates garbage files

When extracting compressed files from an uncompressed Phar, we must not
use the direct file pointer, but rather get an uncompressed file
pointer.

We also add a test to show that deflated and stored entries are
properly extracted.

This also fixes #79912, which appears to be a duplicate of #69279.

Co-authored-by: Anna Filina <afilina@gmail.com>

Closes GH-6599.

show more ...

Replace zend_bool uses with bool

We're starting to see a mix between uses of zend_bool and bool.
Replace all usages with the standard bool type everywhere.

Of course, zend_bool

Replace zend_bool uses with bool

We're starting to see a mix between uses of zend_bool and bool.
Replace all usages with the standard bool type everywhere.

Of course, zend_bool is retained as an alias.

show more ...

Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
Fix memory leak in Phar::webPhar() on Windows

Fix memory leak in Phar::webPhar() on Windows

Closes GH-6574.

Make compression_type nullable in a few more places

Missed that this was also used elsewhere...

Make Phar $format and $compression arguments nullable

Rather than using Greg's birthday, use null to indicate that the
existing format/compression should be retained. For the format

Make Phar $format and $compression arguments nullable

Rather than using Greg's birthday, use null to indicate that the
existing format/compression should be retained. For the format
simply using zero would be sufficient, but as the documentation
explicitly says that NULL is allowed here, we may as well make
that the truth.

show more ...

Consolidate new union type ZPP macro names

They will now follow the canonical order of types. Older macros are
left intact due to maintaining BC.

Closes GH-6112

Fix UNKNOWN default values in various extensions

Closes GH-6075

Promote warnings to exceptions in ext/phar

Closes GH-6008

Add another round of missing parameter types to stubs

Closes GH-5950