Replace zend_bool uses with bool

We're starting to see a mix between uses of zend_bool and bool.
Replace all usages with the standard bool type everywhere.

Of course, zend_bool

Replace zend_bool uses with bool

We're starting to see a mix between uses of zend_bool and bool.
Replace all usages with the standard bool type everywhere.

Of course, zend_bool is retained as an alias.

show more ...

Remove unnecessary INDIRECT checks in JIT helpers

Fixed 32-bit JIT

Added missing deoptimization code for trampoline handling

Convert numeric string array keys to integers correctly in JITted code

While fixing bugs in mbstring, one of my new test cases failed with a strange
error message stating: 'Warning: Unde

Convert numeric string array keys to integers correctly in JITted code

While fixing bugs in mbstring, one of my new test cases failed with a strange
error message stating: 'Warning: Undefined array key 1...', when clearly the
array key had been set properly.

GDB'd that sucker and found that JIT'd PHP code was calling directly into
`zend_hash_add_new` (which was not converting the numeric string key to an
integer properly). But where was that code coming from? I examined the disasm,
looked up symbols to figure out where call instructions were going, then grepped
the codebase for those function names. It soon became clear that the disasm I
was looking at was compiled from `zend_jit_fetch_dim_w_helper`.

show more ...

Improve JIT for fetching character form string

Keep the same JIT code for PHP-8.0 and master (workaround against PHP-8.0 ABI freeze)

Fixed memory leak in ext/spl/tests/bug77263.phpt

Optimize code for FETCH_THIS + INIT_METHOD_CALL/ASSIGN_OBJ_OP/etc

JIT for INIT_METHOD_CALL

Simplify zend_jit_pre/post_inc/dec_typed_ref() helpers

JIT for PRE/POST_INC/DEC_OBJ

JIT for ASSIGN_OBJ_OP

JIT for ASSIGN_OBJ

JIT for FETCH_DIM_W/RW insructions

Fix call to type error functions from jit

Missed to adjust those calls.

Eliminate ZSTR_IS_INTERNED() check

Promote "undefined array key" notice to warning

This implements the last remaining part of the
https://wiki.php.net/rfc/engine_warnings RFC.

Closes GH-5927.

Merge common "cold" part

Implement 'Saner Numeric Strings' RFC:

RFC: https://wiki.php.net/rfc/saner-numeric-strings

This removes the -1 allow_error mode from is_numeric_string functions and replaces it by

Implement 'Saner Numeric Strings' RFC:

RFC: https://wiki.php.net/rfc/saner-numeric-strings

This removes the -1 allow_error mode from is_numeric_string functions and replaces it by
a trailing boolean out argument to preserve BC in a couple of places.

Most of the changes can be resumed to "numeric" strings which emitted a E_NOTICE now emit
a E_WARNING and "numeric" strings which emitted a E_WARNING now throw a TypeError.

This mostly affects:
- String offsets
- Arithmetic operations
- Bitwise operations

Closes GH-5762

show more ...

Remove old code (BP_VAR_RW warning)

Fixed tracing JIT for ASSIGN to typed reference

JIT for array merging

Review the usage of apostrophes in error messages

Closes GH-5590

Merge branch 'PHP-7.4'

* PHP-7.4:
Fixed bug #79793