Drop support for max_length in mysqli_fetch_fields()

Retain the field, but always populate it with zero. This was
already the case for PS without length updating.

max_length has

Drop support for max_length in mysqli_fetch_fields()

Retain the field, but always populate it with zero. This was
already the case for PS without length updating.

max_length has nothing lost in the field metadata -- it is a
property of the specific result set, and requires scanning the
whole result set to compute. PHP itself never uses max_length
with mysqlnd, it is only exposed in the raw mysqli API.

Keeping it for just that purpose is not worthwhile given the costs
involved. People who actually need this for some reason can easily
calculate it themselves, while making it obvious that the
calculation requires a full result set scan.

show more ...

MySQLnd: Drop free_result_internal

Merge it into free_result. There is a large number of different
free_* functions for result sets, let's avoid having one more.
Only difference is t

MySQLnd: Drop free_result_internal

Merge it into free_result. There is a large number of different
free_* functions for result sets, let's avoid having one more.
Only difference is that it does not increment stats, and that
seems like a bug as free_stmt_result is still freeing a result.

show more ...

MySQLnd: Simplify management of zval row buffer

Something odd was being done here, with the row packet having a
flag for whether it should allocate the zval buffer, which would
then

MySQLnd: Simplify management of zval row buffer

Something odd was being done here, with the row packet having a
flag for whether it should allocate the zval buffer, which would
then get moved into the result set.

Keep the management of this buffer purely at the result set level.
This also allows us to easily reuse the same buffer for all results,
rather than allocating a new one for each fetch.

show more ...

Merge branch 'PHP-8.0'

* PHP-8.0:
Fix stmt_free_result implementation and usage
Make XFAILED test less broken

Fix stmt_free_result implementation and usage

Two bugs both affecting the bug_pecl_7976.phpt test ("works with
mysqlnd" haha):

* We should not change the connection state in st

Fix stmt_free_result implementation and usage

Two bugs both affecting the bug_pecl_7976.phpt test ("works with
mysqlnd" haha):

* We should not change the connection state in stmt_free_result.
This makes mysql_stmt_free_result usable under mysqlnd and
not just libmysqlclient.
* If we call mysql_stmt_free_result, we still need to consume
any outstanding result sets.

show more ...

Merge branch 'PHP-8.0'

* PHP-8.0:
Handle changing column count in mysqlnd result binding

Handle changing column count in mysqlnd result binding

If the count changes from prepare to execute and result_bind is
alreadly allocated, reallocate it there.

This is something

Handle changing column count in mysqlnd result binding

If the count changes from prepare to execute and result_bind is
alreadly allocated, reallocate it there.

This is something of a hack. It would be cleaner to require that
result bindings are registered only after execute, when the final
result set fields are known. But mysqli at least directly exposes
this to the user, so we have no guarantee.

show more ...

Merge branch 'PHP-8.0'

* PHP-8.0:
Fix bug #72413: Segfault with get_result and PS cursors

Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
Fix bug #72413: Segfault with get_result and PS cursors

Fix bug #72413: Segfault with get_result and PS cursors

We cannot simply switch to use_result here, because the fetch_row
methods in get_result mode and in use_result/store_result mode

Fix bug #72413: Segfault with get_result and PS cursors

We cannot simply switch to use_result here, because the fetch_row
methods in get_result mode and in use_result/store_result mode
are different: In one case it accepts a statement, in the other
a return value zval. Thus, doing a switch to use_result results
in a segfault when trying to fetch a row.

Actually supporting get_result with cursors would require adding
cursor support in mysqlnd_result, not just mysqlnd_ps. That would
be a significant amount of effort and, given the age of the issue,
does not appear to be particularly likely to happen soon.

As such, we simply generate an error when using get_result()
with cursors, which is much better than causing a segfault.
Instead, parameter binding needs to be used.

show more ...

Merge branch 'PHP-8.0'

* PHP-8.0:
Retain QUIT_SEND connection state

Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
Retain QUIT_SEND connection state

Retain QUIT_SEND connection state

If the server goes away while reading a packet, don't go back into
the READY state. This will just cause broken pipe errors down the
line.

Merge branch 'PHP-8.0'

* PHP-8.0:
Handle mysqli errors in more cases
Sync test with master

Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
Handle mysqli errors in more cases
Sync test with master

Handle mysqli errors in more cases

Report errors autocommit, commit, rollback and mysqli_stmt_attr_set.

Additionally, copy the error from conn to stmt when preparing fails,
so t

Handle mysqli errors in more cases

Report errors autocommit, commit, rollback and mysqli_stmt_attr_set.

Additionally, copy the error from conn to stmt when preparing fails,
so these errors are also handled by mysqli_stmt_prepare.

Closes GH-6157.

show more ...

Merge branch 'PHP-8.0'

* PHP-8.0:
Fix bug #79375

Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
Fix bug #79375

Fix bug #79375

Make sure deadlock errors are properly propagated and reports in
a number of places in mysqli and PDO MySQL.

This also fixes a memory and a segfault that can occu

Fix bug #79375

Make sure deadlock errors are properly propagated and reports in
a number of places in mysqli and PDO MySQL.

This also fixes a memory and a segfault that can occur under these
conditions.

show more ...

Fix [-Wduplicated-cond] in MySQLnd driver

Changing it to TYPE_C as this is the only other type in the mysqlnd_buffered_type enum

Fix [-Wundef] warning in MySQLnd extension

Merge branch 'PHP-7.4'

* PHP-7.4:
Fix MySQL local infile / attr handling on big endian systems

Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
Fix MySQL local infile / attr handling on big endian systems

Fix MySQL local infile / attr handling on big endian systems

Make sure pointer types match what is used by libmysql everywhere.

Closes GH-5380.

Remove mention of PHP major version in Copyright headers

Closes GH-4732.