Add a ZEND_UNCOMPARABLE value

To explicitly indicate that objects are uncomparable. For now
this has no functional difference from the usual 1 return value,
but makes intent clearer.

Merge branch 'PHP-7.4'

* PHP-7.4:
Fix #74940: DateTimeZone loose comparison always true

Fix #74940: DateTimeZone loose comparison always true

Since `DateTimeZone` does not implement a `compare_objects` handler,
nor has any properties, two `DateTimeZone` instances always com

Fix #74940: DateTimeZone loose comparison always true

Since `DateTimeZone` does not implement a `compare_objects` handler,
nor has any properties, two `DateTimeZone` instances always compare as
being equal, even if they designate totally different timezones. Even
worse, after calling `var_dump()` on these objects, the actual
comparison may yield a correct result.

We therefore introduce a `compare_objects` handlers, which prevents
different behavior before/after `var_dump()`, and which allows us to
clearly define the intended semantics.

show more ...

Merge branch 'PHP-7.4'

* PHP-7.4:
Fix #79396: DateTime hour incorrect during DST jump forward

Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
Fix #79396: DateTime hour incorrect during DST jump forward

Fix #79396: DateTime hour incorrect during DST jump forward

When you attempt to set the time to a non-existent time occuring during
a DST jump forward, the hour does not move forward cor

Fix #79396: DateTime hour incorrect during DST jump forward

When you attempt to set the time to a non-existent time occuring during
a DST jump forward, the hour does not move forward correctly.

show more ...

Apply tidy formatting

Mostly reindent PHP scripts to spaces.

Merge branch 'PHP-7.4'

* PHP-7.4:
Fix DatePeriod property handling with indirect modification

Fix DatePeriod property handling with indirect modification

We do need to implement get_property_ptr_ptr to make arrays work
correctly.

Merge branch 'PHP-7.4'

* PHP-7.4:
Fix leak in DateTimeImmutable::modify()

Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
Fix leak in DateTimeImmutable::modify()

Fix leak in DateTimeImmutable::modify()

Fix leak in DatePeriod construction with invalid format

Same issue as I fixed in DateInterval construction before.

Fix rel_date leak on DateInterval construction failure

Make error messages more consistent by fixing capitalization

Closes GH-5066 As a first step, let's capitalize their initial letter when it is applicable.

Adding DateTime(Immutable)::createFromInterface()

These are like

DateTime::createFromImmutable()
DateTimeImmutable::createFromMutable()

but accept any DateTimeI

Adding DateTime(Immutable)::createFromInterface()

These are like

DateTime::createFromImmutable()
DateTimeImmutable::createFromMutable()

but accept any DateTimeInterface instead.

Closes GH-5016.

show more ...

Merge branch 'PHP-7.4'

* PHP-7.4:
Fix #79015: undefined-behavior in php_date.c

Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
Fix #79015: undefined-behavior in php_date.c

Fix #79015: undefined-behavior in php_date.c

We check that the given microsecond fraction is in the valid range
[0, 1000000[, and otherwise mark it as invalid. We also drop the
usel

Fix #79015: undefined-behavior in php_date.c

We check that the given microsecond fraction is in the valid range
[0, 1000000[, and otherwise mark it as invalid. We also drop the
useless do loop; a plain block is sufficient here.

show more ...

Use RETURN_THROWS() after zend_parse_method_parameters()

Use RETURN_THROWS() after zend_throw_error()

Use RETURN_THROWS() during ZPP in the date, dba and dom extensions

Support single class unions in gen stubs

Fix DateTimeImmutable stubs

These were referencing the arginfo from the functions, instead of
the methods, which isn't right, as the functions have return types.

Add missing ZPP checks

Closes GH-4878.