Fixed bug #70904 (yield from incorrectly marks valid generator as finished)

Remove superfluous branches

Set expectations in generator handling

Fix bogus traces with ReflectionGenerator::getTrace()

Mark error and exception functions as "cold" (Matt's idea)

Get rid of implicit type casting in GC_*() macros in Zend/zend_types.h.
This prevented compilation warnings and disclosed few incorrect usages in Zend/zend_vm_def.h and ext/dom/xpath.c.
Now e

Get rid of implicit type casting in GC_*() macros in Zend/zend_types.h.
This prevented compilation warnings and disclosed few incorrect usages in Zend/zend_vm_def.h and ext/dom/xpath.c.
Now explicit type casting may be required on call site.
This may break some C extension code, but it shoulfn't be a problem to add explicit casting.

show more ...

"This" is C++ keyword

Use NULL where possible for exception class

Matches usage of zend_throw_exception()/zend_throw_exception_ex().

Remove need to pass error level

Enable throwing custom exceptions from errors

Switch position of ce in exception ce variable names

Change zend_exception_get_default() to zend_exception_ce

Fix more minor mistakes in the proto comments

Avoid op_num = -1 in unfinished generator cleanup

Also add two tests showing that the -1 substraction in the
computation of op_num is really necessary.

Load/restore VM stack before unfinished generator cleanup

Fix generator memory leak

Make sure HANDLE_EXCEPTION and generator unwinds stay in sync in
the future by extracting a common function.

Get rid of more ZVAL_ZVAL() macros

Avoid zval duplication in ZVAL_ZVAL() macro (it was necessary only in few places).
Switch from ZVAL_ZVAL() to simpler macros where possible (it makes sense to review remaining places)

Merge branch 'PHP-5.6'

Conflicts:
Zend/zend_generators.c

Fix bug #69740

Fix memleak in generators using symtable

Fixed $this release

Fix yield from with iterator (first element missing)

Fix memory error when throwing into a generator

throw_exception_internal will access opline+1, which is not always
defined at the current opline of the generator. To avoid this
decre

Fix memory error when throwing into a generator

throw_exception_internal will access opline+1, which is not always
defined at the current opline of the generator. To avoid this
decrement the opline before throwing (so the throw occurs at the
YIELD opcode instead of one after it).

show more ...

Mark call frames to closures with ZEND_CALL_CLOSURE flag to avoid expensive check at zend_leave_helper()