Add Attributes

Co-authored-by: Martin Schröder <m.schroeder2007@gmail.com>

Refactor ZPP API to use uint32_t as everywhere else

Closes GH-5609

Allow null callback to array_filter()

With same behavior as not passing it.

Rename zend_zval_get_type() API

We have a bunch of APIs for getting type names and it's sometimes
hard to keep them apart ... make it clear that this is the one
you definitely do not

Rename zend_zval_get_type() API

We have a bunch of APIs for getting type names and it's sometimes
hard to keep them apart ... make it clear that this is the one
you definitely do not want to use.

show more ...

Fix [-Wundef] warning in Zend folder

Remove old ARG_COUNT() macro

Use ZEND_NUM_ARGS() instead.

Clsoes GH-5551

Fix UNKNOWN default values in various extensions

Closes GH-5514

Add Fast ZPP string|int type check

Convert UNKNOWN default values to null in ext/date

Closes GH-5509

Completely remove disabled functions from function table

Currently, disabling a function only replaces the internal
function handler with one that throws a warning, and a few
places

Completely remove disabled functions from function table

Currently, disabling a function only replaces the internal
function handler with one that throws a warning, and a few
places in the engine special-case such functions, such as
function_exists. This leaves us with a Schrödinger's function,
which both does not exist (function_exists returns false) and
does exist (you cannot define a function with the same name).
In particular, this prevents the implementation of robust
polyfills, as reported in https://bugs.php.net/bug.php?id=79382:

if (!function_exists('getallheaders')) {
function getallheaders(...) { ... }
}

If getallheaders() is a disabled function, this code will break.

This patch changes disable_functions to remove the functions from
the function table completely. For all intents and purposes, it
will look like the function does not exist.

This also renders two bits of PHP functionality obsolete and thus
deprecated:

* ReflectionFunction::isDisabled(), as it will no longer be
possible to construct the ReflectionFunction of a disabled
function in the first place.
* get_defined_functions() with $exclude_disabled=false, as
get_defined_functions() now never returns disabled functions.

Fixed bug #79382.

Closes GH-5473.

show more ...

Pass existing lcname to check_magic_method_implementation

Generate method entries from stubs for a couple of extensions

Closes GH-5368

Add support for generating method entries from stubs

Closes GH-5363

Add Z_PARAM_RESOURCE_OR_NULL()

As a more explicit alternative to Z_PARAM_RESOURCE_EX(, 1, 0).

Export API for fetching internal func default

Make this functionality available outside reflection.

Store default parameter values of internal functions in arg info

Closes GH-5353. From now on, PHP will have reflection information
about default values of parameters of internal function

Store default parameter values of internal functions in arg info

Closes GH-5353. From now on, PHP will have reflection information
about default values of parameters of internal functions.

Co-authored-by: Nikita Popov <nikita.ppv@gmail.com>

show more ...

Display nullability in type error messages for internal functions

Closes GH-5327

mb_detect_encoding(): Use proper array|string parameter

Needed to add support for nullabiltiy in some places.

Improve argument error messages in ext/standard

Closes GH-5198

Remove NO_ACCESS flag for zend_is_callable()

We may add support for fake_scope if necessary.

Store aliased name of trait method

Currently, trait methods are aliased will continue to use the
original function name. In a few places in the codebase, we will
try to look up the a

Store aliased name of trait method

Currently, trait methods are aliased will continue to use the
original function name. In a few places in the codebase, we will
try to look up the actual method name instead. However, this does
not work if an aliased method is used indirectly
(https://bugs.php.net/bug.php?id=69180).

I think it would be better to instead actually change the method
name to the alias. This is in principle easy: We have to allow
function_name to be changed even if op array is otherwise shared
(similar to static_variables). This means we need to addref/release
the function_name separately, but I don't think there is a
performance concern here (especially as everything is usually
interned).

There is a bit of complication in opcache, where we need to make
sure that the function name is released the correct number of times
(interning may overwrite the name in the original op_array, but we
need to release it as many times as the op_array is shared).

Fixes bug #69180.
Fixes bug #74939.
Closes GH-5226.

show more ...

Fix macro-expansion issues in ZEND_FE and friends

I noticed that we have various places where we work around macros
conflicting with PHP function names. Rather than require this,
fix

Fix macro-expansion issues in ZEND_FE and friends

I noticed that we have various places where we work around macros
conflicting with PHP function names. Rather than require this,
fix our ZEND_FE etc macros to avoid pre-scan macro expansion.
This requires duplicating the ZEND_FN/ZEND_MN macros in places,
but that seems like a reasonable tradeoff.

show more ...

Make type error messages more consistent

Closes GH-5092

Constrain number parameter of numfmt_format to int|float

This is inline with similar changes to the math functions. Especially,
array to number conversion makes no sense here, and is li

Constrain number parameter of numfmt_format to int|float

This is inline with similar changes to the math functions. Especially,
array to number conversion makes no sense here, and is likely to hide
a programming error.

To make that feasible, we introduce the `n` specifier for classic ZPP
so we can stick with `zend_parse_method_parameters()`.

We also remove a test case, which has been degenerated to a ZPP test.

show more ...

Eliminate uses of ZVAL_ZVAL and friends

Instead add RETURN_COPY(_VALUE) macros will the expected behavior.

RETURN_ZVAL doesn't make any sense since PHP 7, but has stuck
around,

Eliminate uses of ZVAL_ZVAL and friends

Instead add RETURN_COPY(_VALUE) macros will the expected behavior.

RETURN_ZVAL doesn't make any sense since PHP 7, but has stuck
around, probably because the alternative was to write directly to
the return_value variable.

show more ...