History log of /php-src/Zend/zend.c (Results 251 – 275 of 889)
Revision (<<< Hide revision tags) (Show revision tags >>>) Date Author Comments
(<<< Hide modified files)
(Show modified files >>>)
Revision tags: php-7.1.0alpha2, php-7.0.8, php-5.6.23, php-5.5.37
# 3d3f11ed 20-Jun-2016 Anatol Belski

Fixed the UTF-8 and long path support in the streams on Windows.

Since long the default PHP charset is UTF-8, however the Windows part is
out of step with this important point. The curre

Fixed the UTF-8 and long path support in the streams on Windows.

Since long the default PHP charset is UTF-8, however the Windows part is
out of step with this important point. The current implementation in PHP
doesn't technically permit to handle UTF-8 filepath and several other
things. Till now, only the ANSI compatible APIs are being used. Here is more
about it

https://msdn.microsoft.com/en-us/library/windows/desktop/dd317752%28v=vs.85%29.aspx

The patch fixes not only issues with multibyte filenames under
incompatible codepages, but indirectly also issues with some other multibyte
encodings like BIG5, Shift-JIS, etc. by providing a clean way to access
filenames in UTF-8. Below is a small list of issues from the bug tracker,
that are getting fixed:

https://bugs.php.net/63401
https://bugs.php.net/41199
https://bugs.php.net/50203
https://bugs.php.net/71509
https://bugs.php.net/64699
https://bugs.php.net/64506
https://bugs.php.net/30195
https://bugs.php.net/65358
https://bugs.php.net/61315
https://bugs.php.net/70943
https://bugs.php.net/70903
https://bugs.php.net/63593
https://bugs.php.net/54977
https://bugs.php.net/54028
https://bugs.php.net/43148
https://bugs.php.net/30730
https://bugs.php.net/33350
https://bugs.php.net/35300
https://bugs.php.net/46990
https://bugs.php.net/61309
https://bugs.php.net/69333
https://bugs.php.net/45517
https://bugs.php.net/70551
https://bugs.php.net/50197
https://bugs.php.net/72200
https://bugs.php.net/37672

Yet more related tickets can for sure be found - on bugs.php.net, Stackoverflow
and Github. Some of the bugs are pretty recent, some descend to early
2000th, but the user comments in there last even till today. Just for example,
bug #30195 was opened in 2004, the latest comment in there was made in 2014. It
is certain, that these bugs descend not only to pure PHP use cases, but get also
redirected from the popular PHP based projects. Given the modern systems (and
those supported by PHP) are always based on NTFS, there is no excuse to keep
these issues unresolved.

The internalization approach on Windows is in many ways different from
UNIX and Linux, while it supports and is based on Unicode. It depends on the
current system code page, APIs used and exact kind how the binary was compiled
The locale doesn't affect the way Unicode or ANSI API work. PHP in particular
is being compiled without _UNICODE defined and this is conditioned by the
way we handle strings. Here is more about it

https://msdn.microsoft.com/en-us/library/tsbaswba.aspx

However, with any system code page ANSI functions automatically convert
paths to UTF-16. Paths in some encodings incompatible with the
current system code page, won't work correctly with ANSI APIs. PHP
till now only uses the ANSI Windows APIs.

For example, on a system with the current code page 1252, the paths
in cp1252 are supported and transparently converted to UTF-16 by the
ANSI functions. Once one wants to handle a filepath encoded with cp932 on
that particular system, an ANSI or a POSIX compatible function used in
PHP will produce an erroneous result. When trying to convert that cp932 path
to UTF-8 and passing to the ANSI functions, an ANSI function would
likely interpret the UTF-8 string as some string in the current code page and
create a filepath that represents every single byte of the UTF-8 string.
These behaviors are not only broken but also disregard the documented
INI settings.

This patch solves the issies with the multibyte paths on Windows by
intelligently enforcing the usage of the Unicode aware APIs. For
functions expect Unicode (fe CreateFileW, FindFirstFileW, etc.), arguments
will be converted to UTF-16 wide chars. For functions returning Unicode
aware data (fe GetCurrentDirectoryW, etc.), resulting wide string is
converted back to char's depending on the current PHP charset settings,
either to the current ANSI codepage (this is the behavior prior to this patch)
or to UTF-8 (the default behavior).

In a particular case, users might have to explicitly set
internal_encoding or default_charset, if filenames in ANSI codepage are
necessary. Current tests show no regressions and witness that this will be an
exotic case, the current default UTF-8 encoding is compatible with any
supported system. The dependency libraries are long switching to Unicode APIs,
so some tests were also added for extensions not directly related to streams.
At large, the patch brings over 150 related tests into the core. Those target
and was run on various environments with European, Asian, etc. codepages.
General PHP frameworks was tested and showed no regressions.

The impact on the current C code base is low, the most places affected
are the Windows only places in the three files tsrm_win32.c, zend_virtual_cwd.c
and plain_wrapper.c. The actual implementation of the most of the wide
char supporting functionality is in win32/ioutil.* and win32/codepage.*,
several low level functionsare extended in place to avoid reimplementation for
now. No performance impact was sighted. As previously mentioned, the ANSI APIs
used prior the patch perform Unicode conversions internally. Using the
Unicode APIs directly while doing custom conversions just retains the status
quo. The ways to optimize it are open (fe. by implementing caching for the
strings converted to wide variants).

The long path implementation is user transparent. If a path exceeds the
length of _MAX_PATH, it'll be automatically prefixed with \\?\. The MAXPATHLEN
is set to 2048 bytes.

Appreciation to Pierre Joye, Matt Ficken, @algo13 and others for tips, ideas
and testing.

Thanks.

show more ...

# 3abd9c34 20-Jun-2016 Dmitry Stogov

Removed unused callbacks

Revision tags: php-5.6.23RC1, php-7.0.8RC1, php-7.1.0alpha1, php-5.6.22, php-5.5.36, php-7.0.7, php-5.6.22RC1, php-7.0.7RC1, php-7.0.6, php-5.6.21, php-5.5.35, php-5.6.21RC1, php-7.0.6RC1, php-5.6.20, php-5.5.34, php-7.0.5, php-5.6.20RC1, php-7.0.5RC1, php-5.6.19, php-5.5.33, php-7.0.4, php-5.6.19RC1, php-7.0.4RC1, php-5.6.18, php-7.0.3, php-5.5.32, php-5.6.18RC1, php-7.0.3RC1, php-5.6.17, php-5.5.31, php-7.0.2, php-7.0.2RC1, php-5.6.17RC1, php-7.0.1RC1, php-7.0.0, php-5.6.16, php-7.0.0RC8, php-7.0.0RC7, php-5.6.16RC1, php-5.6.15, php-7.0.0RC6, php-7.0.1, php-5.6.15RC1, php-7.0.0RC5
# 1b29e0ca 07-Oct-2015 Nikita Popov

Switch zend_print_zval_r to use smart_str

Instead of directly writing to stdout. This allows doing a print_r
into a string, without using output buffering.

The motivation for th

Switch zend_print_zval_r to use smart_str

Instead of directly writing to stdout. This allows doing a print_r
into a string, without using output buffering.

The motivation for this is bug #67467: print_r() in return mode
will still dump the string to stdout (causing a potential information
leak) if a fatal error occurs.

show more ...

# 47e26cf9 02-Jun-2016 Anatol Belski

fix known interned strings init with TS per request

# 7b94b958 12-May-2016 Dmitry Stogov

Intern some known (and offten used) strings.

# f57c0b32 03-Mar-2016 Nikita Popov

Merge branch 'PHP-7.0'


# 1ac15293 03-Mar-2016 Nikita Popov

Move semicolon into TSRMLS_CACHE_EXTERN/DEFINE

Also re bug #71575.

# c58ad955 26-Jan-2016 Xinchen Hui

Merge branch 'PHP-7.0'

* PHP-7.0:
Fixed bug #71443 (Segfault using built-in webserver with intl using symfony)
Fix memory leak with not freeing OpenSSL errors
check for NUL

Merge branch 'PHP-7.0'

* PHP-7.0:
Fixed bug #71443 (Segfault using built-in webserver with intl using symfony)
Fix memory leak with not freeing OpenSSL errors
check for NULL and avoid crashes
Update libmagic.patch for PHP-5.6
Fixed bug #7143 (finfo throws notice for specific python file)

show more ...


# 9ff08ae1 26-Jan-2016 Xinchen Hui

Fixed bug #71443 (Segfault using built-in webserver with intl using symfony)

# 56365982 02-Jan-2016 Xinchen Hui

Merge branch 'PHP-7.0'


# 97a9470d 02-Jan-2016 Xinchen Hui

bump year which is missed in rev 49493a2

# b8515125 21-Dec-2015 Anatol Belski

Merge branch 'PHP-7.0'

* PHP-7.0:
Revert "Partially fix bug #71129"


# 53bfb661 21-Dec-2015 Anatol Belski

Revert "Partially fix bug #71129"

This reverts commit 4c55669caa96f6202c2047a7baf6c5d5894d5fa7.

The way it is fixes doesn't satisfy every SAPI, so a better solution
is yet to wo

Revert "Partially fix bug #71129"

This reverts commit 4c55669caa96f6202c2047a7baf6c5d5894d5fa7.

The way it is fixes doesn't satisfy every SAPI, so a better solution
is yet to work out.

show more ...

# 6f4286f3 20-Dec-2015 Anatol Belski

Merge branch 'PHP-7.0'

* PHP-7.0:
Partially fix bug #71129
Typo
Bug #71105 was fixed in 7.0.1 (commit 9374ba35)


# 4c55669c 20-Dec-2015 Anatol Belski

Partially fix bug #71129

# 86076411 19-Dec-2015 Xinchen Hui

Merge branch 'PHP-7.0'


# a21b0942 19-Dec-2015 Xinchen Hui

Fixed bug #71165 (-DGC_BENCH=1 doesn't work on PHP7)

# 3ed5e54a 16-Dec-2015 Xinchen Hui

Remove unused IS_TYPE_SYMBOLTABLE

# c2de445f 12-Nov-2015 Xinchen Hui

Also protects this one

# 53c03115 12-Nov-2015 Xinchen Hui

Re-fixed #70895

# fb2c890c 06-Oct-2015 Rasmus Lerdorf

zend.assertions is not a boolean

Revision tags: php-5.5.30, php-5.6.14, php-7.0.0RC4
# 4a174ca7 23-Sep-2015 Bob Weinand

Fixed bug #70532 (respect set_exception_handler in phpdbg)

# 7680194a 18-Sep-2015 Xinchen Hui

Fixed bug #70481 (Memory leak in auto_global_copy_ctor() in ZTS build)

Revision tags: php-5.6.14RC1, php-7.0.0RC3
# 4ddeeb49 11-Sep-2015 Xinchen Hui

Remove free_string_zval

Revision tags: php-5.6.13, php-7.0.0RC2, php-5.5.29, php-5.4.45
# 85a511d2 01-Sep-2015 Joe Watkins

fix zend signal and tsrm compat

1...<<11121314151617181920>>...36