Re-fix GH-8409: SSL handshake timeout persistent connections hanging

This fix is another solution to replace d0527427be57957157aec5e26a28899b380140df, use zend_try and zend_catch to make sur

Re-fix GH-8409: SSL handshake timeout persistent connections hanging

This fix is another solution to replace d0527427be57957157aec5e26a28899b380140df, use zend_try and zend_catch to make sure persistent stream will be released when error occurred.

Closes GH-9332.

show more ...

Revert "Fix GH-8409: SSL handshake timeout persistent connections hanging"

This reverts commit d0527427be57957157aec5e26a28899b380140df.

This patch makes Swoole/Swow can not work an

Revert "Fix GH-8409: SSL handshake timeout persistent connections hanging"

This reverts commit d0527427be57957157aec5e26a28899b380140df.

This patch makes Swoole/Swow can not work anymore, because Coroutine will yield to another one during socket operation, EG(record_errors) assertion will always fail, and zend_begin_record_errors() was only used during compile time before.
Note: zend_emit_recorded_errors() and the typo fix are reserved.

show more ...

Update expires format for session cookie (#9304)

* Update expires format for session cookie

see GH-9200
see 15e3fcb468d7ef6faddc8f99f8f708fe8c2d8492

* Add ext/session/t

Update expires format for session cookie (#9304)

* Update expires format for session cookie

see GH-9200
see 15e3fcb468d7ef6faddc8f99f8f708fe8c2d8492

* Add ext/session/tests/gh9200.phpt

show more ...

Fix GH-8409: SSL handshake timeout persistent connections hanging

This is not actually related to SSL handshake but stream socket creation
which does not clean errors if the error handle

Fix GH-8409: SSL handshake timeout persistent connections hanging

This is not actually related to SSL handshake but stream socket creation
which does not clean errors if the error handler is set. This fix
prevents emitting errors until the stream is freed.

show more ...

Fix GH-9309: Segfault when connection is used after imap_close()

We actually need to check whether `php_imap_object.imap_stream` is
`NULL` to detect that the connection has already been

Fix GH-9309: Segfault when connection is used after imap_close()

We actually need to check whether `php_imap_object.imap_stream` is
`NULL` to detect that the connection has already been closed.

Closes GH-9313.

show more ...

Merge branch 'PHP-8.0' into PHP-8.1

* PHP-8.0:
Fix GH-9296: `ksort` behaves incorrectly on arrays with mixed keys

Fix GH-9296: `ksort` behaves incorrectly on arrays with mixed keys

The comparator function used at ksort in SORT_REGULAR mode
need to be consistent with basic comparison rules. These rul

Fix GH-9296: `ksort` behaves incorrectly on arrays with mixed keys

The comparator function used at ksort in SORT_REGULAR mode
need to be consistent with basic comparison rules. These rules
were changed in PHP-8.0 for numeric strings, but comparator
used at ksort kept the old behaviour. It leads to inconsistent
situations, when after ksort the first key is GREATER than some
of the next ones by according to the basic comparison operators.

Closes GH-9293.

show more ...

Fixed GH-9200: setcookie has an obsolete expires date format

Fix GH-9266: GC root buffer keeps growing when dtors are present

Do not reset cleared count on GC rerun.

Closes GH-9265.

Make `"{$g{'h'}}"` emit fatal error and no incorrect deprecation notice in 8.2 (#9264)

The ast node flag constants ZEND_DIM_ALTERNATIVE_SYNTAX and
ZEND_ENCAPS_VAR_DOLLAR_CURLY_VAR_VAR no

Make `"{$g{'h'}}"` emit fatal error and no incorrect deprecation notice in 8.2 (#9264)

The ast node flag constants ZEND_DIM_ALTERNATIVE_SYNTAX and
ZEND_ENCAPS_VAR_DOLLAR_CURLY_VAR_VAR node have identical values (1<<1),
causing a deprecation notice to be incorrectly emitted before the fatal error
for unsupported syntax.

Fixes GH-9263

Explicitly check for AST_VAR/AST_DIM kind for future compatibility

`AST_PROP`/`AST_METHOD_CALL` and nullsafe variants can also be found in
encapsulated strings - currently they have no flags but they may have flags in
the future. This also clarifies that this deprecation warning can only happen
for AST_VAR/AST_DIM nodes for certain `attr` values.

show more ...

Fix GH-9248: Segmentation fault in mb_strimwidth()

We need to initialize the optional argument `trimmarker` with its
default value.

Closes GH-9273.

Merge branch 'PHP-8.0' into PHP-8.1

Fix GH-8472: stream_socket_accept result may have incorrect metadata

Fix GH-9244: Segfault with array_multisort + array_shift

After restructuring non-packed arrays, we either need to pack them if
possible, or to rehash them.

Closes GH-9247.

[ci skip] update NEWS
--CGI-- fixes for PHP 8.1 / 8.0
https://github.com/php/php-src/commit/30ed8fb32da398f62bb08ebd59c607eeafc3621d

Handle all-zero state in Xoshiro256** (#9250)

- Retry if the CSPRNG generates a zero state.
- Throw ValueError if the user passes a zero state.

Fixes GH-9249

[ci skip] NEWS and UPGRADING for constants in traits (#9251)

see GH-8888

Merge remote-tracking branch 'upstream/PHP-8.1'

Merge remote-tracking branch 'upstream/PHP-8.0' into PHP-8.1

[CI skip] update NEWS

Remove ZEND_DVAL_TO_LVAL_CAST_OK (#9215)

* Remove ZEND_DVAL_TO_LVAL_CAST_OK
As far as I can see, this operation should always use the _slow method, and the results seem to be wrong when

Remove ZEND_DVAL_TO_LVAL_CAST_OK (#9215)

* Remove ZEND_DVAL_TO_LVAL_CAST_OK
As far as I can see, this operation should always use the _slow method, and the results seem to be wrong when ZEND_DVAL_TO_LVAL_CAST_OK is enabled.

* update NEWS

show more ...

Fix undefined behavior of MT_RAND_PHP if range exceeds ZEND_LONG_MAX (#9197)

RAND_RANGE_BADSCALING() invokes undefined behavior when (max - min) >
ZEND_LONG_MAX, because the intermediate

Fix undefined behavior of MT_RAND_PHP if range exceeds ZEND_LONG_MAX (#9197)

RAND_RANGE_BADSCALING() invokes undefined behavior when (max - min) >
ZEND_LONG_MAX, because the intermediate `double` might not fit into
`zend_long`.

Fix this by inlining a fixed version of the macro into Mt19937's range()
function. Fixing the macro itself cannot be done in the general case, because
the types of the inputs are not known. Instead of replacing one possibly broken
version with another possibly broken version, the macro is simply left as is
and should be removed in a future version.

The fix itself is simple: Instead of storing the "offset" in a `zend_long`, we
use a `zend_ulong` which is capable of storing the resulting double by
construction. With this fix the implementation of this broken scaling is
effectively identical to the implementation of php_random_range from a data
type perspective, making it easy to verify the correctness.

It was further empirically verified that the broken macro and the fix return
the same results for all possible values of `r` for several distinct pairs of
(min, max).

Fixes GH-9190
Fixes GH-9191

show more ...

Add ext/random Exception hierarchy (#9220)

* Add Random\Random{Error,Exception} and Random\BrokenRandomEngineError

* Throw BrokenRandomEngineError

* Throw RandomException o

Add ext/random Exception hierarchy (#9220)

* Add Random\Random{Error,Exception} and Random\BrokenRandomEngineError

* Throw BrokenRandomEngineError

* Throw RandomException on seeding failure

* Throw RandomException when CSPRNG fails

* Remove unused include from ext/random/engine_combinedlcg.c

* Remove unused include from ext/random/engine_secure.c

* Remove unused include from ext/random/random.c

* [ci skip] Add ext/random Exception hierarchy to NEWS

* [ci skip] Add the change of Exception for random_(int|bytes) to UPGRADING

show more ...

Fix bug #65489: glob() basedir check is inconsistent

This removes the inconsistent and incorrectly working open basedir check
on pattern in glob. It means that an empty array will be ret

Fix bug #65489: glob() basedir check is inconsistent

This removes the inconsistent and incorrectly working open basedir check
on pattern in glob. It means that an empty array will be returned even
if the whole pattern is outside the open basedir restriction.

show more ...

Fix PcgOneseq128XslRr64::__construct() definition in random.stub.php (#9235)

* Fix PcgOneseq128XslRr64::__construct() definition in random.stub.php

The second parameter does not act

Fix PcgOneseq128XslRr64::__construct() definition in random.stub.php (#9235)

* Fix PcgOneseq128XslRr64::__construct() definition in random.stub.php

The second parameter does not actually exist for a Oneseq PCG. It was removed
from the RFC before it went into voting.

* [ci skip] Add PcgOneseq128XslRr64 stub fix to NEWS

show more ...