Add missing error check on tidyLoadConfig

Parse errors were not reported for the default config, they were only
reported when explicitly another config was loaded.
This means that us

Add missing error check on tidyLoadConfig

Parse errors were not reported for the default config, they were only
reported when explicitly another config was loaded.
This means that users may not be aware of errors in their configuration
and therefore the behaviour of Tidy might not be what they intended.
This patch fixes that issue by using a common function. In fact, the
check for -1 might be enough for the current implementation of Tidy, but
the Tidy docs say that any value other than 0 indicates an error.
So future errors might not be caught when just using an error code of -1.
Therefore, this also changes the error code checks of == -1 to < 0 and
== 1 to > 0.

Closes GH-10636

Signed-off-by: George Peter Banyard <girgias@php.net>

show more ...

Fix GH-10627: mb_convert_encoding crashes PHP on Windows

Fixes GH-10627

The php_mb_convert_encoding() function can return NULL on error, but
this case was not handled, which led

Fix GH-10627: mb_convert_encoding crashes PHP on Windows

Fixes GH-10627

The php_mb_convert_encoding() function can return NULL on error, but
this case was not handled, which led to a NULL pointer dereference and
hence a crash.

Closes GH-10628

Signed-off-by: George Peter Banyard <girgias@php.net>

show more ...

ext/mbstring: fix new_value length check

Commit 8bbd0952e5bba88 added a check rejecting empty strings; in the
merge commiot 379d9a1cfc6462 however it was changed to a NULL check,
one

ext/mbstring: fix new_value length check

Commit 8bbd0952e5bba88 added a check rejecting empty strings; in the
merge commiot 379d9a1cfc6462 however it was changed to a NULL check,
one that did not make sense because ZSTR_VAL() is guaranteed to never
be NULL; the length check was accidently removed by that merge commit.

This bug was found by GCC's -Waddress warning:

ext/mbstring/mbstring.c:748:27: warning: the comparison will always evaluate as ‘true’ for the address of ‘val’ will never be NULL [-Waddress]
748 | if (!new_value || !ZSTR_VAL(new_value)) {
| ^

Closes GH-10532

Signed-off-by: George Peter Banyard <girgias@php.net>

show more ...

[ci skip] NEWS

Fix GH-10623: ReflectionFunction::getClosureUsedVariables() returns empty array in presence of variadic arguments

The code was missing the handling for the RECV_VARIADIC instruction.
Add

Fix GH-10623: ReflectionFunction::getClosureUsedVariables() returns empty array in presence of variadic arguments

The code was missing the handling for the RECV_VARIADIC instruction.
Additional regression test for GH-10623

Co-authored-by: Fabio Ivona <fabio.ivona@defstudio.it>

show more ...

Update NEWS with scanner and parser build fixes

Revert "Fix GH-10168: heap-buffer-overflow at zval_undefined_cv"

This reverts commit 71ddede5655fe654002ae18af6a18e033f717287.

[ci skip] NEWS (#10586)

Fix missing colon in NEWS

Change NEWS for GHSA-54hq-v5wp-fqgv as it is for all SAPIs

Fix incorrect character in NEWS

Update NEWS

[ci skip] NEWS

PHP-8.1 is now for PHP 8.1.17-dev

Fix colletion of unfinished function call in fibers

Fixes GH-10496.

Co-authored-by: Bob Weinand <bobwei9@hotmail.com>

Update NEWS

Update NEWS

sockets add SO_RERROR/SO_ZEROIZE/SO_SPLICE net/openbsd's constants.

Closes GH-10563.

[ci skip] NEWS

[ci skip] NEWS (#10561)

Fix memory leaks in ext-tidy

We must not instantiate the object prior checking error conditions
Moreover, we need to release the HUGE amount of memory for files which are over 4GB when t

Fix memory leaks in ext-tidy

We must not instantiate the object prior checking error conditions
Moreover, we need to release the HUGE amount of memory for files which are over 4GB when throwing a ValueError

Closes GH-10545

show more ...

[ci skip] NEWS

ext/curl: suppress -Wdeprecated-declarations

Closes GH-10531.

Implement More Appropriate Date/Time Exceptions RFC

Fix GH-10168: heap-buffer-overflow at zval_undefined_cv

The problem is that we're using the variable_ptr in the opcode handler
*after* it has already been destroyed. The solution is to c

Fix GH-10168: heap-buffer-overflow at zval_undefined_cv

The problem is that we're using the variable_ptr in the opcode handler
*after* it has already been destroyed. The solution is to create a
specialised version of zend_assign_to_variable which takes in two
destination zval pointers.

Closes GH-10524

show more ...