unix: fix compile error in Android using bionic

When compiling with bionic, st_atime_nsec (and the other nsec members)
canot be found.
In order to compile uv with both NDK and bionic

unix: fix compile error in Android using bionic

When compiling with bionic, st_atime_nsec (and the other nsec members)
canot be found.
In order to compile uv with both NDK and bionic, tv_nsec should be
accessed from st_atimensec (and the others nsec members).
See "Compatibility with glibc" in stat.h from bionic.

Signed-off-by: Robert Chiras <robert.chiras@intel.com>

PR-URL: https://github.com/libuv/libuv/pull/746
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

show more ...

win: remove unneeded condition

PR-URL: https://github.com/libuv/libuv/pull/745
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

linux: call fclose(), fix fdopen() memory leak

Commit 6798876 ("linux: fix cpu count") switched the /proc/stat parser
to fdopen(). Use fclose() to close the file descriptor to avoid lea

linux: call fclose(), fix fdopen() memory leak

Commit 6798876 ("linux: fix cpu count") switched the /proc/stat parser
to fdopen(). Use fclose() to close the file descriptor to avoid leaking
resources associated with the FILE struct.

PR-URL: https://github.com/libuv/libuv/pull/747
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

show more ...

unix: fix uv__handle_type for AIX

'getsockname' does not handle UNIX domain sockets on AIX[1], it does not
fail but simply returns an empty structure with length 0.
If 'getsockname'

unix: fix uv__handle_type for AIX

'getsockname' does not handle UNIX domain sockets on AIX[1], it does not
fail but simply returns an empty structure with length 0.
If 'getsockname' does not fail (i.e. does not return -1) and the length
is 0 we know, on AIX, that the type is AF_UNIX.

This fixes test pipe_sendmsg.

[1] https://goo.gl/ozqcmS

PR-URL: https://github.com/libuv/libuv/pull/748
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

show more ...

linux: fix cpu count

When libuv is running inside container - eg. lxc container, cpu number
is not obvious. Linux control groups (cgroups) may limit numer of cpus.

As a result o

linux: fix cpu count

When libuv is running inside container - eg. lxc container, cpu number
is not obvious. Linux control groups (cgroups) may limit numer of cpus.

As a result of different number cpu cores inside container and
outside container, libuv is crashing.

sysconf(_SC_NPROCESSORS_ONLN) - returns num of host cpus (eg. 32)
`/proc/stat` - sees only cpus limited by cgroups (eg. 4)

When libuv is trying to operate at both numbers and they're different
it's crashing with current test:

run-tests: ../src/unix/linux-core.c:766: read_times: Assertion `num ==
numcpus' failed.

Count the number of cpus based on `/proc/stat` instead.

PR-URL: https://github.com/libuv/libuv/pull/735
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

show more ...

test: fix deadlocks in uv_cond_wait

Calling uv_cond_wait without uv_cond_signal/uv_cond_broadcast may
cause deadlock. This commit avoids this situation as well as tests
these functio

test: fix deadlocks in uv_cond_wait

Calling uv_cond_wait without uv_cond_signal/uv_cond_broadcast may
cause deadlock. This commit avoids this situation as well as tests
these functions.

PR-URL: https://github.com/libuv/libuv/pull/728
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

show more ...

unix, win: count null byte on UV_ENOBUFS

If an API function returns UV_ENOBUFS make sure we count the terminating
null, which we need space for. In case of success the null byte is not

unix, win: count null byte on UV_ENOBUFS

If an API function returns UV_ENOBUFS make sure we count the terminating
null, which we need space for. In case of success the null byte is not
included in the count, but the buffer *is* null terminated.

PR-URL: https://github.com/libuv/libuv/pull/690
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

show more ...

unix, win: consistently null-terminate buffers

libuv has multiple functions which return buffers. Make them consistent
with the following rules: the returned size *does not* include the

unix, win: consistently null-terminate buffers

libuv has multiple functions which return buffers. Make them consistent
with the following rules: the returned size *does not* include the null
byte, but the buffer *is* null terminated.

There is only one exception to the above: Linux abstract sockets,
because null bytes are not used as string terminators in those.

Refs: https://github.com/libuv/libuv/pull/674
PR-URL: https://github.com/libuv/libuv/pull/690
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

show more ...

test: reduce timeout in tcp_close_while_connecting

Somtimes (once every 10 runs or so) the socket would 'connect' before
'uv_close' was called. This caused EHOSTUNREACH to be set for SO_

test: reduce timeout in tcp_close_while_connecting

Somtimes (once every 10 runs or so) the socket would 'connect' before
'uv_close' was called. This caused EHOSTUNREACH to be set for SO_ERROR
instead of ECANCELED.

PR-URL: https://github.com/libuv/libuv/pull/744
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

show more ...

test: fix threadpool_multiple_event_loops on PPC

On PPC (linux and AIX) uv_thread_join (which is just a call to
pthread_join) takes quite a while. Increased the timeout of this
speci

test: fix threadpool_multiple_event_loops on PPC

On PPC (linux and AIX) uv_thread_join (which is just a call to
pthread_join) takes quite a while. Increased the timeout of this
specific test on PPC so that there is ample time for all threads to join
back. The fs_do and getaddrinfo_do calls do not take up much time.

Also removing the ifdef for AIX around fs_do since it did nothing.

Fixes: https://github.com/libuv/libuv/issues/687
PR-URL: https://github.com/libuv/libuv/pull/737
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

show more ...

build: compile with -D_THREAD_SAFE on AIX

This enables thread safe errno on AIX and causes the following tests to
pass:

ipc_send_recv_pipe_inprocess
ipc_send_recv_tc

build: compile with -D_THREAD_SAFE on AIX

This enables thread safe errno on AIX and causes the following tests to
pass:

ipc_send_recv_pipe_inprocess
ipc_send_recv_tcp_inprocess
fs_poll
fs_file_noent
fs_file_nametoolong
fs_file_loop
fs_chown
fs_readlink
fs_realpath
fs_scandir_file

PR-URL: https://github.com/libuv/libuv/pull/739
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

show more ...

doc: add missing write callback to example

PR-URL: https://github.com/libuv/libuv/pull/734
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

darwin: replace F_FULLFSYNC with fdatasync syscall

Refs: https://github.com/nodejs/node/pull/5402
PR-URL: https://github.com/libuv/libuv/pull/732
Reviewed-By: Ben Noordhuis <info@bno

darwin: replace F_FULLFSYNC with fdatasync syscall

Refs: https://github.com/nodejs/node/pull/5402
PR-URL: https://github.com/libuv/libuv/pull/732
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

show more ...

test: assume no IPv6 if interfaces cannot be listed

PR-URL: https://github.com/libuv/libuv/pull/724
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

build: python 2.x/3.x consistent print usage

PR-URL: https://github.com/libuv/libuv/pull/723
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

doc: add missing link in README

PR-URL: https://github.com/libuv/libuv/pull/722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

doc: describe how to make release builds on Unix

Refs: https://github.com/libuv/libuv/issues/550
PR-URL: https://github.com/libuv/libuv/pull/722
Reviewed-By: Ben Noordhuis <info@bnoo

doc: describe how to make release builds on Unix

Refs: https://github.com/libuv/libuv/issues/550
PR-URL: https://github.com/libuv/libuv/pull/722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

show more ...

linux: fix compilation with musl

PR-URL: https://github.com/libuv/libuv/pull/720
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

osx: protected use of potentially undefined macro

The `__FreeBSD__` macro is not defined by default on OSX, and building
with `-Wundef` will cause a warning to be emitted. This change ma

osx: protected use of potentially undefined macro

The `__FreeBSD__` macro is not defined by default on OSX, and building
with `-Wundef` will cause a warning to be emitted. This change makes
sure that the macro is only used if defined, removing the warning.

PR-URL: https://github.com/libuv/libuv/pull/710
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

show more ...

build: map 'AMD64' host arch to 'x64'

Fixes: https://github.com/libuv/libuv/issues/705
PR-URL: https://github.com/libuv/libuv/pull/706
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail

build: map 'AMD64' host arch to 'x64'

Fixes: https://github.com/libuv/libuv/issues/705
PR-URL: https://github.com/libuv/libuv/pull/706
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

show more ...

test: use uv_loop_close and assert its result

uv_loop_delete is considered deprecated.

PR-URL: https://github.com/libuv/libuv/pull/696
Reviewed-By: Saúl Ibarra Corretgé <saghul@

test: use uv_loop_close and assert its result

uv_loop_delete is considered deprecated.

PR-URL: https://github.com/libuv/libuv/pull/696
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

show more ...

test,win: fix compilation warning

PR-URL: https://github.com/libuv/libuv/pull/700
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

build,win: remove unneeded condition from GYP file

The file itself contains include guards, so don't compile it
conditionally.

PR-URL: https://github.com/libuv/libuv/pull/697

build,win: remove unneeded condition from GYP file

The file itself contains include guards, so don't compile it
conditionally.

PR-URL: https://github.com/libuv/libuv/pull/697
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

show more ...

build,win: print the Visual Studio version in use

PR-URL: https://github.com/libuv/libuv/pull/698
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

win: fix watching root files

When passing "\\?\C:" to CreateFile, it opens the drive rather than the root
directory. So include the trailing backslash in the directory name.

Fix

win: fix watching root files

When passing "\\?\C:" to CreateFile, it opens the drive rather than the root
directory. So include the trailing backslash in the directory name.

Fixes: https://github.com/nodejs/node/issues/4643
PR-URL: https://github.com/libuv/libuv/pull/689
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

show more ...