643c9e9c | 31-Mar-2016 |
Santiago Gimeno |
process: close process pipes safely Use `uv__close__nocheckstdio` instead of `close`. PR-URL: https://github.com/libuv/libuv/pull/798 Reviewed-By: Ben Noordhuis <info@bnoordhuis
process: close process pipes safely Use `uv__close__nocheckstdio` instead of `close`. PR-URL: https://github.com/libuv/libuv/pull/798 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
6ae622b0 | 22-Mar-2016 |
Imran Iqbal |
aix: do not store absolute path to ahafs We only need the absolute path to create our .mon file under /aha. So only duplicate the passed string. This keeps behaviour similar to other
aix: do not store absolute path to ahafs We only need the absolute path to create our .mon file under /aha. So only duplicate the passed string. This keeps behaviour similar to other platforms. Fixes test fs_event_getpath. PR-URL: https://github.com/libuv/libuv/pull/776 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
a117fbd1 | 22-Mar-2016 |
Imran Iqbal |
aix: fix ahafs implementation uv__makedir_p was not processing all directories in passed string. Now if a directory already exists (EEXIST) it simply moves onto the next directory in
aix: fix ahafs implementation uv__makedir_p was not processing all directories in passed string. Now if a directory already exists (EEXIST) it simply moves onto the next directory in the provided string. Fixed bogus assert in uv__ahafs_event. PR-URL: https://github.com/libuv/libuv/pull/776 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
2d643788 | 31-Mar-2016 |
Ben Noordhuis |
test: use %ld for printing uid/gid The uid and gid fields in uv_passwd_t are of type long so use %ld for printing them. Fixes two -Wformat compiler warnings. PR-URL: https://gi
test: use %ld for printing uid/gid The uid and gid fields in uv_passwd_t are of type long so use %ld for printing them. Fixes two -Wformat compiler warnings. PR-URL: https://github.com/libuv/libuv/pull/797 Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
1c0281e3 | 29-Mar-2016 |
Santiago Gimeno |
process: fix uv_spawn edge-case It can happen that the `parent` end of the `signal_pipe` is given a STDIO file descriptor, so closing it using `uv__close` fails. This problem is
process: fix uv_spawn edge-case It can happen that the `parent` end of the `signal_pipe` is given a STDIO file descriptor, so closing it using `uv__close` fails. This problem is happening when running the `spawn_closed_process_io` test in `SmartOS`. The reason being that when creating a socketpair in `uv__process_init_stdio`, the `Illumos` implementation uses 3 sockets: one is used as a listener, and the other 2 represent both ends of the pipe. The listener socket is closed once the pipe is created. In the test, the listener socket is assigned to the `0` fd, as it is the first free fd in the system. So the fd `0` remained free after the call to `socketpair`. Afterwards, when creating the `signal_pipe`, the fd `0` is being assigned again, so closing it with `uv__close` made the test fail. This issue is not happening in the other unixes because `socketpair` doesn't use 3 fd's, but only 2. To solve the issue, a new `uv__close__nocheckstdio()` function has been added and used. PR-URL: https://github.com/libuv/libuv/pull/796 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
217f81b6 | 01-Mar-2016 |
cjihrig |
unix,win: add uv_get_passwd() This commit adds the uv_get_passwd() function, which returns a subset of the current effective user's password file entry. Refs: https://github.com
unix,win: add uv_get_passwd() This commit adds the uv_get_passwd() function, which returns a subset of the current effective user's password file entry. Refs: https://github.com/libuv/libuv/issues/11 Fixes: https://github.com/libuv/libuv/issues/731 PR-URL: https://github.com/libuv/libuv/pull/742 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
27aa81fe | 25-Mar-2016 |
Ben Noordhuis |
aix: fix 'POLLRDHUP undeclared' build error AIX doesn't have POLLRDHUP. Fixes the following compile-time error: src/unix/core.c: In function 'uv__io_start': src/unix/co
aix: fix 'POLLRDHUP undeclared' build error AIX doesn't have POLLRDHUP. Fixes the following compile-time error: src/unix/core.c: In function 'uv__io_start': src/unix/core.c:831:40: error: 'POLLRDHUP' undeclared assert(0 == (events & ~(UV__POLLIN | UV__POLLOUT | UV__POLLRDHUP))); Fixes: https://github.com/libuv/libuv/issues/783 PR-URL: https://github.com/libuv/libuv/pull/785 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
show more ...
|
13f4dc82 | 24-Mar-2016 |
cjihrig |
test: add missing copyright header This commit adds the copyright header to the two tests that were missing it. PR-URL: https://github.com/libuv/libuv/pull/782 Reviewed-By:
test: add missing copyright header This commit adds the copyright header to the two tests that were missing it. PR-URL: https://github.com/libuv/libuv/pull/782 Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
02709a94 | 07-Mar-2016 |
Kári Tristan Helgason |
unix: use open(2) with O_CLOEXEC on OS X PR-URL: https://github.com/libuv/libuv/pull/753 Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com> |
757e3c60 | 26-Jan-2016 |
Joran Dirk Greef |
win: fix uv_relative_path and remove dead branch wcslen() returns a size_t, not an int. Add bounds checking to dirlen to avoid undefined if dirlen is 0. Cache relpath size
win: fix uv_relative_path and remove dead branch wcslen() returns a size_t, not an int. Add bounds checking to dirlen to avoid undefined if dirlen is 0. Cache relpath size calculation to replace redundant (- 1 + 1) expression while still showing workings. Change uv_relative_path return type to void and remove dead code which branched on the return value. PR-URL: https://github.com/libuv/libuv/pull/699 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
b44abe20 | 26-Jan-2016 |
Joran Dirk Greef |
win: fix buffer overflow in fs events When converting an absolute path to a relative path on Windows, uv_relative_path assumed that the relative path could be no longer than MAX_PATH
win: fix buffer overflow in fs events When converting an absolute path to a relative path on Windows, uv_relative_path assumed that the relative path could be no longer than MAX_PATH characters, and would allocate a buffer of MAX_PATH characters for the relative path. However, where a recursive watch is started for a directory using a UNC path, and where events within that directory occur for pathnames longer than MAX_PATH, it is possible for the relative path to exceed MAX_PATH characters and overflow the buffer. This commit fixes uv_relative_path to allocate a buffer for the exact number of characters counted in the relative path. Fixes: https://github.com/libuv/libuv/issues/693 PR-URL: https://github.com/libuv/libuv/pull/699 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
60db5b5a | 23-Mar-2016 |
Saúl Ibarra Corretgé |
win,build: remove unused build defines PR-URL: https://github.com/libuv/libuv/pull/777 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> |
b12624c1 | 20-Mar-2016 |
Ben Noordhuis |
unix: retry ioctl(TIOCGWINSZ) on EINTR Some platforms (notably Solaris) can fail in this ioctl() if interrupted by a signal. Retry the system call when that happens. Fixes: htt
unix: retry ioctl(TIOCGWINSZ) on EINTR Some platforms (notably Solaris) can fail in this ioctl() if interrupted by a signal. Retry the system call when that happens. Fixes: https://github.com/nodejs/node/issues/5737 PR-URL: https://github.com/libuv/libuv/pull/772 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
show more ...
|
df961637 | 16-Mar-2016 |
Ben Noordhuis |
doc: clarify uv_loop_close() Make explicit that handles and requests should be closed before calling uv_loop_close(). Fixes: https://github.com/libuv/libuv/issues/765 Review
doc: clarify uv_loop_close() Make explicit that handles and requests should be closed before calling uv_loop_close(). Fixes: https://github.com/libuv/libuv/issues/765 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
f04d5fc3 | 14-Mar-2016 |
cjihrig |
win: use native APIs for UTF conversions This commit replaces uv_utf16_to_utf8() and uv_utf8_to_utf16() with calls to the native Windows API equivalents. Refs: https://github.co
win: use native APIs for UTF conversions This commit replaces uv_utf16_to_utf8() and uv_utf8_to_utf16() with calls to the native Windows API equivalents. Refs: https://github.com/libuv/libuv/pull/672#discussion_r49049746 PR-URL: https://github.com/libuv/libuv/pull/762 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
5dc15cc2 | 20-Feb-2016 |
Yuval Brik |
fs: realpath: fix string size before converting fs__realpath_handle() removes the UNC prefixes \\?\ and \\?\UNC\ from paths returned by GetFinalPathNameByHandle, but doesn't update t
fs: realpath: fix string size before converting fs__realpath_handle() removes the UNC prefixes \\?\ and \\?\UNC\ from paths returned by GetFinalPathNameByHandle, but doesn't update the string length before sending it to fs__wide_to_utf8. Fix that by decrement the correct size from the string length. PR-URL: https://github.com/libuv/libuv/pull/733 Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
c7c8e916 | 11-Jan-2016 |
Santiago Gimeno |
poll: add UV_DISCONNECT event It allows detecting the remote socket closing the connection. It's emitted when `EPOLLRDHUP`(Linux), `EV_EOF`(BSD), `POLLRDHUP`(Solaris, AIX) and `AFD_P
poll: add UV_DISCONNECT event It allows detecting the remote socket closing the connection. It's emitted when `EPOLLRDHUP`(Linux), `EV_EOF`(BSD), `POLLRDHUP`(Solaris, AIX) and `AFD_POLL_DISCONNECT`(Windows) events are received. PR-URL: https://github.com/libuv/libuv/pull/691 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
42ebae18 | 10-Mar-2016 |
Saúl Ibarra Corretgé |
linux: fix error checking in uv__open_file uv__open_cloexec returns either the fd or a libuv error, which is -errno on Unix, not -1. PR-URL: https://github.com/libuv/libuv/pull/
linux: fix error checking in uv__open_file uv__open_cloexec returns either the fd or a libuv error, which is -errno on Unix, not -1. PR-URL: https://github.com/libuv/libuv/pull/760 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com>
show more ...
|
213e681a | 09-Mar-2016 |
Imran Iqbal |
test: fix poll_bad_fdtype for AIX PR-URL: https://github.com/libuv/libuv/pull/757 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com> |
86051a49 | 08-Mar-2016 |
Saúl Ibarra Corretgé |
win: remove duplicated code when processing fsevents PR-URL: https://github.com/libuv/libuv/pull/756 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig
win: remove duplicated code when processing fsevents PR-URL: https://github.com/libuv/libuv/pull/756 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
show more ...
|
365bdec4 | 05-Mar-2016 |
Krishnaraj Bhat |
linux: remove redundant call to rewind() It's already called in callee read_times() PR-URL: https://github.com/libuv/libuv/pull/751 Reviewed-By: Saúl Ibarra Corretgé <saghul@gma
linux: remove redundant call to rewind() It's already called in callee read_times() PR-URL: https://github.com/libuv/libuv/pull/751 Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
2f02ae5f | 01-Mar-2016 |
Kári Tristan Helgason |
linux: replace calls to fopen with uv__open_file PR-URL: https://github.com/libuv/libuv/pull/743 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <sa
linux: replace calls to fopen with uv__open_file PR-URL: https://github.com/libuv/libuv/pull/743 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
d7910e42 | 01-Mar-2016 |
Kári Tristan Helgason |
unix: add fork-safe open file function PR-URL: https://github.com/libuv/libuv/pull/743 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail
unix: add fork-safe open file function PR-URL: https://github.com/libuv/libuv/pull/743 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
4972f741 | 07-Mar-2016 |
Saúl Ibarra Corretgé |
doc: add @cjihrig as a maintainer PR-URL: https://github.com/libuv/libuv/pull/752 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-by: Bert Belder <bertbelder@gmail.com>
doc: add @cjihrig as a maintainer PR-URL: https://github.com/libuv/libuv/pull/752 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-by: Bert Belder <bertbelder@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com>
show more ...
|
80d9d86e | 05-Mar-2016 |
Kári Tristan Helgason |
linux: add braces to multi-statement if PR-URL: https://github.com/libuv/libuv/pull/750 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmai
linux: add braces to multi-statement if PR-URL: https://github.com/libuv/libuv/pull/750 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|