unix: make uv_poll_stop() remove fd from pollset

Avoid repeated wake-ups in `uv__io_poll()` when the previously watched
file descriptor has been duplicated (with `dup(2)`) and then close

unix: make uv_poll_stop() remove fd from pollset

Avoid repeated wake-ups in `uv__io_poll()` when the previously watched
file descriptor has been duplicated (with `dup(2)`) and then closed.

Because epoll reports events for _file descriptions_ rather than _file
descriptors_, events on the duplicated file descriptor cause the event
loop to wake up.

Libuv then tries to unregister the event listener for the original file
descriptor but that fails with EBADF because the file descriptor is
closed.

Since libuv uses epoll in level-triggered mode, it effectively results
in a busy loop because the event is re-reported as soon as libuv calls
epoll_wait() again.

I tried hard to write a test case for this but there is no directly
observable behavior, only increased CPU usuage.

Fixes: https://github.com/libuv/libuv/issues/1148
PR-URL: https://github.com/libuv/libuv/pull/1468
Reviewed-By: Colin Ihrig <cjihrig@gmail.com
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

show more ...

doc: differentiate SmartOS and SunOS support

Refs: https://github.com/libuv/libuv/pull/991
Refs: https://github.com/libuv/libuv/issues/1458
PR-URL: https://github.com/libuv/libuv/pul

doc: differentiate SmartOS and SunOS support

Refs: https://github.com/libuv/libuv/pull/991
Refs: https://github.com/libuv/libuv/issues/1458
PR-URL: https://github.com/libuv/libuv/pull/1469
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

show more ...

win: allow bound/connected socket in uv_tcp_open()

On Unix you can pass bound and even connected socket to uv_tcp_open
and it will work as expected: you can run uv_listen or other io

win: allow bound/connected socket in uv_tcp_open()

On Unix you can pass bound and even connected socket to uv_tcp_open
and it will work as expected: you can run uv_listen or other io
functions (uv_read, uv_write) on it without problems.
On windows on the other hand the function always assumes to have clean
socket and for example uv_listen will try to bind it again, and
uv_read/write will return with errors about unreadable streams
(basically invalid internal flags).

To check if socket is already bound uv_tcp_getsockname is called which
on windows returns error when socket is unbound. To further
differentiate connected one from just bound, uv_tcp_getpeername also
returns error but when target socket is not connected.

PR-URL: https://github.com/libuv/libuv/pull/1447
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

show more ...

zos: read more accurate rss info from RSM

More accurate Resident Set Size (Central Storage size on Z)
is stored in the MVS Data Areas managed by the RSM (Real
Storage Manager).

zos: read more accurate rss info from RSM

More accurate Resident Set Size (Central Storage size on Z)
is stored in the MVS Data Areas managed by the RSM (Real
Storage Manager).

PR-URL: https://github.com/libuv/libuv/pull/1244
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

show more ...

android: fix blocking recvmsg due to netlink bug

Code was assuming that the nl_pid was always equal to the process id.
As the netlink documentation says, "nl_pid is usually the PID of th

android: fix blocking recvmsg due to netlink bug

Code was assuming that the nl_pid was always equal to the process id.
As the netlink documentation says, "nl_pid is usually the PID of the
process owning the destination socket. However, nl_pid identifies a
netlink socket, not a process".

There are two cases in which this assumption breaks down. The first is
that some other part of the application has already bound a netlink
socket with a nl_pid equal to the PID of the process. The second is
Android version 5.0 where it appears that nl_pid is not always defaulted
to the PID of the process.

The result of this bad assumption is that netlink message responses to
our request are ignored due to having a bad nl_pid. We eventually run
out of messages on the netlink socket and block forever awaiting our
response.

PR-URL: https://github.com/libuv/libuv/pull/1451
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

show more ...

zos: fix hr timer resolution

One tick on the high resolution clock (TOD clock) on z/OS
is equivalent to (1/4.096) nanoseconds.

PR-URL: https://github.com/libuv/libuv/pull/1453

zos: fix hr timer resolution

One tick on the high resolution clock (TOD clock) on z/OS
is equivalent to (1/4.096) nanoseconds.

PR-URL: https://github.com/libuv/libuv/pull/1453
Reviewed-By: Colin Ihrig <cjihrig@gmail.com
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

show more ...

test,zos: use gid=-1 to test spawn_setgid_fails

This is because on some platforms like z/OS, setgid(0) is
allowed for non-superusers. So instead, use setgid(-1) to
get UV_EINVAL to t

test,zos: use gid=-1 to test spawn_setgid_fails

This is because on some platforms like z/OS, setgid(0) is
allowed for non-superusers. So instead, use setgid(-1) to
get UV_EINVAL to test that spawn failure returns the right
return code.

PR-URL: https://github.com/libuv/libuv/pull/1456
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

show more ...

test,zos: skip chown root test

z/OS allows non root users to chown a file to root via the
CHOWN.UNRESTRICTED profile. So avoid that test on z/OS.

PR-URL: https://github.com/libu

test,zos: skip chown root test

z/OS allows non root users to chown a file to root via the
CHOWN.UNRESTRICTED profile. So avoid that test on z/OS.

PR-URL: https://github.com/libuv/libuv/pull/1454
Reviewed-By: Colin Ihrig <cjihrig@gmail.com
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

show more ...

doc: update supported windows version baseline

Update the baseline from Windows XP SP1 to Windows 8.1

PR-URL: https://github.com/libuv/libuv/pull/1436
Reviewed-By: Colin Ihrig <

doc: update supported windows version baseline

Update the baseline from Windows XP SP1 to Windows 8.1

PR-URL: https://github.com/libuv/libuv/pull/1436
Reviewed-By: Colin Ihrig <cjihrig@gmail.com
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

show more ...

win, test: fix double close in test runner

Fixes: https://github.com/libuv/libuv/issues/1426
Credit: Tom Seddon <github@tomseddon.plus.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.co

win, test: fix double close in test runner

Fixes: https://github.com/libuv/libuv/issues/1426
Credit: Tom Seddon <github@tomseddon.plus.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

show more ...

unix: add missing semicolon

PR-URL: https://github.com/libuv/libuv/pull/1444
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com

unix: add missing semicolon

PR-URL: https://github.com/libuv/libuv/pull/1444
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

show more ...

doc: add Android as a tier 3 supported platform

PR-URL: https://github.com/libuv/libuv/pull/1442
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gma

doc: add Android as a tier 3 supported platform

PR-URL: https://github.com/libuv/libuv/pull/1442
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

show more ...

doc: document uv_async_(init|send) return values

Fixes: https://github.com/libuv/libuv/issues/576
PR-URL: https://github.com/libuv/libuv/pull/1435
Reviewed-By: Colin Ihrig <cjihrig@g

doc: document uv_async_(init|send) return values

Fixes: https://github.com/libuv/libuv/issues/576
PR-URL: https://github.com/libuv/libuv/pull/1435
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

show more ...

win, process: support semicolons in PATH variable

Fixes a bug that would cause libuv to crash when PATH environment
variable contained paths with semicolon in it

Refs: https://g

win, process: support semicolons in PATH variable

Fixes a bug that would cause libuv to crash when PATH environment
variable contained paths with semicolon in it

Refs: https://github.com/nodejs/help/issues/728
Fixes: https://github.com/libuv/libuv/issues/1422
PR-URL: https://github.com/libuv/libuv/pull/1438
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

show more ...

doc: update instructions for building on Android

PR-URL: https://github.com/libuv/libuv/pull/1441
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gm

doc: update instructions for building on Android

PR-URL: https://github.com/libuv/libuv/pull/1441
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

show more ...

android: remove no longer needed check

The latest NDK (r15 at the time of this writing) no longer needs this.
`pthread_cond_timedwait` is available at any (reasonable) API level.

android: remove no longer needed check

The latest NDK (r15 at the time of this writing) no longer needs this.
`pthread_cond_timedwait` is available at any (reasonable) API level.

PR-URL: https://github.com/libuv/libuv/pull/1441
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

show more ...

android: fix detection of pthread_condattr_setclock

It's only available on API level >= 21.

PR-URL: https://github.com/libuv/libuv/pull/1441
Reviewed-By: Ben Noordhuis <info@bno

android: fix detection of pthread_condattr_setclock

It's only available on API level >= 21.

PR-URL: https://github.com/libuv/libuv/pull/1441
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

show more ...

win, fs: support unusual reparse points

Allow for running uv_fs_stat and uv_fs_lstat on all reparse points

Ref: https://github.com/nodejs/node/issues/12737
PR-URL: https://githu

win, fs: support unusual reparse points

Allow for running uv_fs_stat and uv_fs_lstat on all reparse points

Ref: https://github.com/nodejs/node/issues/12737
PR-URL: https://github.com/libuv/libuv/pull/1419
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

show more ...

misc: add android-toolchain to .gitignore

PR-URL: https://github.com/libuv/libuv/pull/1433
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

android: fix compilation with new NDK versions

Fixes compiling with Android NDK when using Unified Headers (default
since r15).

Fixes: https://github.com/libuv/libuv/issues/1417

android: fix compilation with new NDK versions

Fixes compiling with Android NDK when using Unified Headers (default
since r15).

Fixes: https://github.com/libuv/libuv/issues/1417
PR-URL: https://github.com/libuv/libuv/pull/1433
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

show more ...

docs: fix guide source code example paths

Source code examples in the User guide were not appearing in the built
documentation because the relative paths were incorrect.

PR-URL:

docs: fix guide source code example paths

Source code examples in the User guide were not appearing in the built
documentation because the relative paths were incorrect.

PR-URL: https://github.com/libuv/libuv/pull/1428
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

show more ...

misc: remove reference to pthread-fixes.h from LICENSE

PR-URL: https://github.com/libuv/libuv/pull/1432
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjih

misc: remove reference to pthread-fixes.h from LICENSE

PR-URL: https://github.com/libuv/libuv/pull/1432
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

show more ...

zos: remove nonexistent include from autotools build

PR-URL: https://github.com/libuv/libuv/pull/1432
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihri

zos: remove nonexistent include from autotools build

PR-URL: https://github.com/libuv/libuv/pull/1432
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

show more ...

github: fix link to help repo in issue template

PR-URL: https://github.com/libuv/libuv/pull/1431
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghu

github: fix link to help repo in issue template

PR-URL: https://github.com/libuv/libuv/pull/1431
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

show more ...

win,build: fix building from Windows SDK or VS console

Introduced in
https://github.com/libuv/libuv/commit/2f6d4b4b58ea290961dc983117d31b19e198403a and accidentally undone in
https:/

win,build: fix building from Windows SDK or VS console

Introduced in
https://github.com/libuv/libuv/commit/2f6d4b4b58ea290961dc983117d31b19e198403a and accidentally undone in
https://github.com/libuv/libuv/commit/19c896dd086abb351361eab54b7e88ed5ce8af08.

PR-URL: https://github.com/libuv/libuv/pull/1415
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Refael Ackermann <refack@gmail.com>

show more ...