unix: work around arm-linux-gnueabihf-gcc bug (#4537)

Both gcc 11 and 12 emit wrong code for a function call pointer in one
very specific context.

Fixes: https://github.com/libu

unix: work around arm-linux-gnueabihf-gcc bug (#4537)

Both gcc 11 and 12 emit wrong code for a function call pointer in one
very specific context.

Fixes: https://github.com/libuv/libuv/issues/4532

show more ...

unix,fs: silence -Wunused-result warning (#4496)

darwin: fix crash on iOS(arm64)

Disable sendfile() on iOS with arm64 architecture
to avoid crashes caused by throwing SIGSYS signal.

Fixes: #3187

unix,win: remove unused req parameter from macros (#4435)

Remove the unused `req` parameter from the uv__req_register and
uv__req_unregister macros.

aix,ibmi: fix compilation errors in fs_copyfile (#4404)

On IBM AIX (and PASE for IBM i), use st_timespec_t
when _XOPEN_SOURCE>=700 and _ALL_SOURCE is defined.

Signed-off-by: Jef

aix,ibmi: fix compilation errors in fs_copyfile (#4404)

On IBM AIX (and PASE for IBM i), use st_timespec_t
when _XOPEN_SOURCE>=700 and _ALL_SOURCE is defined.

Signed-off-by: Jeffrey H. Johnson <trnsz@pobox.com>

show more ...

linux,darwin: make `uv_fs_copyfile` behaves like `cp -r` (#4396)

This commit changes the timestamps in the file, the ownership and the
group.

Fixes: https://github.com/libuv/lib

linux,darwin: make `uv_fs_copyfile` behaves like `cp -r` (#4396)

This commit changes the timestamps in the file, the ownership and the
group.

Fixes: https://github.com/libuv/libuv/issues/3125

Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>

show more ...

unix: reinstate preadv/pwritev fallback code (#4345)

I removed the fallback code back in October but it prevents Node.js
from upgrading libuv in their v20.x release line because they sup

unix: reinstate preadv/pwritev fallback code (#4345)

I removed the fallback code back in October but it prevents Node.js
from upgrading libuv in their v20.x release line because they support
systems older than we do. Bring back a dlsym-based fallback path.

Fixes: https://github.com/libuv/libuv/issues/4332

show more ...

unix,fs: fix realpath calls that use the system allocator

Make sure we allocate the memory with uv__malloc so it's in turn freed
with uv__free.

Fixes: https://github.com/libuv/l

unix,fs: fix realpath calls that use the system allocator

Make sure we allocate the memory with uv__malloc so it's in turn freed
with uv__free.

Fixes: https://github.com/libuv/libuv/issues/4329

show more ...

linux: retry fs op if unsupported by io_uring (#4268)

Fallback to the threadpool if it returns `EOPNOTSUPP`.

Fixes: https://github.com/nodejs/node/issues/50876

unix: correct pwritev conditional (#4233)

unix: unbreak macOS < 10.14 (#4230)

unix: no preadv/pwritev workaround if not needed (#4180)

The workaround for preadv/pwritev is needed only
for Solaris, not illumos, so avoid it on illumos.

Haiku R1/prebeta5 (an

unix: no preadv/pwritev workaround if not needed (#4180)

The workaround for preadv/pwritev is needed only
for Solaris, not illumos, so avoid it on illumos.

Haiku R1/prebeta5 (and later) provide preadv and
pwritev, so only use workaround on lower versions.

Signed-off-by: Jeffrey H. Johnson <trnsz@pobox.com>

show more ...

unix: merge read/write code into single functions

I split those out in a previous commit in anticipation of changes that
never came. Let's merge them back.

unix: rename variable for consistency

uv__fs_write_do() calls it `r` so call it that in `uv__fs_read_do()`
too.

unix: add back preadv/pwritev fallback

Implement in terms of pread/pwrite and only try to read/write the first
buffer. Callers are supposed to handle partial reads and libuv takes
ca

unix: add back preadv/pwritev fallback

Implement in terms of pread/pwrite and only try to read/write the first
buffer. Callers are supposed to handle partial reads and libuv takes
care of partial writes.

(Our own fs_read_bufs test doesn't but that's fine because this commit
is a fix-up for unsupported platforms that aren't in our CI matrix.)

Fixes: https://github.com/libuv/libuv/issues/4176

show more ...

unix: don't malloc on sync uv_fs_read (#4162)

We can use the |bufs| argument directly instead of always copying it
and sometimes heap-allocating it.

The same trick doesn't work

unix: don't malloc on sync uv_fs_read (#4162)

We can use the |bufs| argument directly instead of always copying it
and sometimes heap-allocating it.

The same trick doesn't work for uv_fs_write() because the iterator
mutates the buffers in the list and that's visible to the caller.

Fixes: https://github.com/libuv/libuv/issues/4038

show more ...

darwin: remove workaround for data corruption bug

XNU kernels anno ~2010 had a data corrruption bug where concurrent
write and pwrite calls sometimes resulted in blocks of zeroes being

darwin: remove workaround for data corruption bug

XNU kernels anno ~2010 had a data corrruption bug where concurrent
write and pwrite calls sometimes resulted in blocks of zeroes being
written instead of the actual data.

Libuv works around that by serializing all writes with a process-wide
mutex, meaning oncurrent writes (for all files, not just single files)
have a concurrency of 1. Obviously that's not great for performance.

Modern day macOS no longer has this bug, so remove the workaround.

show more ...

unix: remove pwrite/pwritev conditionals

unix: remove pread/preadv conditionals

unix: fix build for lower versions of Android (#4046)

Available since Android N (API level 24): getgrgid_r, preadv, pwritev

Refs: https://cs.android.com/android/platform/superprojec

unix: fix build for lower versions of Android (#4046)

Available since Android N (API level 24): getgrgid_r, preadv, pwritev

Refs: https://cs.android.com/android/platform/superproject/+/master:bionic/docs/status.md

show more ...

unix,fs: make no_pwritev access thread-safe (#4066)

linux: work around io_uring IORING_OP_CLOSE bug (#4059)

Work around a poorly understood bug in older kernels where closing a
file descriptor pointing to /foo/bar results in ETXTBSY error

linux: work around io_uring IORING_OP_CLOSE bug (#4059)

Work around a poorly understood bug in older kernels where closing a
file descriptor pointing to /foo/bar results in ETXTBSY errors when
trying to execve("/foo/bar") later on.

The bug seems to have been fixed somewhere between 5.15.85 and 5.15.90.
I couldn't pinpoint the responsible commit but good candidates are the
several data race fixes.

Interestingly, it seems to manifest only when running under Docker so
the possibility of a Docker bug can't be completely ruled out either.

This commit moves uv__kernel_version() from fs.c to linux.c because the
latter now uses it more than the former.

Fixes: https://github.com/nodejs/node/issues/48444

show more ...

linux: add some more iouring backed fs ops (#4012)

Specifically: `link`, `mkdir`, `rename`, `symlink` and `unlink`.

docs: fix some typos (#3984)

macos: revert clonefile (#3987)

* Revert "macos: fix source not being followed when cloning (#3941)"

This reverts commit 507f2f950d5da7ab1586a46e81fc83dae10c0138.

* Revert

macos: revert clonefile (#3987)

* Revert "macos: fix source not being followed when cloning (#3941)"

This reverts commit 507f2f950d5da7ab1586a46e81fc83dae10c0138.

* Revert "darwin: bring back macos-specific copyfile(3) (#3654)"

This reverts commit d4eb276eea7cb19a888fe97d7759d97c7092ad02.

show more ...