windows: suppress UI in all CryptAcquireContext() calls

Ref: https://docs.microsoft.com/windows/win32/api/wincrypt/nf-wincrypt-cryptacquirecontexta#parameters
Reviewed-by: Marc Hörsken

windows: suppress UI in all CryptAcquireContext() calls

Ref: https://docs.microsoft.com/windows/win32/api/wincrypt/nf-wincrypt-cryptacquirecontexta#parameters
Reviewed-by: Marc Hörsken
Closes https://github.com/curl/curl/pull/5088

show more ...

writeout_json: add missing comma to fix the HTTP version

Follow-up to 04c03416e68fd635a15

test 970: verify --write-out '%{json}'

Makes curl_easy_getinfo() of "variable" numerical content instead return
the number set in the env variable `CURL_TIME`.

Makes curl_versio

test 970: verify --write-out '%{json}'

Makes curl_easy_getinfo() of "variable" numerical content instead return
the number set in the env variable `CURL_TIME`.

Makes curl_version() of "variable" textual content. This guarantees a
stable version string which can be tested against. Environment variable
`CURL_VERSION` defines the content.

Assisted-by: Mathias Gumz

show more ...

writeout: support to generate JSON output

This commit adds support to generate JSON via the writeout feature:

-w "%{json}"

It leverages the existing infrastructure as m

writeout: support to generate JSON output

This commit adds support to generate JSON via the writeout feature:

-w "%{json}"

It leverages the existing infrastructure as much as possible. Thus,
generating the JSON on STDERR is possible by:

-w "%{stderr}%{json}"

This implements a variant of
https://github.com/curl/curl/wiki/JSON#--write-out-json.

Closes #4870

show more ...

CI: stop ignoring 323, it is disabled

DISABLED: disable test 323

The test uses SRP to "a server not supporting it" but modern stunnel
versions will silently accept it and remain happy. The test is therefore
faulty.

DISABLED: disable test 323

The test uses SRP to "a server not supporting it" but modern stunnel
versions will silently accept it and remain happy. The test is therefore
faulty.

I haven't figured out how to make stunnel explicitly reject SRP-using
connects.

Reported-by: Marc Hörsken
Fixes #5105
Closes #5113

show more ...

ci/tests: increase timeouts for torture builds on Azure Pipelines

For some reason the torture builds have slowed down recently.

Reported-by: Daniel Stenberg

cmake: add support for building with wolfSSL

My working build cmdline:

$ cmake -DCMAKE_PREFIX_PATH=$HOME/build-wolfssl -DCMAKE_USE_WOLFSSL=ON .

Assisted-by: Brad King
C

cmake: add support for building with wolfSSL

My working build cmdline:

$ cmake -DCMAKE_PREFIX_PATH=$HOME/build-wolfssl -DCMAKE_USE_WOLFSSL=ON .

Assisted-by: Brad King
Closes #5095

show more ...

tool_operate: fix add_parallel_transfers when more are in queue

Trying to return early from the function if no new transfers were added
would break the "morep" argument and cause issues.

tool_operate: fix add_parallel_transfers when more are in queue

Trying to return early from the function if no new transfers were added
would break the "morep" argument and cause issues. This could lead to
zero content "transfers" (within quotes since they would never be
started) when parallel-max was reduced.

Reported-by: Gavin Wong
Analyzed-by: Jay Satiro
Fixes #4937
Closes #5112

show more ...

vtls: free ssl_config leftovers on out-of-memory

Torture testing 2034 and 2037 found this.

Reported-by: Marc Hörsken
Fixes #5108
Closes #5109

ci/tests: fix Azure Pipelines not running for pull requests

Closes #5111

gskit: update the copyright year range

Follow-up from 083603c63a3

gskit: use our internal select wrapper for portability

Follow up to c52b342
Closes #5106

tests: fix verification of stdout in test 1452 due to newline

Fixes test1452:41:1: error: missing </stdout> tag before </verify>

ci/tests: install impacket for SMB tests on FreeBSD using CirrusCI

Also force the package index/cache to be updated before installing.

Closes #5103

tests/README: add note about manually installing python-impacket

Follow up to 4be2560

transfer: cap retries of "dead connections" to 5

When libcurl retries a connection due to it being "seemingly dead" or by
REFUSED_STREAM, it will now only do it up five times before givi

transfer: cap retries of "dead connections" to 5

When libcurl retries a connection due to it being "seemingly dead" or by
REFUSED_STREAM, it will now only do it up five times before giving up,
to avoid never-ending loops.

Reported-by: Dima Tisnek
Bug: https://curl.haxx.se/mail/lib-2020-03/0044.html
Closes #5074

show more ...

TODO: TLS-PSK with OpenSSL

Closes #5081

select: add 'timeout_ms' wrap-around precaution to Curl_select

select: fix 'pending_ms' is assigned a value that is never used

Detected by Codacy

select: move duplicate select preparation code into Curl_select

Reviewed by Daniel Stenberg
Reviewed by Marcel Raad
Closes #5078

connect: happy eyeballs cleanup

Make sure each separate index in connn->tempaddr[] is used for a fixed
family (and only that family) during the connection process.

If family one

connect: happy eyeballs cleanup

Make sure each separate index in connn->tempaddr[] is used for a fixed
family (and only that family) during the connection process.

If family one takes a long time and family two fails immediately, the
previous logic could misbehave and retry the same family two address
repeatedly.

Reported-by: Paul Vixie
Reported-by: Jay Satiro
Fixes #5083
Fixes #4954
Closes #5089

show more ...

ci/tests: fix and align setting TFLAGS for make test-nonflaky

ci/tests: install test suite dependencies stunnel and impacket

tests: remove python_dependencies for smbserver from our tree

Users of the SMB tests will have to install impacket manually.

Reasoning: our in-tree version of impacket was quite out

tests: remove python_dependencies for smbserver from our tree

Users of the SMB tests will have to install impacket manually.

Reasoning: our in-tree version of impacket was quite outdated
and only compatible with Python 2 which is already end-of-life.
Upgrading to Python 3 and a compatible impacket version would
require to import additional Python-only and CPython-extension
dependencies. This would have hindered portability enormously.

Closes #5094

show more ...