da94b023 | 25-Sep-2024 |
Daniel Stenberg |
THANKS: cleanup duplicates |
d82f9f96 | 23-Sep-2024 |
Viktor Szakats |
build: add pytest targets It enables running pytests in cmake jobs, regardless of underlying build tool choice (= makes it work with ninja.) Also: - drop pytest logic l
build: add pytest targets It enables running pytests in cmake jobs, regardless of underlying build tool choice (= makes it work with ninja.) Also: - drop pytest logic launching `make` and exiting in case of failure. Maybe there is a better way and keep this functionality somehow, bind it to a command-line option? make it fail softly? - GHA/linux: invoke pytest via the build, not directly. - autotools: add missing dummy runtests targets when cross-compiling. Closes #15034
show more ...
|
ed766751 | 23-Sep-2024 |
Viktor Szakats |
GHA/linux: tidy up msh3 build step Ninja does not improve msh3 build speed on GHA/linux: https://github.com/curl/curl/actions/runs/11020206432/job/30604509300 Cherry-picked from
GHA/linux: tidy up msh3 build step Ninja does not improve msh3 build speed on GHA/linux: https://github.com/curl/curl/actions/runs/11020206432/job/30604509300 Cherry-picked from #15023
show more ...
|
b4cf21b4 | 24-Sep-2024 |
Viktor Szakats |
build: clarify CA embed is for curl tool, mark default, improve summary - say that CA embed is for the curl tool. - show "no" in summary when there is no CA embed. - cmake: sync word
build: clarify CA embed is for curl tool, mark default, improve summary - say that CA embed is for the curl tool. - show "no" in summary when there is no CA embed. - cmake: sync wording. Closes #15035
show more ...
|
73ea09b9 | 23-Sep-2024 |
Viktor Szakats |
GHA/linux: review and prune valgrind use Valgrind jobs are slow, drop it from jobs where its use is redundant and/or has limited impact: - BearSSL: deprecated. - LibreSSL he
GHA/linux: review and prune valgrind use Valgrind jobs are slow, drop it from jobs where its use is redundant and/or has limited impact: - BearSSL: deprecated. - LibreSSL heimdal with autotools. Keep valgrind for the same job with cmake. - msh3. - IntelC no-SSL. Keep valgrind for IntelC OpenSSL. - OpenSSL 3. All OpenSSL jobs are v3 now, keep valgrind for the `-O3`, and libssh2 + sync-resolver variants. Closes #15020
show more ...
|
68a224c2 | 28-Aug-2024 |
Viktor Szakats |
tidy-up: indentation in autotools sources Indentation in `configure.ac` and `.m4` files. Closes #14692 |
b70e8f4b | 22-Sep-2024 |
Gabriel Marin |
cleanup: added space around ternary expressions Closes #14990 |
b7c9166c | 22-Sep-2024 |
Gabriel Marin |
test1185: Updated test data with NOSPACEC rule Closes #14990 |
cff75acf | 20-Sep-2024 |
Gabriel Marin |
checksrc: Added checks for colon operator in ternary expressions Closes #14990 |
635253ca | 24-Sep-2024 |
Ian Spence |
configure: improve help string for some options Closes #15033 |
80257779 | 24-Sep-2024 |
Baruch Siach |
curl_trc: fix build with verbose messages disabled Add empty definition of Curl_trc_ws() to fix this following build error: In file included from sendf.h:29, fr
curl_trc: fix build with verbose messages disabled Add empty definition of Curl_trc_ws() to fix this following build error: In file included from sendf.h:29, from ws.c:35: ws.c: In function 'Curl_ws_accept': curl_trc.h:100:10: error: implicit declaration of function 'Curl_trc_ws'; did you mean 'Curl_trc_ftp'? [-Wimplicit-function-declaration] 100 | Curl_trc_ws(data, __VA_ARGS__); } while(0) | ^~~~~~~~~~~ ws.c:779:5: note: in expansion of macro 'CURL_TRC_WS' 779 | CURL_TRC_WS(data, "WS, using chunk size %zu", chunk_size); | ^~~~~~~~~~~ Closes #15026
show more ...
|
98c7d4b1 | 24-Sep-2024 |
Stefan Eissing |
multi.c: warn/assert on stall only without timer Warn/assert about a possibly stalling transfer only when it has no timeout set. The assertion triggered in test 1540 on loaded C
multi.c: warn/assert on stall only without timer Warn/assert about a possibly stalling transfer only when it has no timeout set. The assertion triggered in test 1540 on loaded CI sometimes. Closes #15028
show more ...
|
336b8ca5 | 24-Sep-2024 |
Viktor Szakats |
GHA/linux: merge AWS-LC workflow Closes #15031 |
820afa2b | 24-Sep-2024 |
Viktor Szakats |
GHA/linux: merge wolfSSL workflow Add wolfSSL builds to cache. Also apply -j4 for the valgrind job (was: -j2). Closes #15030 |
f6036dea | 24-Sep-2024 |
Viktor Szakats |
build: show if CA bundle to embed was found Follow-up to 8a3740bc8e558b9a9d4a652b74cf27a0961d7010 #14059 Closes #15027 |
9b3a7d1e | 23-Sep-2024 |
Viktor Szakats |
GHA/linux: enable test bundles for cmake jobs Test build step speed-up (3x): 18s -> 6s Follow-up to 71cf0d1fca9e1f53524e1545ef0c08d174458d80 #14772 Closes #15022 |
4619b410 | 22-Sep-2024 |
Viktor Szakats |
build: fix possible `-Wformat-overflow` in lib557 with test bundle builds - lib557: suppress `-Wformat-overflow` warning in source. Fixes: ``` lib557.c: In function ‘test_f
build: fix possible `-Wformat-overflow` in lib557 with test bundle builds - lib557: suppress `-Wformat-overflow` warning in source. Fixes: ``` lib557.c: In function ‘test_float_formatting’: lib557.c:1408:37: error: ‘%*f’ directive output of 2147483648 bytes exceeds ‘INT_MAX’ [-Werror=format-overflow=] 1408 | curl_msnprintf(buf, sizeof(buf), "%*f", INT_MIN, 9.1); | ^~~ lib557.c:1408:3: note: ‘curl_msnprintf’ output 2147483649 bytes 1408 | curl_msnprintf(buf, sizeof(buf), "%*f", INT_MIN, 9.1); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` Ref: https://app.circleci.com/pipelines/github/curl/curl/10226/workflows/87642ee9-cda6-4916-8206-c82aac5f595e/jobs/107669?invite=true#step-106-40996_46 The root cause of why this option gets enabled remains undiscovered. Reported-by: Daniel Stenberg Fixes #15008 Follow-up to 71cf0d1fca9e1f53524e1545ef0c08d174458d80 #14772 - build: drop `-Wno-format-overflow` from picky warning list. These options only get used with picky warnings enabled. Follow-up to 145f87b9e89f3a5e287233fe7d3cf57aca23dd8c #14598 - unit1652: suppress in source (and not rely on picky warnings anymore.) Closes #15012
show more ...
|
954bd908 | 22-Sep-2024 |
Viktor Szakats |
CI: improve readability of Circle CI config - move curl configure commands next to each other. - re-order configure options to improve readability. - fold long configure commands.
CI: improve readability of Circle CI config - move curl configure commands next to each other. - re-order configure options to improve readability. - fold long configure commands. Closes #15011
show more ...
|
d48747b2 | 22-Sep-2024 |
Viktor Szakats |
GHA/windows: mark 3023, 3024 flaky for mingw-w64 7.3.0 job They became flaky recently as reported by Testclutch and firsthand observations. It's curious because it only seems to happen i
GHA/windows: mark 3023, 3024 flaky for mingw-w64 7.3.0 job They became flaky recently as reported by Testclutch and firsthand observations. It's curious because it only seems to happen in 7.3.0, but not in the very similar (except non-Unicode) 9.5.0 job. We've found no explanation or reason for them so far. ``` test 3023...[HTTPS GET to localhost, first subject alt name matches, CN does not match (Schannel variant)] 3023: protocol FAILED! There was no content at all in the file log/14/server.input. Server glitch? Total curl failure? Returned: 7 ``` Ref: https://github.com/curl/curl/actions/runs/10871191391/job/30164710777?pr=14918#step:13:4849 ``` test 3024...[HTTPS GET to localhost, last subject alt name matches, CN does not match (Schannel variant)] 3024: protocol FAILED! There was no content at all in the file log/8/server.input. Server glitch? Total curl failure? Returned: 7 ``` Ref: https://github.com/curl/curl/actions/runs/10871191391/job/30164710777?pr=14918#step:13:4713 ``` FAIL 3023: 'HTTPS GET to localhost, first subject alt name matches, CN does not match (Schannel variant)' HTTPS, HTTP GET, PEM certificate FAIL 3024: 'HTTPS GET to localhost, last subject alt name matches, CN does not match (Schannel variant)' HTTPS, HTTP GET, PEM certificate ``` https://github.com/curl/curl/actions/runs/10982991876/job/30491895264?pr=14930#step:14:4914 https://github.com/curl/curl/actions/runs/10871191391/job/30164710777?pr=14918 https://github.com/curl/curl/actions/runs/10841065505/job/30084573629?pr=14859#step:13:5484 https://github.com/curl/curl/actions/runs/10858001821/job/30135376138?pr=14906#step:13:4841 Reported-by: Testclutch Fixes https://github.com/curl/curl/pull/14905#issuecomment-2350772804 Ref: https://github.com/curl/curl/discussions/14854#discussioncomment-10652044 Closes #15006
show more ...
|
7b88bb44 | 22-Sep-2024 |
Viktor Szakats |
cmake: make `test-ci` target skip building dependencies Make `test-ci` not depend on the `testdeps` target. `test-ci` is designed to run curl tests in CI. In CI we build all nec
cmake: make `test-ci` target skip building dependencies Make `test-ci` not depend on the `testdeps` target. `test-ci` is designed to run curl tests in CI. In CI we build all necessary dependencies explicitly beforehand, and they are always ready when calling the `test-ci` step. Thus, it isn't necessary to enforce them via a dependency rule. Dropping it saves redundant work and delay in CI jobs. The `testdeps` dependency should not normally be a problem. It's supposed to be a no-op if those targets are already built. In practice however, it causes a delay and/or an actual rebuild of those dependencies depending on generator (= build tool) used and other factors. As observed in the GHA/windows workflow, the `testdeps` dependency: - with Ninja, causes no delay, and no extra work: https://github.com/curl/curl/actions/runs/10980099984/job/30485440389#step:25:18 - with GNU Make, caused a re-evaluation of `testdeps` targets, but did not actually rebuild them. This re-evaluation took a noticeable time (esp. with non-bundled tests): https://github.com/curl/curl/actions/runs/10980099984/job/30485440155#step:14:11 (with bundles) https://github.com/curl/curl/actions/runs/10973851013/job/30471690331#step:14:11 (w/o bundles) verbose: https://github.com/curl/curl/actions/runs/10980506956/job/30486434629#step:14:13 - with MSBuild, caused a re-evaluation of `testdeps` targets, and triggered a _rebuild_: https://github.com/curl/curl/actions/runs/10980099984/job/30485435968#step:14:19 (with bundles) https://github.com/curl/curl/actions/runs/10973851013/job/30471689714#step:14:19 (w/o bundles) verbose: https://github.com/curl/curl/actions/runs/10980506956/job/30486436368#step:14:48 It's suspected that our use of `-DCMAKE_VS_GLOBALS=TrackFileAccess=false` in CI is contributing to this. This option is supposed to affect incremental builds only. For some reason it affects CI builds too, even though they are not incremental, and no sources are changed between build steps. Reported-by: Aki Sakurai Ref: #14999 Notice that `test-*` targets depending on `testdeps` is NOT sufficient to build everything to run tests, e.g. it misses to build the curl tool, which is essential. This is also true for autotools' `test-ci` target which misses to build libcurl and the curl tool. Perhaps it'd be best to drop `testdeps` as a dependency for _all_ `test-*` targets and make it official to require building dependencies manually. Alternatively these targets could be fixed to rebuild everything necessary to run tests. Closes #15001
show more ...
|
8e7ccfd1 | 22-Sep-2024 |
Viktor Szakats |
CI: add missed updates to the `configure-libssh` job Disable dependency tracking and enable unity + test bundles for the `configure-libssh` job that was missed in earlier commits.
CI: add missed updates to the `configure-libssh` job Disable dependency tracking and enable unity + test bundles for the `configure-libssh` job that was missed in earlier commits. Follow-up to 71cf0d1fca9e1f53524e1545ef0c08d174458d80 #14772 Follow-up to dff66196d0bc52b53a91f59d3972769412f9639b #14975 Closes #15010
show more ...
|
7b75bd52 | 22-Sep-2024 |
Daniel Stenberg |
RELEASE-NOTES: synced bump the pending curl version to 8.11.0 |
b4f7ec71 | 19-Sep-2024 |
Daniel Stenberg |
tool_operate: let --create-dirs work for --dump-header as well Add test 3011 to verify Proposed-by: Montg0mery on github Fixes #14941 Closes #14965 |
44fc2687 | 22-Sep-2024 |
Daniel Stenberg |
tests: libtests and unit tests need explicit #include memdebug ... as otherwise they do not monitor the resource use within the test files - until they are unity built. Closes #
tests: libtests and unit tests need explicit #include memdebug ... as otherwise they do not monitor the resource use within the test files - until they are unity built. Closes #15007
show more ...
|
7307c1a2 | 20-Sep-2024 |
Tatsuhiro Tsujikawa |
gtls: Add P12 format support This change adds P12 format support for GnuTLS backend. Closes #14991 |