6478a36b | 16-Oct-2024 |
Viktor Szakats |
src: guard for double declaration of `curl_ca_embed` in unity builds Seen with curl-for-win linux-musl-from-mac build with gcc 9.2.0. ``` n file included from /Users/runner/work
src: guard for double declaration of `curl_ca_embed` in unity builds Seen with curl-for-win linux-musl-from-mac build with gcc 9.2.0. ``` n file included from /Users/runner/work/curl-for-win/curl-for-win/curl/_x64-linux-musl-bld/src/CMakeFiles/curl.dir/Unity/unity_0_c.c:136: /Users/runner/work/curl-for-win/curl-for-win/curl/_x64-linux-musl-bld/src/tool_ca_embed.c:4:28: warning: redundant redeclaration of 'curl_ca_embed' [-Wredundant-decls] 4 | extern const unsigned char curl_ca_embed[]; | ^~~~~~~~~~~~~ In file included from /Users/runner/work/curl-for-win/curl-for-win/curl/_x64-linux-musl-bld/src/CMakeFiles/curl.dir/Unity/unity_0_c.c:88: /Users/runner/work/curl-for-win/curl-for-win/curl/src/tool_operate.c:107:28: note: previous declaration of 'curl_ca_embed' was here 107 | extern const unsigned char curl_ca_embed[]; | ^~~~~~~~~~~~~ ``` https://github.com/curl/curl-for-win/actions/runs/11192203640/job/31116070669#step:3:4894 Follow-up to 8a3740bc8e558b9a9d4a652b74cf27a0961d7010 #14059 Closes #15307
show more ...
|
adf2b4fa | 16-Oct-2024 |
Daniel Stenberg |
libssh: use CURL_PATH_MAX instead of PATH_MAX Follow-up to facf59c30e9a6a10c4 Reported-by: Viktor Szakats Bug: https://github.com/curl/curl/pull/15285#issuecomment-2416947731
libssh: use CURL_PATH_MAX instead of PATH_MAX Follow-up to facf59c30e9a6a10c4 Reported-by: Viktor Szakats Bug: https://github.com/curl/curl/pull/15285#issuecomment-2416947731 Closes #15309
show more ...
|
7fbcf4b9 | 16-Oct-2024 |
Viktor Szakats |
vquic: fix compiler warning with gcc + MUSL ``` /Users/runner/work/curl-for-win/curl-for-win/curl/lib/vquic/vquic.c: In function 'msghdr_get_udp_gro': /Users/runner/work/curl-for-win
vquic: fix compiler warning with gcc + MUSL ``` /Users/runner/work/curl-for-win/curl-for-win/curl/lib/vquic/vquic.c: In function 'msghdr_get_udp_gro': /Users/runner/work/curl-for-win/curl-for-win/curl/lib/vquic/vquic.c:344: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas] 344 | #pragma clang diagnostic push | /Users/runner/work/curl-for-win/curl-for-win/curl/lib/vquic/vquic.c:345: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas] 345 | #pragma clang diagnostic ignored "-Wsign-compare" | /Users/runner/work/curl-for-win/curl-for-win/curl/lib/vquic/vquic.c:346: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas] 346 | #pragma clang diagnostic ignored "-Wcast-align" | /Users/runner/work/curl-for-win/curl-for-win/curl/lib/vquic/vquic.c:350: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas] 350 | #pragma clang diagnostic pop | ``` https://github.com/curl/curl-for-win/actions/runs/11356281008/job/31587180874#step:3:9534 Follow-up to a571afc02e11c1ab9a9f59c2150e11acca423fcc #14012 Closes #15303
show more ...
|
facf59c3 | 15-Oct-2024 |
Daniel Stenberg |
libssh2: use the filename buffer when getting the homedir Avoids having to use a big stack buffer for this. Closes #15285 |
083b4ab6 | 13-Oct-2024 |
Daniel Stenberg |
libssh2: put the readdir buffers into struct ... instead of separate malloc() calls: - removes two mallocs (and associated error handling paths) - makes cleanup easier
libssh2: put the readdir buffers into struct ... instead of separate malloc() calls: - removes two mallocs (and associated error handling paths) - makes cleanup easier Also reduce maximum SFTP file path lengths to 1024 bytes universally everywhere. Using the system's own MAX_PATH did not make sense since this is mostly about getting a remote file name. Closes #15285
show more ...
|
1cf187a4 | 15-Oct-2024 |
renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> |
CI: update GHA dependencies - update Mbed-TLS/mbedtls to v3.6.2 - update libressl-portable/portable to v4 - update github/codeql-action digest to f779452 Closes #15301 C
CI: update GHA dependencies - update Mbed-TLS/mbedtls to v3.6.2 - update libressl-portable/portable to v4 - update github/codeql-action digest to f779452 Closes #15301 Closes #15299 Closes #15188
show more ...
|
3040971d | 14-Oct-2024 |
Viktor Szakats |
GHA: silence proselint warnings and an error Fix new issues found by `proselint`. Also: - silence this technical warning: ``` :0: DeprecationWarning: /home/runner/.p
GHA: silence proselint warnings and an error Fix new issues found by `proselint`. Also: - silence this technical warning: ``` :0: DeprecationWarning: /home/runner/.proselintrc was found instead of a JSON file. Rename to /home/runner/.proselintrc.json. ``` - fix an input filename. `proselints` fails now if an input file is missing. Reported-by: Jay Satiro Bug: https://github.com/curl/curl/pull/15291#issuecomment-2410505100 Closes #15293
show more ...
|
8403e5a7 | 14-Oct-2024 |
Daniel Stenberg |
tests: fix callback signatures to please UndefinedBehaviorSanitizer Make test applications use the correct prototypes for callbacks. Closes #15289 |
eed3c8f4 | 14-Oct-2024 |
Daniel Stenberg |
curl.h: remove the struct pointer for CURL/CURLSH/CURLM typedefs It makes the callbacks get different signnatures when used from within libcurl vs outside of it by libcurl-using applicat
curl.h: remove the struct pointer for CURL/CURLSH/CURLM typedefs It makes the callbacks get different signnatures when used from within libcurl vs outside of it by libcurl-using applications (such as the libtests) and this triggers UndefinedBehaviorSanitizer errors. Closes #15289
show more ...
|
ad1c49bc | 14-Oct-2024 |
Daniel Stenberg |
lib: remove function pointer typecasts for hmac/sha256/md5 Make sure we use functions with the correct prototype. Closes #15289 |
335d3257 | 14-Oct-2024 |
Michael Kaufmann |
conncache: More efficient implementation of cpool_remove_bundle Closes #15292 |
e20b139a | 14-Oct-2024 |
Viktor Szakats |
GHA/linux: add cmake job for system mbedTLS with pkg-config Add a build-only cmake job with system mbedTLS package and `pkg-config` enabled. Ubuntu 24.04 comes with mbedTLS 2.28.8 which
GHA/linux: add cmake job for system mbedTLS with pkg-config Add a build-only cmake job with system mbedTLS package and `pkg-config` enabled. Ubuntu 24.04 comes with mbedTLS 2.28.8 which supports `pkg-config`. Follow-up to 7bab201abe3915a0167c002f9308950cb8a06e4b #15193 Closes #15286
show more ...
|
e33cf006 | 14-Oct-2024 |
Daniel Stenberg |
server/mqttd: fix two memory leaks Closes #15290 |
8ea120f6 | 14-Oct-2024 |
Viktor Szakats |
GHA/linux: fixup pip for Ubuntu 24.04 `ubuntu-latest` became `ubuntu-24.04` today. Closes #15287 |
69bf530d | 13-Oct-2024 |
Daniel Stenberg |
tool_operate: make --skip-existing work for --parallel Reported-by: Tobias Wendorff Fixes #15261 Closes #15283 |
9bee39bf | 12-Oct-2024 |
Daniel Stenberg |
url: use same credentials on redirect Previously it could lose the username and only use the password. Added test 998 and 999 to verify. Reported-by: Tobias Bora Fixes
url: use same credentials on redirect Previously it could lose the username and only use the password. Added test 998 and 999 to verify. Reported-by: Tobias Bora Fixes #15262 Closes #15282
show more ...
|
eb77297c | 13-Oct-2024 |
Daniel Stenberg |
lib: move curl_path.[ch] into vssh/ As this contains code only used by SSH backends. Closes #15284 |
a7ccd026 | 05-Sep-2024 |
Stefan Eissing |
ftp: move listen handling to socket filter Move the listen/accept handling of the FTP active data connection into the socket filter and monitor 'connected' status of that as with pas
ftp: move listen handling to socket filter Move the listen/accept handling of the FTP active data connection into the socket filter and monitor 'connected' status of that as with passive connections - more or less. The advantage is that the socket filter now reports being connected only when the server has actually called and accept() has been done. This enables to bootstrap the filter chain on the data connection just like any other. A require SSL filter can then be added right at the start and does not need to be patched in later. Still, the active connection keeps on needing special handling in ftp.c as the control connection needs to be monitored while waiting as the server might send error responses this way. So, things did not turn out quite as squeaky clean as hoped for, but still seems better to do that way. Closes #14798
show more ...
|
3455d360 | 10-Oct-2024 |
Stefan Eissing |
mbedTLS: fix handling of TLSv1.3 sessions For TLSv1.3, if supported, observer special return code to retrieve newly arrived session from mbedTLS. Adjust test expectations now th
mbedTLS: fix handling of TLSv1.3 sessions For TLSv1.3, if supported, observer special return code to retrieve newly arrived session from mbedTLS. Adjust test expectations now that TLSv1.3 session resumption works in mbedTLS >= 3.6.0. Based on #14135 by @ad-chaos Closes #15245
show more ...
|
513904c2 | 10-Oct-2024 |
Stefan Eissing |
wolfSSL: fix handling of TLSv1.3 sessions Register a callback to get notified of new SSL sessions by wolfSSL. Remove the explicit session retrieval after handshake, since this does n
wolfSSL: fix handling of TLSv1.3 sessions Register a callback to get notified of new SSL sessions by wolfSSL. Remove the explicit session retrieval after handshake, since this does not work for TLSv1.3. Adjust test expectations now that TLSv1.3 session resumption works in wolfSSL. Closes #15243
show more ...
|
aa43b424 | 07-Oct-2024 |
Stefan Eissing |
curl-rustls.m4: set linker flags to allow rustls build on macos Assisted-by: Viktor Szakats Closes #15175 |
960521d2 | 11-Oct-2024 |
Viktor Szakats |
smb: do not redefine `getpid` on Windows Replace with namespaced local macro `Curl_getpid()`. Redefining symbols can backfire if that symbol is used in system headers, especiall
smb: do not redefine `getpid` on Windows Replace with namespaced local macro `Curl_getpid()`. Redefining symbols can backfire if that symbol is used in system headers, especially with unity build. We haven't seen a fallout in CI or supported envs, but do it anyway for good measure. Bug report: https://datagirl.xyz/posts/wolfssl_curl_w2k.html Closes #15263
show more ...
|
e8a007de | 12-Oct-2024 |
Viktor Szakats |
GHA: optimize test prereq steps - Linux: move test and pytest prereqs right before test run. - returns build phase results faster. - allows skipping steps for jobs that don't nee
GHA: optimize test prereq steps - Linux: move test and pytest prereqs right before test run. - returns build phase results faster. - allows skipping steps for jobs that don't need them. - makes dependencies more transparent. - sync prereq install step names. - use `tests/requirements.txt` more. Closes #15275
show more ...
|
75dfb7b6 | 12-Oct-2024 |
Viktor Szakats |
pytest: include `buildinfo.txt` in the output If present. It aims to provide TextClutch the same build information that `runtests.pl` already is providing. Ref: https:/
pytest: include `buildinfo.txt` in the output If present. It aims to provide TextClutch the same build information that `runtests.pl` already is providing. Ref: https://testclutch.curl.se/static/reports/feature-matrix.html Ref: #15256 Follow-up to 1fdea1684602a1ae2870c67b5f3e8fd34f63da95 #14802 Closes #15279
show more ...
|
66cc0157 | 05-Oct-2024 |
Tal Regev |
GHA/windows: drop vcpkg workaround Reverts 841f42150ae7b9f903cc5d266cec60a8090c0f27 #15133 Closes #15217 |