d6abd49d | 31-May-2024 |
Christian Heusel |
DISTROS: add a link to the list archive Related to https://github.com/curl/curl/discussions/13833 Signed-off-by: Christian Heusel <christian@heusel.eu> Closes #13843 |
beff006a | 30-May-2024 |
Matt Jolly |
autoconf: remove 'deeper' checks for `AC_CHECK_FUNCS` The net effect of the deeper checks is to raise implicit function decls on modern compilers. These checks appear to have be
autoconf: remove 'deeper' checks for `AC_CHECK_FUNCS` The net effect of the deeper checks is to raise implicit function decls on modern compilers. These checks appear to have been added ~20 years ago, relating to an unverifiable claim about HP-UX. Autoconf support for the platform has grown in leaps and bounds since. It didn't cause a real problem here, but when investigating a FP this came up. No evidence has been identified that this was actually broken in the past, and there is no evidence that this is necessary now. `-Werror=implicit-function-declarations` is enabled for both checks; without a working prototype they will both fail regardless. In the second case there will in fact never be a working prototype and therefore it will always fail unconditionally. `AC_CHECK_FUNCS` does effectively the same thing as the removed checks, except it actually defines a dummy prototype to see if it links. If `AC_CHECK_FUNCS` is broken on a given platform we have bigger problems than trying to build cURL. This should also be faster. Bug: https://bugs.gentoo.org/932827 Reviewed-By: Eli Schwartz <eschwartz93@gmail.com> Closes #13830
show more ...
|
acb9effc | 26-May-2024 |
Jay Satiro |
cf-socket: improve SO_SNDBUF update for Winsock - Rename: Curl_sndbufset => Curl_sndbuf_init - Rename: win_update_buffer_size => win_update_sndbuf_size - Save the last set
cf-socket: improve SO_SNDBUF update for Winsock - Rename: Curl_sndbufset => Curl_sndbuf_init - Rename: win_update_buffer_size => win_update_sndbuf_size - Save the last set SO_SNDBUF size to compare against so that we can avoid setsockopt calls every second. This is a follow-up to 0b520e12 which moved the SO_SNDBUF update check into cf-socket. This change improves it further by making the function names easier to understand and reducing the amount of setsockopt calls. Closes https://github.com/curl/curl/pull/13827
show more ...
|
dace891e | 30-May-2024 |
Viktor Szakats |
tidy-up: use consistent casing for Windows directories C:\Windows\System32 Closes #13832 |
30c235f3 | 30-May-2024 |
Viktor Szakats |
GHA: use ubuntu-latest with OmniOS job It's the same as ubuntu-22.04. Also update OmniOS package search link. Closes #13831 |
e838b341 | 12-Feb-2024 |
Ayesh Karunaratne |
GHA: adjust parallel job counts Adjusts the `make -j` flag to match the latest GitHub-hosted runner hardware specs[^1]: - `ubuntu-latest` on 4 CPU cores - `macos-latest` o
GHA: adjust parallel job counts Adjusts the `make -j` flag to match the latest GitHub-hosted runner hardware specs[^1]: - `ubuntu-latest` on 4 CPU cores - `macos-latest` on 3 CPU cores The processor count is ideally obtained from `nproc`, but setting env vars from the current CI yaml files is not possible because they expect literal strings. [^1]: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories Closes #12927
show more ...
|
7d5b0ba3 | 19-May-2024 |
pszlazak <11884243+pszlazak@users.noreply.github.com> |
get.d: clarify the explanation Closes #13706 |
abff12c5 | 29-May-2024 |
Daniel Stenberg |
curl_url_set.md: libcurl only parses :// URLs Make it clearer in the documentation. Closes #13821 |
c8096668 | 29-May-2024 |
Stefan Eissing |
multi: fix multi_wait() timeout handling - determine the actual poll timeout *after* all sockets have been collected. Protocols and connection filters may install new timeouts du
multi: fix multi_wait() timeout handling - determine the actual poll timeout *after* all sockets have been collected. Protocols and connection filters may install new timeouts during collection. - add debug logging to test1533 where the mistake was noticed Reported-by: Matt Jolly Fixes #13782 Closes #13825
show more ...
|
3b9569c3 | 28-May-2024 |
Viktor Szakats |
lib: prefer `var = time(NULL)` over `time(&var)` Following up on previous occurrences showing up as gcc warnings, replace the remaining `time(&var)` calls with `var = time(NULL)`, though
lib: prefer `var = time(NULL)` over `time(&var)` Following up on previous occurrences showing up as gcc warnings, replace the remaining `time(&var)` calls with `var = time(NULL)`, though these aren't specifically causing compiler warnings. These are in the TFTP client code (`lib/tftp.c`), except one which is in a debug branch in `lib/http_aws_sigv4.c`. What's unexplainable is that this patch seems to mitigate TFTP tests often hanging or going into an infinite loop on GHA windows workflows with MSYS2, mingw-w64 and MSVC (Cygwin is unaffected): https://github.com/curl/curl/pull/13599#issuecomment-2119372376 TFTP hangs did not entirely disappear though, so could be unrelated. `time()` docs: https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/time-time32-time64 https://manpages.debian.org/bookworm/manpages-dev/time.2.en.html Follow-up to 58ca0a2f0743a586716ca357c382b29e3f08db69 #13800 Follow-up to d0728c9109629ee82b855b350a4c3f1f52ee61df #13643 Closes #13815
show more ...
|
0b520e12 | 24-May-2024 |
Stefan Eissing |
winsock: move SO_SNDBUF update into cf-socket - Move the code that updates the SO_SNDBUF size for Windows to cf_socket_send. Prior to this change the code was in readwrite_upl
winsock: move SO_SNDBUF update into cf-socket - Move the code that updates the SO_SNDBUF size for Windows to cf_socket_send. Prior to this change the code was in readwrite_upload but the socket filter is the more appropriate place because it applies to all sends. Background: For Windows users SO_SNDBUF (the total per-socket buffer size reserved by Winsock for sends) is updated dynamically by libcurl during the transfer. This is because Windows does not do it automatically for non-blocking sockets and without it the performance of large transfers may suffer. Closes https://github.com/curl/curl/pull/13763
show more ...
|
2b52fe41 | 08-May-2024 |
Jan Venekamp <1422460+jan2000@users.noreply.github.com> |
sectransp: use common code for cipher suite lookup Take advantage of the Curl_cipher_suite_walk_str() and Curl_cipher_suite_get_str() functions introduced in commit fba9afe. Clo
sectransp: use common code for cipher suite lookup Take advantage of the Curl_cipher_suite_walk_str() and Curl_cipher_suite_get_str() functions introduced in commit fba9afe. Closes #13521
show more ...
|
768909d8 | 27-May-2024 |
Matthias Gatto |
aws-sigv4: url encode the canonical path Refactors canon_query, so it could use the encoding part of the function to use it in the path. As the path doesn't encode '/', but enco
aws-sigv4: url encode the canonical path Refactors canon_query, so it could use the encoding part of the function to use it in the path. As the path doesn't encode '/', but encode '=', I had to add some conditions to know If I was doing the query or path encoding. Also, instead of adding a `bool in_path` variable, I use `bool *found_equals` to know if the function was called for the query or path, as found_equals is used only in query_encoding. Test 472 verifies. Reported-by: Alexander Shtuchkin Fixes #13754 Closes #13814 Signed-off-by: Matthias Gatto <matthias.gatto@outscale.com>
show more ...
|
24b66a1d | 28-May-2024 |
Daniel Stenberg |
cd2nroff: use an empty "##" to signal end of .IP sequence Like when we list a series of options and then want to add "normal" text again afterwards. Without this, the indentatio
cd2nroff: use an empty "##" to signal end of .IP sequence Like when we list a series of options and then want to add "normal" text again afterwards. Without this, the indentation level wrongly continues even after the final "##" header, making following text wrongly appear to belong to the header above. Adjusted several curldown files to use this. Fixes #13803 Reported-by: Jay Satiro Closes #13806
show more ...
|
f2842897 | 28-May-2024 |
vvb2060 |
openssl: fix %-specifier in infof() call Closes #13816 |
6946b3a7 | 28-May-2024 |
Daniel Stenberg |
curl: make warnings and other messages aware of terminal width This removes unnecessary line wraps when the terminal is wider than 79 columns and it also makes messages look better in na
curl: make warnings and other messages aware of terminal width This removes unnecessary line wraps when the terminal is wider than 79 columns and it also makes messages look better in narrower terminals. The get_terminal_columns() function is not split out into its own source file. Suggested-by: Elliott Balsley Fixes #13804 Closes #13808
show more ...
|
67b0692f | 28-May-2024 |
Viktor Szakats |
GHA: enable tests 1139, 1177, 1477 on Windows These exclusions came from the AppVeyor CI config, but they do pass now and they are static tests with no flakiness risk. Follow-up
GHA: enable tests 1139, 1177, 1477 on Windows These exclusions came from the AppVeyor CI config, but they do pass now and they are static tests with no flakiness risk. Follow-up to 0914d8aadddac0d1459673d5b7f77e8f3378b22b #13759 Closes #13817
show more ...
|
2368e223 | 13-May-2024 |
Dan Fandrich |
CI: Improve labeler tag detection Also, simplify patterns with a single glob. |
def7d053 | 28-May-2024 |
Viktor Szakats |
GHA: disable TFTP tests in Windows jobs Shot in the dark trying to find out which tests are hanging / going to an infinite loop. The ones failing after 45 minutes (mingw-w64) or
GHA: disable TFTP tests in Windows jobs Shot in the dark trying to find out which tests are hanging / going to an infinite loop. The ones failing after 45 minutes (mingw-w64) or 30 minutes (MSVC). Ref: https://github.com/curl/curl/pull/13599#issuecomment-2119372376
show more ...
|
bb9110a9 | 27-May-2024 |
renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> |
ci: update vmactions/omnios-vm digest to a61ca1e Closes #13801 |
582743f2 | 27-May-2024 |
Daniel Stenberg |
openssl/gnutls: rectify the TLS version checks for QUIC The versions check wrongly complained and return error if the *minimum* version was set to something less than 1.3. QUIC is always
openssl/gnutls: rectify the TLS version checks for QUIC The versions check wrongly complained and return error if the *minimum* version was set to something less than 1.3. QUIC is always TLS 1.3, but that means minimum 1.2 is still fine to ask for. This also renames the local variable to make the mistake harder to make in the future. Regression shipped in 8.8.0 Follow-up to 3210101088dfa3d6a125 Reported-by: fds242 on github Fixes #13799 Closes #13802
show more ...
|
7bbad0c0 | 27-May-2024 |
Stefan Eissing |
gnutls: improve TLS shutdown local ftp upload tests sometimes failed with an invalid TLS record being reported by gnutls. vsftp did log that the shutdown was not regarded as clean, f
gnutls: improve TLS shutdown local ftp upload tests sometimes failed with an invalid TLS record being reported by gnutls. vsftp did log that the shutdown was not regarded as clean, failing the control connection thereafter. These changes make test_31_05 work reliable locally. - on closing the SSL filter, shutdown READ *and* WRITE - on closing, try a receive after shutdown is sent - convert to DEBUGF to CURL_TRC_CF Closes #13790
show more ...
|
70a65e1b | 28-May-2024 |
Daniel Stenberg |
RELEASE-NOTES: synced |
4f558d28 | 27-May-2024 |
Daniel Stenberg |
tests: run with "--trace-config all" to provide even more info in case of problems. Closes #13791 |
59dc9f7e | 20-May-2024 |
Viktor Szakats |
build: untangle `CURLDEBUG` and `DEBUGBUILD` macros `CURLDEBUG` is meant to enable memory tracking, but in a bunch of cases, it was protecting debug features that were supposed to be gua
build: untangle `CURLDEBUG` and `DEBUGBUILD` macros `CURLDEBUG` is meant to enable memory tracking, but in a bunch of cases, it was protecting debug features that were supposed to be guarded with `DEBUGBUILD`. Replace these uses with `DEBUGBUILD`. This leaves `CURLDEBUG` uses solely for its intended purpose: to enable the memory tracking debug feature. Also: - autotools: rely on `DEBUGBUILD` to enable `checksrc`. Instead of `CURLDEBUG`, which worked in most cases because debug builds enable `CURLDEBUG` by default, but it's not accurate. - include `lib/easyif.h` instead of keeping a copy of a declaration. - add CI test jobs for the build issues discovered. Ref: https://github.com/curl/curl/pull/13694#issuecomment-2120311894 Closes #13718
show more ...
|