bf251cc0 | 08-Jul-2024 |
renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> |
GHA: update wolfSSL and mod_h2 - wolfSSL/wolfssl to v5.7.2 - icing/mod_h2 to v2.0.29 Closes #14131 Closes #14148 |
95776c9a | 07-Jul-2024 |
Dominik Piątkowski |
docs: start markdown headers with capital letter where applicable Closes #14115 |
c2e427cc | 10-Jul-2024 |
CMD <80255379+iCMDdev@users.noreply.github.com> |
hostip: skip error check for infallible function call Closes #14147 |
5637ca1a | 10-Jul-2024 |
Daniel Stenberg |
cf-socket: remove two "useless" assignments 'nread' is already -1, no need to assign it again Pointed out by CodeSonar Closes #14145 |
f43adc2c | 09-Jul-2024 |
Viktor Szakats |
cmake: detect `libidn2` also via `pkg-config` Also: - GHA/non-native: install `pkg-config` to detect libidn2 with cmake on NetBSD and FreeBSD. - GHA/non-native: tidy-up `curl -
cmake: detect `libidn2` also via `pkg-config` Also: - GHA/non-native: install `pkg-config` to detect libidn2 with cmake on NetBSD and FreeBSD. - GHA/non-native: tidy-up `curl --version` command if here. Cherry-picked from #14097 Closes #14137
show more ...
|
baa32708 | 09-Jul-2024 |
Viktor Szakats |
build: fix llvm 16 or older + Xcode 15 or newer, and gcc Xcode v15 (2023) or newer requires the built-in macro `__ENVIRONMENT_OS_VERSION_MIN_REQUIRED__`. This macro is missing from m
build: fix llvm 16 or older + Xcode 15 or newer, and gcc Xcode v15 (2023) or newer requires the built-in macro `__ENVIRONMENT_OS_VERSION_MIN_REQUIRED__`. This macro is missing from mainline llvm versions released earlier. llvm v17 introduced it here: https://github.com/llvm/llvm-project/commit/c8e2dd8c6f490b68e41fe663b44535a8a21dfeab This patch defines the missing macro when the necessary conditions align, by using the value via the macro's old name. The issue affected SecureTransport builds: The SecureTransport code, `lib/md4.c` and `lib/md5.c`. Existing gcc versions (as of v14) also don't define this macro, so apply the patch to it as well. Even though gcc is incompatible in other ways, so this isn't fixing an actual curl build case that I could find yet. GHA macOS runner images have llvm v15 pre-installed, which broke builds when building with an affected Xcode: ``` curl/lib/md4.c:80:14: error: '__ENVIRONMENT_OS_VERSION_MIN_REQUIRED__' is not defined, evaluates to 0 [-Werror,-Wundef] (__MAC_OS_X_VERSION_MIN_REQUIRED < 101500)) || \ ^ /Applications/Xcode_15.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.2.sdk/usr/include/AvailabilityInternal.h:40:53: note: expanded from macro '__MAC_OS_X_VERSION_MIN_REQUIRED' #define __MAC_OS_X_VERSION_MIN_REQUIRED __ENVIRONMENT_OS_VERSION_MIN_REQUIRED__ ^ In file included from curl/build/lib/CMakeFiles/libcurl_shared.dir/Unity/unity_0_c.c:250: curl/lib/md5.c:75:14: error: '__ENVIRONMENT_OS_VERSION_MIN_REQUIRED__' is not defined, evaluates to 0 [-Werror,-Wundef] (__MAC_OS_X_VERSION_MIN_REQUIRED < 101500)) || \ ^ /Applications/Xcode_15.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.2.sdk/usr/include/AvailabilityInternal.h:40:53: note: expanded from macro '__MAC_OS_X_VERSION_MIN_REQUIRED' #define __MAC_OS_X_VERSION_MIN_REQUIRED __ENVIRONMENT_OS_VERSION_MIN_REQUIRED__ ^ 2 errors generated. ``` Ref: https://github.com/curl/curl/actions/runs/9811974634/job/27095218578#step:4:20 Cherry-picked from #14097 Closes #14134
show more ...
|
cfd6f43d | 06-Jul-2024 |
Viktor Szakats |
build: tidy up `__builtin_available` feature checks (Apple) - sync detection snippet between autotools and cmake It wasn't causing issues, but it's useful to avoid unnecessary di
build: tidy up `__builtin_available` feature checks (Apple) - sync detection snippet between autotools and cmake It wasn't causing issues, but it's useful to avoid unnecessary differences while debugging. - cmake: limit check to `APPLE`. Ref: b05dc7eb3592305de9fa85640767f3dd2a8d4c93 #14122 Cherry-picked from #14097 Closes #14127
show more ...
|
80fb7c0b | 06-Jul-2024 |
Viktor Szakats |
configure: limit `SystemConfiguration` test to non-c-ares, IPv6 builds The framework this check detects is necessary for the function `SCDynamicStoreCopyProxies()` used in `lib/macos.c`.
configure: limit `SystemConfiguration` test to non-c-ares, IPv6 builds The framework this check detects is necessary for the function `SCDynamicStoreCopyProxies()` used in `lib/macos.c`. Non-c-ares, IPv6-enabled builds touch this codepath. Limit the feature check for builds that actually need it. It brings this in sync with CMake which already worked this way. Cherry-picked from #14097 Closes #14126
show more ...
|
e1f61929 | 06-Jul-2024 |
Viktor Szakats |
configure: fix `SystemConfiguration` detection Before this patch, `SystemConfiguration` detection failed due to this error when compiling the detection snippet: ``` /Applications
configure: fix `SystemConfiguration` detection Before this patch, `SystemConfiguration` detection failed due to this error when compiling the detection snippet: ``` /Applications/Xcode_15.3.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/TargetConditionals.h:140:50: error: missing binary operator before token "(" 140 | #if !defined(__has_extension) || !__has_extension(define_target_os_macros) | ^ ``` Ref: https://github.com/curl/curl/actions/runs/9821817534/job/27117929218#step:6:1079 It occured with gcc-11 when combined with macOS SDK 14.4 and 14.5 (default SDKs in Xcode 15.3 and 15.4 respectively). It did not happen with earlier releases. Despite the failure in `./configure`, `lib/macos.c` compiled with Apple's `TargetConditionals.h` just fine. Turns out that including the `sys/types.h` header before the SDK header fixes the error and makes the detection snippet compile. Cherry-picked from #14097 Closes #14130
show more ...
|
59cadacf | 06-Jul-2024 |
Viktor Szakats |
build: sync warning options between autotools, cmake & compilers - cmake: enable Apple-specific `-Werror=partial-availability` to match autotools. - autotools: enable `-pedant
build: sync warning options between autotools, cmake & compilers - cmake: enable Apple-specific `-Werror=partial-availability` to match autotools. - autotools: enable `-pedantic-errors` with llvm/clang to match gcc and CMake. - autotools: enable `-Werror-implicit-function-declaration` for llvm/clang to match gcc. - cmake: enable `-Werror-implicit-function-declaration` to match autotools. - move `-Wpointer-bool-conversion` from autotools to the local file (`sectransp.c`) it was meant to apply. This way it applies to all build methods. - autotoos: show `CURL_CFLAG_EXTRAS` in the `./configure` summary. (it may contain `-Werror` and/or `-pedentic-errors`.) Cherry-picked from #14097 Closes #14128
show more ...
|
e0fad6e8 | 09-Jul-2024 |
Viktor Szakats |
CI: simplify running curl with DLLs - update `PATH` instead of copying DLLs around. - drop redundant `export` from `export PATH`. - delete ending pathseps. Closes #14143 |
5ab2eda8 | 07-Jul-2024 |
Alex Snast |
wolfssl: use larger error buffer when formatting errors Currently we're using WOLFSSL_MAX_ERROR_SZ to define the error buffer size, this value is user defined which means it can be overw
wolfssl: use larger error buffer when formatting errors Currently we're using WOLFSSL_MAX_ERROR_SZ to define the error buffer size, this value is user defined which means it can be overwritten with -DWOLFSSL_MAX_ERROR_SZ=512 when building wolfssl and this overwrite is not exported to the users of wolfssl. Instead of relying on WOLFSSL_MAX_ERROR_SZ we'll just use a 256 bytes error buffer and use wolfSSL_ERR_error_string_n to fill it thus dropping the dependency on WOLFSSL_MAX_ERROR_SZ altogether. Closes #14114
show more ...
|
65f7fe56 | 09-Jul-2024 |
Viktor Szakats |
CI: bump FreeBSD Python packages Closes #14141 |
b061fa2c | 09-Jul-2024 |
Viktor Szakats |
GHA/curl-for-win: don't run if only another CI was changed Closes #14142 |
eed38de0 | 09-Jul-2024 |
Daniel Stenberg |
RELEASE-NOTES: synced |
46a26f12 | 08-Jul-2024 |
Stefan Eissing |
vtls: replace addsessionid with set_sessionid - deduplicate the code in many tls backends that check for an existing id and delete it before adding the new one - rename ssl_primary
vtls: replace addsessionid with set_sessionid - deduplicate the code in many tls backends that check for an existing id and delete it before adding the new one - rename ssl_primary_config's `sessionid` bool to `cache_session` Closes #14121
show more ...
|
fc84583a | 08-Jul-2024 |
Daniel Stenberg |
test1175: scan libcurl-errors.md, not the generated .3 version Closes #14133 |
3f8066bf | 08-Jul-2024 |
Daniel Stenberg |
test1139: scan .md files instead of .3 ones As they are the canonical sources. It still uses the curl.1 for command line option info. Closes #14132 |
b5a7554d | 09-Jul-2024 |
Stefan Eissing |
cf-socket: remove obsolete recvbuf - recvbuf was never enabled, remove all its code - remove `fdsave`ing the socket as that is not longer needed Closes #14138 |
67cc1e34 | 07-Jul-2024 |
Viktor Szakats |
test1119: adapt for `.md` input Replace logic dealing with `.3` files to handle the Markdown syntax. Follow-up to eefcc1bda4bccd800f5a56a0fe17a2f44a96e88b #12730 Cherry-picked f
test1119: adapt for `.md` input Replace logic dealing with `.3` files to handle the Markdown syntax. Follow-up to eefcc1bda4bccd800f5a56a0fe17a2f44a96e88b #12730 Cherry-picked from #14097 Closes #14125
show more ...
|
efc2c518 | 07-Jul-2024 |
Viktor Szakats |
tests: include current directory when running test Perl commands Necessary to find generated files in the out-of-tree build directory. E.g. `tests/configurehelp.pm`, for tests 1119 and 1
tests: include current directory when running test Perl commands Necessary to find generated files in the out-of-tree build directory. E.g. `tests/configurehelp.pm`, for tests 1119 and 1167. Before this patch macOS autotools builds were failing these two tests due to falling back to the default preprocessor (`cpp`) instead of the actual one configured. Then `cpp` failing to compile Apple SDK headers referenced by curl headers. Cherry-picked from #14097 Closes #14124
show more ...
|
59bc9a1d | 07-Jul-2024 |
Viktor Szakats |
configure: sort feature list, lowercase protocols, use backticks - sort features case-insensitively to match `curl -V` and cmake. `sort -f` is POSIX, but check if it's available anyway
configure: sort feature list, lowercase protocols, use backticks - sort features case-insensitively to match `curl -V` and cmake. `sort -f` is POSIX, but check if it's available anyway. - make protocols lowercase to match `curl -V` and cmake. - replace two outlier `$()` with backticks. Closes #14117
show more ...
|
4ff7f516 | 07-Jul-2024 |
Yedaya Katsman |
variable.md: make example use expand I used double quotes since it seemed required for powershell, so this example works in both (ba)sh and powershell as well as cmd.exe. Closes
variable.md: make example use expand I used double quotes since it seemed required for powershell, so this example works in both (ba)sh and powershell as well as cmd.exe. Closes #14118
show more ...
|
400717e4 | 05-Jul-2024 |
Andy Reitz |
GIT-INFO.md: remove version requirements Keep them in docs/INTERNALS.md Bump lowest perl to 5.8 Closes #14112 |
b05dc7eb | 06-Jul-2024 |
Viktor Szakats |
sectransp: fix `HAVE_BUILTIN_AVAILABLE` checks to not emit warnings `HAVE_BUILTIN_AVAILABLE` is a curl macro set via autotools and cmake. Like other `HAVE_`s it signals availability if d
sectransp: fix `HAVE_BUILTIN_AVAILABLE` checks to not emit warnings `HAVE_BUILTIN_AVAILABLE` is a curl macro set via autotools and cmake. Like other `HAVE_`s it signals availability if defined. SecureTransport code was specifically looking for the value 1, which triggered compiler warnings when the feature was not present. Replace the existing workaround of locally suppressing the compiler warning with using `defined()`. autotools: ``` 767 | #if (CURL_BUILD_MAC_10_13 || CURL_BUILD_IOS_11) && HAVE_BUILTIN_AVAILABLE == 1 | ^~~~~~~~~~~~~~~~~~~~~~ ../../lib/vtls/sectransp.c: In function 'sectransp_connect_step1': ../../lib/vtls/sectransp.c:1140:52: error: "HAVE_BUILTIN_AVAILABLE" is not defined, evaluates to 0 [-Werror=undef] 1140 | #if (CURL_BUILD_MAC_10_13 || CURL_BUILD_IOS_11) && HAVE_BUILTIN_AVAILABLE == 1 | ^~~~~~~~~~~~~~~~~~~~~~ ../../lib/vtls/sectransp.c:1240:52: error: "HAVE_BUILTIN_AVAILABLE" is not defined, evaluates to 0 [-Werror=undef] 1240 | #if (CURL_BUILD_MAC_10_13 || CURL_BUILD_IOS_11) && HAVE_BUILTIN_AVAILABLE == 1 | ^~~~~~~~~~~~~~~~~~~~~~ ../../lib/vtls/sectransp.c: In function 'sectransp_connect_step2': ``` Ref: https://github.com/curl/curl/actions/runs/9815428701/job/27104448045#step:6:499 cmake gcc: ``` 1140 | #if (CURL_BUILD_MAC_10_13 || CURL_BUILD_IOS_11) && HAVE_BUILTIN_AVAILABLE == 1 | ^~~~~~~~~~~~~~~~~~~~~~ /Users/runner/work/curl/curl/lib/vtls/sectransp.c:1240:52: error: "HAVE_BUILTIN_AVAILABLE" is not defined, evaluates to 0 [-Werror=undef] 1240 | #if (CURL_BUILD_MAC_10_13 || CURL_BUILD_IOS_11) && HAVE_BUILTIN_AVAILABLE == 1 | ^~~~~~~~~~~~~~~~~~~~~~ /Users/runner/work/curl/curl/lib/vtls/sectransp.c: In function 'sectransp_connect_step2': /Users/runner/work/curl/curl/lib/vtls/sectransp.c:2231:51: error: "HAVE_BUILTIN_AVAILABLE" is not defined, evaluates to 0 [-Werror=undef] 2231 | #if(CURL_BUILD_MAC_10_13 || CURL_BUILD_IOS_11) && HAVE_BUILTIN_AVAILABLE == 1 | ^~~~~~~~~~~~~~~~~~~~~~ ``` Ref: https://github.com/curl/curl/actions/runs/9815428701/job/27104445425#step:8:355 Cherry-picked from #14097 Closes #14122
show more ...
|