#
6968fb9d |
| 16-Apr-2022 |
Daniel Stenberg |
lib: remove exclamation marks ... from infof() and failf() calls. Make them less attention seeking. Closes #8713
|
#
12246edd |
| 29-Sep-2021 |
Daniel Gustafsson |
lib: avoid fallthrough cases in switch statements Commit b5a434f7f0ee4d64857f8592eced5b9007d83620 inhibits the warning on implicit fallthrough cases, since the current coding of indicati
lib: avoid fallthrough cases in switch statements Commit b5a434f7f0ee4d64857f8592eced5b9007d83620 inhibits the warning on implicit fallthrough cases, since the current coding of indicating fallthrough with comments is falling out of fashion with new compilers. This attempts to make the issue smaller by rewriting fallthroughs to no longer fallthrough, via either breaking the cases or turning switch statements into if statements. lib/content_encoding.c: the fallthrough codepath is simply copied into the case as it's a single line. lib/http_ntlm.c: the fallthrough case skips a state in the state- machine and fast-forwards to NTLMSTATE_LAST. Do this before the switch statement instead to set up the states that we actually want. lib/http_proxy.c: the fallthrough is just falling into exiting the switch statement which can be done easily enough in the case. lib/mime.c: switch statement rewritten as if statement. lib/pop3.c: the fallthrough case skips to the next state in the statemachine, do this explicitly instead. lib/urlapi.c: switch statement rewritten as if statement. lib/vssh/wolfssh.c: the fallthrough cases fast-forwards the state machine, do this by running another iteration of the switch statement instead. lib/vtls/gtls.c: switch statement rewritten as if statement. lib/vtls/nss.c: the fallthrough codepath is simply copied into the case as it's a single line. Also twiddle a comment to not be inside a non-brace if statement. Closes: #7322 See-also: #7295 Reviewed-by: Daniel Stenberg <daniel@haxx.se>
show more ...
|
#
e7416cfd |
| 06-Jul-2021 |
Daniel Stenberg |
infof: remove newline from format strings, always append it - the data needs to be "line-based" anyway since it's also passed to the debug callback/application - it makes info
infof: remove newline from format strings, always append it - the data needs to be "line-based" anyway since it's also passed to the debug callback/application - it makes infof() work like failf() and consistency is good - there's an assert that triggers on newlines in the format string - Also removes a few instances of "..." - Removes the code that would append "..." to the end of the data *iff* it was truncated in infof() Closes #7357
show more ...
|
#
63c76681 |
| 30-Jun-2021 |
Daniel Stenberg |
version: turn version number functions into returning void ... as we never use the return codes from them. Reviewed-by: Daniel Gustafsson Closes #7319
|
#
0c55fbab |
| 17-May-2021 |
Daniel Stenberg |
conn: add 'attach' to protocol handler, make libssh2 use it The libssh2 backend has SSH session associated with the connection but the callback context is the easy handle, so when a conn
conn: add 'attach' to protocol handler, make libssh2 use it The libssh2 backend has SSH session associated with the connection but the callback context is the easy handle, so when a connection gets attached to a transfer, the protocol handler now allows for a custom function to get used to set things up correctly. Reported-by: Michael O'Farrell Fixes #6898 Closes #7078
show more ...
|
#
063d3f3b |
| 19-Apr-2021 |
Daniel Stenberg |
tidy-up: make conditional checks more consistent ... remove '== NULL' and '!= 0' Closes #6912
|
Revision tags: curl-7_76_1, curl-7_76_0 |
|
#
528f71c2 |
| 08-Feb-2021 |
Daniel Stenberg |
ftp: add 'list_only' to the transfer state struct and rename it from 'ftp_list_only' since it is also used for SSH and POP3. The state is updated internally for 'type=D' FTP URLs.
ftp: add 'list_only' to the transfer state struct and rename it from 'ftp_list_only' since it is also used for SSH and POP3. The state is updated internally for 'type=D' FTP URLs. Added test case 1570 to verify. Closes #6578
show more ...
|
#
0c51036e |
| 08-Feb-2021 |
Daniel Stenberg |
ftp: never set data->set.ftp_append outside setopt Since the set value then risks getting used like that when the easy handle is reused by the application. Also: renamed the str
ftp: never set data->set.ftp_append outside setopt Since the set value then risks getting used like that when the easy handle is reused by the application. Also: renamed the struct field from 'ftp_append' to 'remote_append' since it is also used for SSH protocols. Closes #6579
show more ...
|
Revision tags: curl-7_75_0 |
|
#
5a19cb5a |
| 21-Jan-2021 |
Daniel Stenberg |
wolfssh: remove conn->data references ... and repair recent build breakage Closes #6507
|
#
215db086 |
| 08-Jan-2021 |
Daniel Stenberg |
lib: pass in 'struct Curl_easy *' to most functions ... in most cases instead of 'struct connectdata *' but in some cases in addition to. - We mostly operate on transfers and no
lib: pass in 'struct Curl_easy *' to most functions ... in most cases instead of 'struct connectdata *' but in some cases in addition to. - We mostly operate on transfers and not connections. - We need the transfer handle to log, store data and more. Everything in libcurl is driven by a transfer (the CURL * in the public API). - This work clarifies and separates the transfers from the connections better. - We should avoid "conn->data". Since individual connections can be used by many transfers when multiplexing, making sure that conn->data points to the current and correct transfer at all times is difficult and has been notoriously error-prone over the years. The goal is to ultimately remove the conn->data pointer for this reason. Closes #6425
show more ...
|
#
725ec470 |
| 31-Dec-2020 |
Emil Engler |
language: s/behaviour/behavior/g We currently use both spellings the british "behaviour" and the american "behavior". However "behavior" is more used in the project so I think it's w
language: s/behaviour/behavior/g We currently use both spellings the british "behaviour" and the american "behavior". However "behavior" is more used in the project so I think it's worth dropping the british name. Closes #6395
show more ...
|
#
aba01da6 |
| 23-Dec-2020 |
Daniel Stenberg |
failf: remove newline from formatting strings ... as failf adds one itself. Also: add an assert() to failf() that triggers on a newline in the format string! Closes #63
failf: remove newline from formatting strings ... as failf adds one itself. Also: add an assert() to failf() that triggers on a newline in the format string! Closes #6365
show more ...
|
Revision tags: curl-7_74_0 |
|
#
a95a6ce6 |
| 23-Nov-2020 |
Daniel Stenberg |
urldata: remove 'void *protop' and create the union 'p' ... to avoid the use of 'void *' for the protocol specific structs done per transfer. Closes #6238
|
#
4d2f8006 |
| 04-Nov-2020 |
Daniel Stenberg |
curl.se: new home Closes #6172
|
Revision tags: curl-7_73_0, tiny-curl-7_72_0, curl-7_72_0, curl-7_71_1, curl-7_71_0 |
|
#
d23cc224 |
| 26-May-2020 |
Daniel Stenberg |
cleanup: use a single space after equals sign in assignments
|
Revision tags: curl-7_70_0, curl-7_69_1, curl-7_69_0 |
|
#
920af1a6 |
| 23-Jan-2020 |
Daniel Stenberg |
wolfssh: make it init properly via Curl_ssh_init() Closes #4846
|
#
68403cdb |
| 15-Jan-2020 |
Daniel Stenberg |
wolfssh: set the password correctly for PASSWORD auth
|
#
820775a2 |
| 15-Jan-2020 |
Daniel Stenberg |
wolfssh: remove fprintf() calls (and uses of __func__)
|
#
6773c7ca |
| 05-Jan-2020 |
Daniel Stenberg |
wolfSSH: new SSH backend Adds support for SFTP (not SCP) using WolfSSH. Closes #4231
|