email: Removed duplicated header file

sasl: Renamed Curl_sasl_decode_ntlm_type2_message()

For consistency with other SASL based functions renamed this function
to Curl_sasl_create_ntlm_type3_message() which better describes

sasl: Renamed Curl_sasl_decode_ntlm_type2_message()

For consistency with other SASL based functions renamed this function
to Curl_sasl_create_ntlm_type3_message() which better describes its
usage.

show more ...

pop3: Post authentication code tidy up

Corrected lines longer than 78 characters.

Changed POP3_AUTH_FINAL to POP3_AUTH to match SMTP code now that the
AUTH command is no longer

pop3: Post authentication code tidy up

Corrected lines longer than 78 characters.

Changed POP3_AUTH_FINAL to POP3_AUTH to match SMTP code now that the
AUTH command is no longer sent on its own.

Introduced some comments in data sending functions.

Another attempt at trying to rational code and comment style.

show more ...

pop3: Added support for sasl digest-md5 authentication

pop3: Changed the sasl mechanism detection from auth to capa

Not all SASL enabled POP3 servers support the AUTH command on its own
when trying to detect the supported mechanisms. As such

pop3: Changed the sasl mechanism detection from auth to capa

Not all SASL enabled POP3 servers support the AUTH command on its own
when trying to detect the supported mechanisms. As such changed the
mechanism detection to use the CAPA command instead.

show more ...

pop3: Added support for sasl cram-md5 authentication

pop3.c: Added conditional compilation for NTLM function calls

Added USE_NTLM condition compilation around the NTLM functions called
from pop3_statemach_act() introduced in commit 69f7156

pop3.c: Added conditional compilation for NTLM function calls

Added USE_NTLM condition compilation around the NTLM functions called
from pop3_statemach_act() introduced in commit 69f7156ad96877.

show more ...

pop3: Fixed an issue with changes introduced in commit c267c53017bc

Because pop3_endofresp() is called for each line of data yet is not
passed the line and line length, so we have to use

pop3: Fixed an issue with changes introduced in commit c267c53017bc

Because pop3_endofresp() is called for each line of data yet is not
passed the line and line length, so we have to use the data pointed to
by pp->linestart_resp which contains the whole packet, the mechanisms
were being detected in one call yet the function would be called for
each line of data.

Using curl with verbose mode enabled would show that one line of data
would be received in response to the AUTH command, before the AUTH
<mechanism> command was sent to the server and then the next few lines
of the original AUTH command would be displayed before the response from
the AUTH <mechanism> command. This would then cause problems when
parsing the CRAM-MD5 challenge data as extra data was contained in the
buffer.

Changed the parsing so that each line is checked for the mechanisms
and the function returns FALSE until the whole of the AUTH response has
been processed.

show more ...

pop3.c:Corrected typo in commit 69ba0da8272d

pop3: Fixed the issue of having to supply the user name for all requests

Previously it wasn't possible to connect to POP3 and not specify the
user name as a CURLE_ACCESS_DENIED error wou

pop3: Fixed the issue of having to supply the user name for all requests

Previously it wasn't possible to connect to POP3 and not specify the
user name as a CURLE_ACCESS_DENIED error would be returned. This error
occurred because USER would be sent to the server with a blank user name
if no mailbox user was specified as the server would reply with -ERR.

This wasn't a problem prior to the 7.26.0 release but with the
introduction of custom commands the user and/or application developer
might want to issue a CAPA command without having to log in as a
specific mailbox user.

Additionally this fix won't send the newly introduced AUTH command if no
user name is specified.

show more ...

pop3.c: Small code tidy up

Corrected lines exceeding 78 characters.

Repositioned some comments and added extra clarity.

pop3: Added support for sasl ntlm authentication

pop3: Added support for sasl login authentication

pop3: Added support for sasl plain text authentication

pop3: Introduced the continue response in pop3_endofresp()

pop3: Changed response code from O and E to + and -

The POP3 protocol doesn't really have the concept of error codes and
uses +, +OK and -ERR in response to commands to indicate continue

pop3: Changed response code from O and E to + and -

The POP3 protocol doesn't really have the concept of error codes and
uses +, +OK and -ERR in response to commands to indicate continue,
success and error.

The AUTH command is one of those commands that requires multiple pieces
of data to be sent to the server where the server will respond with + as
part of the handshaking. This meant changing the values before
continuing with the next stage of adding authentication support.

show more ...

pop3: Small code tidy up following authentication work so far

Changed the order of the state machine to match the order of actual
events.

Reworked some comments and function par

pop3: Small code tidy up following authentication work so far

Changed the order of the state machine to match the order of actual
events.

Reworked some comments and function parameter positioning that I missed
the other day.

show more ...

pop3: remove variable-not-used warnings

pop3: Added support for SASL based authentication mechanism detection

Added support for detecting the supported SASL authentication mechanisms
via the AUTH command. There are two ways of

pop3: Added support for SASL based authentication mechanism detection

Added support for detecting the supported SASL authentication mechanisms
via the AUTH command. There are two ways of detecting them, either by
using the AUTH command, that will return -ERR if not supported or by
using the CAPA command which will return SASL and the list of mechanisms
if supported, not include SASL if SASL authentication is not supported
or -ERR if the CAPA command is not supported. As such it seems simpler
to use the AUTH command and fallback to normal clear text authentication
if the the command is not supported.

Additionally updated the test cases to return -ERR when the AUTH command
is encountered. Additional test cases will be added when support for the
individual authentication mechanisms is added.

show more ...

pop3: remove trailing whitespace

pop3: Code tidy up before the introduction of authentication code

Moved EOB definition into header file.

Switched the logic around in pop3_endofresp() to allow for the
introduct

pop3: Code tidy up before the introduction of authentication code

Moved EOB definition into header file.

Switched the logic around in pop3_endofresp() to allow for the
introduction of auth-mechanism detection.

Repositioned second and third function variables where they will fit
within the 78 character line limit.

Tidied up some comments.

show more ...

pop3: Reworked the command sending and handling

Reworked the command sending from two specific LIST and RETR command
functions into a single command based function as well as the two

pop3: Reworked the command sending and handling

Reworked the command sending from two specific LIST and RETR command
functions into a single command based function as well as the two
associated response handlers into a generic command handler.

show more ...

pop3: Added support for additional pop3 commands

This feature allows the user to specify and use additional POP3
commands such as UIDL and DELE via libcurl's CURLOPT_CUSTOMREQUEST or

pop3: Added support for additional pop3 commands

This feature allows the user to specify and use additional POP3
commands such as UIDL and DELE via libcurl's CURLOPT_CUSTOMREQUEST or
curl's -X command line option.

show more ...

pop3.c: Corrected problem with state() introduced in 01690ed2bce5

pop.c: Small code tidy up