Remove local variables

This patch removes the so called local variables defined per
file basis for certain editors to properly show tab width, and
similar settings. These are mainly

Remove local variables

This patch removes the so called local variables defined per
file basis for certain editors to properly show tab width, and
similar settings. These are mainly used by Vim and Emacs editors
yet with recent changes the once working definitions don't work
anymore in Vim without custom plugins or additional configuration.
Neither are these settings synced across the PHP code base.

A simpler and better approach is EditorConfig and fixing code
using some code style fixing tools in the future instead.

This patch also removes the so called modelines for Vim. Modelines
allow Vim editor specifically to set some editor configuration such as
syntax highlighting, indentation style and tab width to be set in the
first line or the last 5 lines per file basis. Since the php test
files have syntax highlighting already set in most editors properly and
EditorConfig takes care of the indentation settings, this patch removes
these as well for the Vim 6.0 and newer versions.

With the removal of local variables for certain editors such as
Emacs and Vim, the footer is also probably not needed anymore when
creating extensions using ext_skel.php script.

Additionally, Vim modelines for setting php syntax and some editor
settings has been removed from some *.phpt files. All these are
mostly not relevant for phpt files neither work properly in the
middle of the file.

show more ...

Remove yearly range from copyright notice

Remove year range from copyright notice

Implement SQLite3Stmt::getSQL method, returning the original statement SQL, eventually expanded

SQLite3: Separating parameters binding in a function

Require SQLite ≥ 3.7.4 for ext/sqlite3

`SQLite3::readOnly()` uses `sqlite3_stmt_readonly()` which is only
available as of libsqlite 3.7.4. For older SQLite3 versions we return
alway

Require SQLite ≥ 3.7.4 for ext/sqlite3

`SQLite3::readOnly()` uses `sqlite3_stmt_readonly()` which is only
available as of libsqlite 3.7.4. For older SQLite3 versions we return
always `false`, which can be confusing. Instead of sticking with this
behavior, or even undefining the method for old SQLite3 versions, we
lift the requirements to SQLite 3.7.4 (released on 2010-12-08),
according to a respective discussion[1].

Since pdo_sqlite doesn't use `sqlite3_stmt_readonly()`, we stick with
the minimum requirement of SQLite 3.5.0.

[1] <https://github.com/php/php-src/pull/3614>

show more ...

Handle potential sqlite3_bind_*() call failures

Since bug 77051 has been fixed, it is unlikely that any of the
`sqlite3_bind_*` calls will ever fail, but we add respective checks
no

Handle potential sqlite3_bind_*() call failures

Since bug 77051 has been fixed, it is unlikely that any of the
`sqlite3_bind_*` calls will ever fail, but we add respective checks
nonetheless, and call `php_sqlite3_error()` in case of bind failures.

show more ...

Fix #77051: Issue with re-binding on SQLite3

We have to call `sqlite3_reset()` before re-binding the parameters.

Deny (un)serialization of SQLite3, SQLite3Stmt and SQLite3Result

Serializing `SQLite3`, `SQLite3Stmt` and `SQLite3Result` instances is
possible but pointless, since unserializing results

Deny (un)serialization of SQLite3, SQLite3Stmt and SQLite3Result

Serializing `SQLite3`, `SQLite3Stmt` and `SQLite3Result` instances is
possible but pointless, since unserializing results in uninitialized
instances, which will bail out of any method call. Therefore, we deny
serialization and unserialization in the first place.

show more ...

Use ZEND_THIS macro to hide implementation details in extensions code.

Replace getThis() by EX(This), when additional check is not necessary.

Support SQLite3 @name notation

Besides the common `:param` notation to designate named parameters in
prepared statements, SQLite3 also supports `@param` and `$param`.
While the latte

Support SQLite3 @name notation

Besides the common `:param` notation to designate named parameters in
prepared statements, SQLite3 also supports `@param` and `$param`.
While the latter is mostly to support the Tcl programming language, and
would be confusing for PHP's sqlite3 binding due to the similarity with
string interpolation, the former is common under .NET and raises no
such issue. Therefore we add support for it.

This patch has been developed in cooperation with @BohwaZ.

show more ...

Avoid needless string duplication

Cf. <https://github.com/php/php-src/pull/3636#issuecomment-436638833>.

Require SQLite ≥ 3.5.0 for ext/sqlite3 and ext/pdo_sqlite

It is possible to pass flags when opening an SQLite database. For
Sqlite < 3.5.0 these are ignored, since `sqlite3_open` doesn'

Require SQLite ≥ 3.5.0 for ext/sqlite3 and ext/pdo_sqlite

It is possible to pass flags when opening an SQLite database. For
Sqlite < 3.5.0 these are ignored, since `sqlite3_open` doesn't support
flags. Neither a warning or notice is raised in this case, nor is this
behavior documented in the PHP manual. Instead of fixing it either
way, we lift the requirement to SQLite 3.5.0 (released on 2007-09-04)
instead of the former SQLite 3.3.9 (released on 2007-01-04).

show more ...

Get rid of ZEND_ACC_CTOR, ZEND_ACC_DTOR and ZEND_ACC_IMPLEMENTED_ABSTRACT

Fix #76665: SQLite3Stmt::bindValue() with SQLITE3_FLOAT doesn't juggle

We need to ensure that a zval IS_DOUBLE before we access it as such.
In this case we apply common type juggling to

Fix #76665: SQLite3Stmt::bindValue() with SQLITE3_FLOAT doesn't juggle

We need to ensure that a zval IS_DOUBLE before we access it as such.
In this case we apply common type juggling to do so.

show more ...

Remove unused Git attributes ident

The $Id$ keywords were used in Subversion where they can be substituted
with filename, last revision number change, last changed date, and last
use

Remove unused Git attributes ident

The $Id$ keywords were used in Subversion where they can be substituted
with filename, last revision number change, last changed date, and last
user who changed it.

In Git this functionality is different and can be done with Git attribute
ident. These need to be defined manually for each file in the
.gitattributes file and are afterwards replaced with 40-character
hexadecimal blob object name which is based only on the particular file
contents.

This patch simplifies handling of $Id$ keywords by removing them since
they are not used anymore.

show more ...

Use zval_ptr_dtor() instead of zval_dtor() in internal functions that destroy new created object (This is safer and produces less code)

Remove sqlite and xmlrpc extension versions from phpinfo output

The rest of the core extensions don't display the extension versions in
the phpinfo output since they in most cases match

Remove sqlite and xmlrpc extension versions from phpinfo output

The rest of the core extensions don't display the extension versions in
the phpinfo output since they in most cases match the PHP release version.

show more ...

Remove unnecessary uses of z/ parameters

Export standard object handlers, to avoid indirect access

Use zend_string_release_ex() instread of zend_string_release() in places, where we sure about string persistence.

Remove return types from some magic method in protos

__construct, __destruct, __wakeup does not have return types defined.

Usee reference-counting instead of duplication

Use stack allocated zvals