#
0956267c |
| 23-Jul-2024 |
Levi Morrison |
Fix warnings in session/spl This fixes -Winline errors where the functions are not ever inlined. Also fixes some signature mismatches which were fixed previously but for whateve
Fix warnings in session/spl This fixes -Winline errors where the functions are not ever inlined. Also fixes some signature mismatches which were fixed previously but for whatever reason were not ported to all maintained branches: /usr/local/src/php/ext/session/session.c:1299:20: warning:conflicting types for 'php_session_send_cookie' due to enum/integer mismatch; have 'zend_result(void)' {aka 'ZEND_RESULT_CODE(void)'} [-Wenum-int-mismatch] 1299 | static zend_result php_session_send_cookie(void) /* {{{ */ | ^~~~~~~~~~~~~~~~~~~~~~~ /usr/local/src/php/ext/session/session.c:100:12: note: previous declaration of 'php_session_send_cookie' with type 'int(void)' 100 | static int php_session_send_cookie(void); | ^~~~~~~~~~~~~~~~~~~~~~~
show more ...
|
#
aa34e0ac |
| 12-Mar-2024 |
Niels Dossche <7771979+nielsdos@users.noreply.github.com> |
Fix GH-13685: Unexpected null pointer in zend_string.h Regressed in 6fbf81c. There is a missing error check on spl_filesystem_file_read_line(), which means that if the line coul
Fix GH-13685: Unexpected null pointer in zend_string.h Regressed in 6fbf81c. There is a missing error check on spl_filesystem_file_read_line(), which means that if the line could not be read (e.g. because we're at the end of the file), it will not set intern->u.file.current_line, which will cause a NULL pointer deref later on. Fix it by adding a check, and reintroducing the silent flag partially to be able to throw an exception like it did in the past. Closes GH-13692.
show more ...
|
#
4d41dffb |
| 18-Nov-2023 |
Niels Dossche <7771979+nielsdos@users.noreply.github.com> |
Fix GH-12721: SplFileInfo::getFilename() segfault in combination with GlobIterator and no directory separator This broke in 7cd8879 and 9bae9ab. NULL is a perfectly valid return value th
Fix GH-12721: SplFileInfo::getFilename() segfault in combination with GlobIterator and no directory separator This broke in 7cd8879 and 9bae9ab. NULL is a perfectly valid return value that should be handled. Closes GH-12722.
show more ...
|
#
0b2e6bc2 |
| 02-Jul-2023 |
Niels Dossche <7771979+nielsdos@users.noreply.github.com> |
Cache d_type in directory entry
|
#
1fbbd2b2 |
| 02-Jul-2023 |
Niels Dossche <7771979+nielsdos@users.noreply.github.com> |
Remove unused is_recursive entry This only takes up space and time.
|
#
bce53606 |
| 29-May-2023 |
Niels Dossche <7771979+nielsdos@users.noreply.github.com> |
Fix GH-11338: SplFileInfo empty getBasename with more than one slash Regressed in 13e4ce386bb7. Closes GH-11340.
|
#
9d5f2f13 |
| 20-Mar-2023 |
Ilija Tovilo |
Use new ZSTR_INIT_LITERAL macro (#10879)
|
#
90047253 |
| 26-Feb-2023 |
Marcos Marcolin <48370677+marcosmarcolin@users.noreply.github.com> |
chore: standardize the visibility of functions. (#10708) Co-authored-by: Marcos Marcolin <marcos@ixcsoft.com.br>
|
#
7936c808 |
| 23-Jan-2023 |
Máté Kocsis |
Fix GH-8329 Print true/false instead of bool in error and debug messages (#8385)
|
#
c8955c07 |
| 16-Jan-2023 |
Christoph M. Becker |
Revert GH-10220 Cf. <https://github.com/php/php-src/pull/10220#issuecomment-1383739816>. This reverts commit ecc880f491d66081298a16634629f149459706a9. This reverts commit 588a07
Revert GH-10220 Cf. <https://github.com/php/php-src/pull/10220#issuecomment-1383739816>. This reverts commit ecc880f491d66081298a16634629f149459706a9. This reverts commit 588a07f7371ee2b5fac17de147926780e427fae6. This reverts commit f377e15751d3aa48b69cd9bcc366ede7803d511f. This reverts commit b4ba16fe189b109144aff669e11d81365160104b. This reverts commit 694ec1deea36e366b28b6349a52be49824e1a1a8. This reverts commit 6b34de8eba9f66882ae16e6073af28783670ac53. This reverts commit aa1cd02a4367834026ea2205ea13a2f904455aa1. This reverts commit 308fd311ea6fcf3094b448df7f2b264f08e4fe4f. This reverts commit 16203b53e1822a37b6ba6f2ab198bb435d05fdad. This reverts commit 738fb5ca5412f5e833a7fab82b11519e635a3357. This reverts commit 9fdbefacd3c382d731aa175b7bdc002ec9cb2b30. This reverts commit cd4a7c1d90562ebb5f89caf94d00d579631b9fbe. This reverts commit 928685eba2b2f0ded90e7f78fd806ea164002f6e. This reverts commit 01e5ffc85cd4357fd7b5b7ceefa29f2d10ca26b7.
show more ...
|
#
308fd311 |
| 04-Jan-2023 |
Max Kellermann |
ext/{standard,json,random,...}: add missing includes
|
#
6fbf81c6 |
| 09-Nov-2022 |
George Peter Banyard |
Fix GH-9883 SplFileObject::__toString() reads next line We need to overwrite the __toString magic method for SplFileObject, similarly to how DirectoryIterator overwrites it Moreover, th
Fix GH-9883 SplFileObject::__toString() reads next line We need to overwrite the __toString magic method for SplFileObject, similarly to how DirectoryIterator overwrites it Moreover, the custom cast handler is useless as we define __toString methods, so use the standard one instead. Closes GH-9912
show more ...
|
#
a01dd9fe |
| 14-Sep-2022 |
Bob Weinand |
Revert "Port all internally used classes to use default_object_handlers" This reverts commit 94ee4f9834743ca74f6c9653863273277ce6c61a. The commit was a bit too late to be included i
Revert "Port all internally used classes to use default_object_handlers" This reverts commit 94ee4f9834743ca74f6c9653863273277ce6c61a. The commit was a bit too late to be included in PHP 8.2 RC1. Given it's a massive ABI break, we decide to postpone the change to PHP 8.3.
show more ...
|
Revision tags: php-8.2.0RC1, php-8.1.10, php-8.0.23 |
|
#
94ee4f98 |
| 24-Aug-2022 |
Bob Weinand |
Port all internally used classes to use default_object_handlers Signed-off-by: Bob Weinand <bobwei9@hotmail.com>
|
Revision tags: php-8.0.23RC1, php-8.1.10RC1, php-8.2.0beta3 |
|
#
b73f139c |
| 02-Aug-2022 |
Máté Kocsis |
Declare ext/spl constants in stubs (#9226)
|
Revision tags: php-8.2.0beta2, php-8.1.9, php-8.0.22 |
|
#
1478278f |
| 01-Aug-2022 |
George Peter Banyard |
SPL: Use new improved is_line_empty() function instead of the old one (#9217)
|
#
7ab22aad |
| 28-Jul-2022 |
George Peter Banyard |
Refactor code handling file.current_zval (#8934) The Zval is always an array
|
#
5d52d472 |
| 26-Jul-2022 |
Christoph M. Becker |
Fix #69181: READ_CSV|DROP_NEW_LINE drops newlines within fields One may argue that `DROP_NEW_LINE` does not make sense in combination with `READ_CSV`, but without `DROP_NEW_LINE`, `SKIP_
Fix #69181: READ_CSV|DROP_NEW_LINE drops newlines within fields One may argue that `DROP_NEW_LINE` does not make sense in combination with `READ_CSV`, but without `DROP_NEW_LINE`, `SKIP_EMPTY` does not skip empty lines at all. We could fix that, but do not for BC reasons. Instead we no longer drop newlines in `spl_filesystem_file_read_ex()` when reading CSV, but handle that in `spl_filesystem_file_read_csv()` by treating lines with only (CR)LF as being empty as well. Closes GH-7618.
show more ...
|
Revision tags: php-8.1.9RC1, php-8.2.0beta1, php-8.0.22RC1 |
|
#
4ccf0b01 |
| 08-Jul-2022 |
George Peter Banyard |
Make php_fgetcsv() return a HashTale instead of in-out zval param (#8936) Also refactor what happens on an empty line to return NULL instead of setting the array to [NULL] which makes no des
Make php_fgetcsv() return a HashTale instead of in-out zval param (#8936) Also refactor what happens on an empty line to return NULL instead of setting the array to [NULL] which makes no design sense at all. However, as this is the current behaviour create a BC Shim inline function to recreate this weird HashTable in the functions which currently use this API
show more ...
|
Revision tags: php-8.0.21 |
|
#
247de8a4 |
| 06-Jul-2022 |
George Peter Banyard |
Use true/false and comment when arg correspond to silent arg
|
#
bb3d0933 |
| 06-Jul-2022 |
George Peter Banyard |
Remove silent argument to spl_filesystem_file_read_line_ex() true was always passed to it
|
#
a055c548 |
| 06-Jul-2022 |
George Peter Banyard |
Remove silent argument to spl_filesystem_file_read_line() true was always passed to it
|
Revision tags: php-8.1.8 |
|
#
79a28324 |
| 05-Jul-2022 |
George Peter Banyard |
Revert "Fix GH-8563 Different results for seek() on SplFileObject and SplTempFileObject" Although the fix is partially correct it also breaks long standing behaviour which has been produced
Revert "Fix GH-8563 Different results for seek() on SplFileObject and SplTempFileObject" Although the fix is partially correct it also breaks long standing behaviour which has been produced since PHP 5.3. This reverts commit 6f87a5c6338d0d64d18e3a44b65c19acc9c529e8.
show more ...
|
Revision tags: php-8.2.0alpha3 |
|
#
9bae9ab3 |
| 28-Jun-2022 |
George Peter Banyard |
Fix GH-8861: correctly handle string lengths in SplFileinfo methods (#8869) * Fix GH-8861: correctly handle string lengths in \SplFileinfo::getBasename Co-authored-by: M. Vondano <m
Fix GH-8861: correctly handle string lengths in SplFileinfo methods (#8869) * Fix GH-8861: correctly handle string lengths in \SplFileinfo::getBasename Co-authored-by: M. Vondano <m-vo@users.noreply.github.com>
show more ...
|
#
3b92a966 |
| 25-Jun-2022 |
Ilija Tovilo |
Convert return type of various object handlers from int to zend_result (#8755)
|