Boolify do_exec()

Formalize return type to zend_result for PGSQL_API functions

ValueError if lengths is less than 0

Use ZEND_ASSERT() instead of plain assert()

Use ZEND_NUM_ARGS() explicitly

Boolify _php_pgsql_link_has_results()

Boolify _php_pgsql_detect_identifier_escape() and rename it

New name is _php_pgsql_identifier_is_escaped()

Add zend_ulong_to_str() API

No point in going through a smart_str and append_unsigned if we
can construct the result directly...

Use zend_string_equals_(literal_)ci() API more often

Also drive-by usage of zend_ini_parse_bool()

Closes GH-6844

Introduce pseudo-keyword ZEND_FALLTHROUGH

And use it instead of comments

Use zend_string_equals() API instead of strcmp() in PGSQL extension

And tiny drive by refactor at the same time for more usages

Fix locale dependent parsing of PostgreSQL version number

Version numbers are not supposed to be localized, so we must not apply
locale dependent parsing with `atof()`.

Using `p

Fix locale dependent parsing of PostgreSQL version number

Version numbers are not supposed to be localized, so we must not apply
locale dependent parsing with `atof()`.

Using `php_version_compare()` might even be better.

Closes GH-6668.

show more ...

Replace zend_bool uses with bool

We're starting to see a mix between uses of zend_bool and bool.
Replace all usages with the standard bool type everywhere.

Of course, zend_bool

Replace zend_bool uses with bool

We're starting to see a mix between uses of zend_bool and bool.
Replace all usages with the standard bool type everywhere.

Of course, zend_bool is retained as an alias.

show more ...

Make convert_to_*_ex simple aliases of convert_to_*

Historically, the _ex variants separated the zval first, if a
conversion was necessary. This distinction no longer makes sense
sin

Make convert_to_*_ex simple aliases of convert_to_*

Historically, the _ex variants separated the zval first, if a
conversion was necessary. This distinction no longer makes sense
since PHP 7.

The only difference that was still left is that _ex checked whether
the type is the same first, but the usage of these macros did not
actually distinguish on whether such an inlined check is valuable
or not in a given context.

Also drop the unused convert_to_explicit_type macros.

show more ...

Fix default value handling of mysqli_fetch_object()

Make [] acceptable both for classes without constructors and
classes with a constructor that takes no arguments.

Closes GH-63

Fix default value handling of mysqli_fetch_object()

Make [] acceptable both for classes without constructors and
classes with a constructor that takes no arguments.

Closes GH-6336.

show more ...

Don't accept null in pg_unescape_bytea()

This is an error that slipped in via 8d37c37bcdbf6fa99cd275413342457eeb2c664e.
pg_unescape_bytea() did not accept null in PHP 7.4, and it is not

Don't accept null in pg_unescape_bytea()

This is an error that slipped in via 8d37c37bcdbf6fa99cd275413342457eeb2c664e.
pg_unescape_bytea() did not accept null in PHP 7.4, and it is not
meaningful for it to accept null now -- it will always fail, and now
with a misleading OOM message.

show more ...

Use a subrountine to check for valid OID strings

Closes 6260

Promote E_NOTICE to Value/TypeError in PostgreSQL extension

Add some tests to cover related codepaths.
With the small caveat that the ones in build_assignment_string()
still don't se

Promote E_NOTICE to Value/TypeError in PostgreSQL extension

Add some tests to cover related codepaths.
With the small caveat that the ones in build_assignment_string()
still don't seem to be tested as it looks the condtions are checked
beforehand, might need some more investigation.

Closes GH-6226

show more ...

Return empty array for no rows in pg_fetch_all()

This makes it line up with pg_fetch_all_columns(), as well as
similar functions in other exts, such as mysqli_fetch_all().

Promote invalid field to ValueError in pgsql

The same error condition is a ValueError in mysqli, be consistent.

Additionally, do not display the argument name for these errors.

Promote invalid field to ValueError in pgsql

The same error condition is a ValueError in mysqli, be consistent.

Additionally, do not display the argument name for these errors.
As the signatures are overloaded, the argument name may not match
the meaning at all.

show more ...

Remove redundant check

This was already checked directly above.

pg_unescape_bytea() can only fail on OOM

The implementation did not check for PQunescapeBytea failure
correctly, because it checked for a null pointer after estrndup,
which certainly

pg_unescape_bytea() can only fail on OOM

The implementation did not check for PQunescapeBytea failure
correctly, because it checked for a null pointer after estrndup,
which certainly cannot happen. Inspection of the PGunescapeBytea
implementation has shown that this function can only fail on OOM,
so let's check for that explicitly and remove false as a possible
return type.

While we're here, avoid an unnecessary copy of the result.

show more ...

Fix a few UNKNOWN default values in ext/pgsql

Closes GH-6149

Promote warnings to Errors in PostgreSQL extension

Do some drive by indentation fixes
Also fix pg_select() in regards to the $result_type arg which was missing from ZPP

Closes G

Promote warnings to Errors in PostgreSQL extension

Do some drive by indentation fixes
Also fix pg_select() in regards to the $result_type arg which was missing from ZPP

Closes GH-6129

show more ...

Use string|int union types in pgsql

For "field name or field offset" parameters.

Also make $ctor_params an ?array parameter.