Handle undefined dim in assign_dim_helper

Not only the value can be undefined here, but the offset as well.

JIT: Fixed incorrect reference handling in PRE_INC/DEC_OBJ

Reuse wrong string offset logic in jit

JIT contains a copy of this function that effectively only differs
by fetching current_execute_data from EG. We can do that in the VM
version a

Reuse wrong string offset logic in jit

JIT contains a copy of this function that effectively only differs
by fetching current_execute_data from EG. We can do that in the VM
version as well, as this is just used to throw an error.

Export the VM function and reuse it in JIT.

show more ...

JIT: Fixed result when assigning to typed reference

Check exception before using undef_result_after_exception()

undefined_op_helper_write() can return 0 not just if an exception
is thrown, so check this explicitly. This fixes an issue int

Check exception before using undef_result_after_exception()

undefined_op_helper_write() can return 0 not just if an exception
is thrown, so check this explicitly. This fixes an issue introduced
in fe1633f0104521117edabefea78803d77d3d57b1.

show more ...

Undef result if undef dim warning promoted to exception

Fixes oss-fuzz #39278.

JIT: Split zend_jit_hash_index_lookup_rw() into zend_jit_hash_index_lookup_rw() and zend_jit_hash_index_lookup_rw_no_packed().

The previous version might fail if zend_jit_hash_index_lookup_r

JIT: Split zend_jit_hash_index_lookup_rw() into zend_jit_hash_index_lookup_rw() and zend_jit_hash_index_lookup_rw_no_packed().

The previous version might fail if zend_jit_hash_index_lookup_rw() was called for packed array.

show more ...

JIT: Fixed possible memory leak

Fix JIT typed property inc/dec

This was leaking memory for pre-inc/dec of a refcounted typed
property if the result was not used.

The code to do this was unnecessarily complicat

Fix JIT typed property inc/dec

This was leaking memory for pre-inc/dec of a refcounted typed
property if the result was not used.

The code to do this was unnecessarily complicated, we can base
this on the zend_jit_inc/dec_typed_prop() helper and copy to the
result afterwards.

show more ...

Check for undef var in typed property assignment

Without this check the assignment would actually silently succeed,
not just skip the warning.

Handle undef assignment to typed ref

Handle undef value in assign_dim jit

We should report the undefined variable here and convert it to
null. Passing on undef is particularly insidious here, because
a write_dimension h

Handle undef value in assign_dim jit

We should report the undefined variable here and convert it to
null. Passing on undef is particularly insidious here, because
a write_dimension handler may insert it into a hash table
(observed with WeakMap).

show more ...

JIT: prefer string reallocation instead of allocation/memcpy/deallocation

JIT: Update run_time_cache slot in zend_jit_find_func helper

Export zend_use_resource_as_offset()

Use a common implementation to generate this error message, as
we do so in quite a few places dealing with array keys.

JIT: Code generation for ROPE_INIT, ROPE_ADD and ROPE_END with STRING operands

Sync JIT overloaded assign/inc/dec overloaded property

We should only release the read_property return value if
retval is used, same as in zend_execute.c. This fixes a test
failure u

Sync JIT overloaded assign/inc/dec overloaded property

We should only release the read_property return value if
retval is used, same as in zend_execute.c. This fixes a test
failure under PROFITABILITY_CHECKS=0.

show more ...

Sync JIT zend_check_string_offset()

Return after zend_jit_illegal_string_offset() to avoid a redundant
warning during conversion.

This fixes some tests under PROFITABILITY_CHECK

Sync JIT zend_check_string_offset()

Return after zend_jit_illegal_string_offset() to avoid a redundant
warning during conversion.

This fixes some tests under PROFITABILITY_CHECKS=0.

show more ...

Remove leading underscore for _zend_hash_find_known_hash (#7260)

Convert zend_hash_find_ex(..., 1) to zend_hash_find_known_hash(...)
Convert zend_hash_find_ex(..., 0) to zend_hash_find(.

Remove leading underscore for _zend_hash_find_known_hash (#7260)

Convert zend_hash_find_ex(..., 1) to zend_hash_find_known_hash(...)
Convert zend_hash_find_ex(..., 0) to zend_hash_find(...)

Also add serializable changes to UPGRADING.INTERNALS summary

show more ...

Implement readonly properties

Add support for readonly properties, for which only a single
initializing assignment from the declaring scope is allowed.

RFC: https://wiki.php.net

Implement readonly properties

Add support for readonly properties, for which only a single
initializing assignment from the declaring scope is allowed.

RFC: https://wiki.php.net/rfc/readonly_properties_v2

Closes GH-7089.

show more ...

Deprecate autovivification on false

Deprecate automatically converting "false" into an empty array
on write operands. Autovivification continues to be supported
for "null" values, as

Deprecate autovivification on false

Deprecate automatically converting "false" into an empty array
on write operands. Autovivification continues to be supported
for "null" values, as well as undefined/uninitialized values.

RFC: https://wiki.php.net/rfc/autovivification_false

Closes GH-7131.

Co-authored-by: Tyson Andre <tysonandre775@hotmail.com>
Co-authored-by: Nikita Popov <nikita.ppv@gmail.com>

show more ...

Add exception check to zend_jit_fetch_obj_w_slow()

This ports 247105ae1ae2a04608078f7fcfe88dacab9f55a4 to the JIT
implementation. The issue doesn't trigger on the original test
case

Add exception check to zend_jit_fetch_obj_w_slow()

This ports 247105ae1ae2a04608078f7fcfe88dacab9f55a4 to the JIT
implementation. The issue doesn't trigger on the original test
case with JIT, but I ran into a case that does trigger with JIT
once we have typed properties.

show more ...

Pure Intersection types (#6799)

Implement pure intersection types RFC

RFC: https://wiki.php.net/rfc/pure-intersection-types

Co-authored-by: Nikita Popov <nikic@php.net>

Pure Intersection types (#6799)

Implement pure intersection types RFC

RFC: https://wiki.php.net/rfc/pure-intersection-types

Co-authored-by: Nikita Popov <nikic@php.net>
Co-authored-by: Ilija Tovilo <ilutov@php.net>

show more ...

Move the whole "cold" path into the "cold" function.

Implement "Deprecate implicit non-integer-compatible float to int conversions" RFC. (#6661)

RFC: https://wiki.php.net/rfc/implicit-float-int-deprecate

Co-authored-by: Nikita Popov <

Implement "Deprecate implicit non-integer-compatible float to int conversions" RFC. (#6661)

RFC: https://wiki.php.net/rfc/implicit-float-int-deprecate

Co-authored-by: Nikita Popov <nikita.ppv@gmail.com>

show more ...