raise ValueError from imagecreate/imagecreatetruecolor

Raise a ValueError instead of a plain Error when calling imagecreate()
or imagecreatetruecolor() with too big or small values for t

raise ValueError from imagecreate/imagecreatetruecolor

Raise a ValueError instead of a plain Error when calling imagecreate()
or imagecreatetruecolor() with too big or small values for the width or
height arguments.

show more ...

Warnings to Errors: imagesetstyle

Warnings to errors in imageaffinematrix*()

Warnings to errors in imagecrop(auto)

Warnings to errors imageconvolution

Warnings become errors for imagepolygon et al

Negative checks for gamma

Warnings for image colour range check now throw exceptions

Warnings to errors for imagecreatefromgd2part

We also delete tests which were duplicates of a completely unrelated
test.

Warnings to Errors imagetruecolortopalette

Warnings to Errors imagecreate(truecolor)

We also add a test helper which we will be using for other GD functions
as well.

Don't explicitly set return value on ZPP/ZFR failure

Failing `zend_parse_parameters()` and `zend_fetch_resource()` throw as
of PHP 8.0.0, so explicitly setting a return value is useless,

Don't explicitly set return value on ZPP/ZFR failure

Failing `zend_parse_parameters()` and `zend_fetch_resource()` throw as
of PHP 8.0.0, so explicitly setting a return value is useless, and also
slightly confusing.

show more ...

Remove some misleading RETURN_FALSE

These functions throw, so they can't return false.

This is just a subset...

Fix parameter order

`imagecopymerge()` and `imagecopymergegray()` expect the destination
image first, not the other way round.

Extend color component range checks

We also check for alpha components to be within range, and we add yet
missing range checks for other functions as well.

Add GD function stubs

Report errors from stream read and write operations

The php_stream_read() and php_stream_write() functions now return
an ssize_t value, with negative results indicating failure. Function

Report errors from stream read and write operations

The php_stream_read() and php_stream_write() functions now return
an ssize_t value, with negative results indicating failure. Functions
like fread() and fwrite() will return false in that case.

As a special case, EWOULDBLOCK and EAGAIN on non-blocking streams
should not be regarded as error conditions, and be reported as
successful zero-length reads/writes instead. The handling of EINTR
remains unclear and is internally inconsistent (e.g. some code-paths
will automatically retry on EINTR, while some won't).

I'm landing this now to make sure the stream wrapper ops API changes
make it into 7.4 -- however, if the user-facing changes turn out to
be problematic we have the option of clamping negative returns to
zero in php_stream_read() and php_stream_write() to restore the
old behavior in a relatively non-intrusive manner.

show more ...

cleanup gd build with system libgd - drop need to use libpng with system libgd - drop need to use libjpeg with system libgd - drop need to use libXpm with system libgd - drop need to use libfreetype

cleanup gd build with system libgd - drop need to use libpng with system libgd - drop need to use libjpeg with system libgd - drop need to use libXpm with system libgd - drop need to use libfreetype with system libgd - improve configure comments

show more ...

Drop superfluous ENABLE_GD_TTF

If we `HAVE_LIBFREETYPE`, we define `ENABLE_GD_TTF` if it is not
defined. Therefore we can check for `HAVE_LIBFREETYPE` in the first
place.

Use ZEND_HASH_FOREACH APIs in a few more places

Properly shut down font cache mutex

Since the font cache mutex in set up in MINIT, we have to shut it down
in MSHUTDOWN.

Support TGA reading

We add PHP bindings for libgd's features to read TGA files, which are
available as of libgd 2.1.0.

As PHP's bundled libgd doesn't yet include the respective

Support TGA reading

We add PHP bindings for libgd's features to read TGA files, which are
available as of libgd 2.1.0.

As PHP's bundled libgd doesn't yet include the respective features of the
external libgd, we add these.

Since TGA has no easily recognizable file signature, we don't add TGA
support for imagecreatefromstring() or getimagesize() and friends.

show more ...

imagecolorallocate(): Check that RGB components are in-range

Instead of letting them bleed over into other components.

imageloadfont: Perform overflow check before calculation

Instead of afterwards...

Add BMP support to PHP info