Merge branch 'PHP-7.4'

* PHP-7.4:
Simplify PHP_CHECK_PDO_INCLUDES calls

Simplify PHP_CHECK_PDO_INCLUDES calls

Conditional checks were once used for backwards compatibility with
phpize from PHP versions that didn't have this macro call yet.

Closes GH

Simplify PHP_CHECK_PDO_INCLUDES calls

Conditional checks were once used for backwards compatibility with
phpize from PHP versions that didn't have this macro call yet.

Closes GH-4376

show more ...

Merge branch 'PHP-7.4'

* PHP-7.4:
Remove PHP_DEBUG_MACRO

Remove PHP_DEBUG_MACRO

The macro is no longer used. The warning at the end of the configure
script therefore is also no longer used.

Merge branch 'PHP-7.4'

* PHP-7.4:
Remove some more Apache 1 left overs

Remove some more Apache 1 left overs

- warning in configure.ac is relevant for the sapi/apache
- errors output redirected to /dev/null when checking Apache version

Merge branch 'PHP-7.4'

* PHP-7.4:
Remove PHP_CHECK_CONFIGURE_OPTIONS

Remove PHP_CHECK_CONFIGURE_OPTIONS

Instead of building a custom macro for checking configure options,
Autoconf 2.62+ already outputs a warning at the beginning and the end
of the out

Remove PHP_CHECK_CONFIGURE_OPTIONS

Instead of building a custom macro for checking configure options,
Autoconf 2.62+ already outputs a warning at the beginning and the end
of the output of configure script. It automatically detects correct
and wrong options better.

This is related also to bug #55634.

So now instead a better way is the default Autoconf approach:

This outputs a warning at the beginning and end of the configure output:

./configure --with-non-existing

This results in fatal error:

./configure --non-existing

configure: error: unrecognized option: `--non-existing'
Try `./configure --help' for more information

The `--enable-option-checking=fatal` results in fatal error for all non
existing options:

./configure --with-non-existing --enable-option-checking=fatal

configure: error: unrecognized options: --with-non-existing

Closes GH-4348

show more ...

Merge branch 'PHP-7.4'

* PHP-7.4:
Remove warnings for bison and re2c checks

Remove warnings for bison and re2c checks

This patch removes warnings when lexer and parser files are already
generated. For example, when downloading a PHP release. Realistically,
i

Remove warnings for bison and re2c checks

This patch removes warnings when lexer and parser files are already
generated. For example, when downloading a PHP release. Realistically,
it is not so trivial to rebuild lexer and parser files without removing
them first. And considering that tarballs don't have cleaning tools
such as Git, this would require manual removali.

Related also to https://bugs.gentoo.org/593278

show more ...

Merge branch 'PHP-7.4'

Use a common setup macro to detect the Expat library

Closes GH-4221.

Merge branch 'PHP-7.4'

* PHP-7.4:
Normalize comments in *nix build system m4 files

Normalize comments in *nix build system m4 files

Normalization include:
- Use dnl for everything that can be ommitted when configure is built in
favor of the shell comment characte

Normalize comments in *nix build system m4 files

Normalization include:
- Use dnl for everything that can be ommitted when configure is built in
favor of the shell comment character # which is visible in the output.
- Line length normalized to 80 columns
- Dots for most of the one line sentences
- Macro definitions include similar pattern header comments now

show more ...

Merge branch 'PHP-7.4'

* PHP-7.4:
Move acinclude.m4 to build/php.m4

Move acinclude.m4 to build/php.m4

The acinclude.m4 file is in a usual Autotools build processed with
Automake's aclocal tool. Since PHP currently doesn't use Automake and
aclocal thi

Move acinclude.m4 to build/php.m4

The acinclude.m4 file is in a usual Autotools build processed with
Automake's aclocal tool. Since PHP currently doesn't use Automake and
aclocal this file can be moved into the build directory. PHP build
system currently generates a combined aclocal.m4 file that Autoconf
can processes automatically.

However, a newer practice is writing all local macros in separate
dedicated files prefixed with package name, in PHP's case PHP_MACRO_NAME
and putting them in a common `m4` directory. PHP uses currently `build`
directory for this purpose.

Name `php.m4` probably most resembles such file for PHP's case.

PHP manually created the aclocal.m4 file from acinclude.m4 and
build/libtool.m4. Which is also not a particularly good practice [1], so
this patch also removes the generated alocal.m4 usage and uses
m4_include() calls manually in the configure.ac and phpize.m4 files
manually.

- sort order is not important but can be alphabetical
- list of *.m4 files prerequisites for configure script generation
updated
- Moving m4_include() before AC_INIT also removes all comments starting
with hash character (`#`) in the included files.

[1] https://autotools.io/autoconf/macros.html

show more ...