[Observer] Save opline before calling begin/end handlers

Fix handling of throwing undef var in verify return

If we have an undefined variable and null is not accepted by the
return type, we want to throw just the undef var error.

In t

Fix handling of throwing undef var in verify return

If we have an undefined variable and null is not accepted by the
return type, we want to throw just the undef var error.

In this case this lead to an infinite loop, because we overwrite
the exception opline in SAVE_OPLINE and it does not get reset
when chaining into a previous exception. Add an assertiong to
catch this case earlier.

show more ...

Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
Avoid non-object in FE_FREE

Avoid non-object in FE_FREE

Even if the properties HT is empty, make sure we still leave an
object in the FE_RESET result, so our type inference results
stay correct.

Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
Fixed bug #80186

Fixed bug #80186

Early exit in FE_RESET if get_properties() returns empty array,
as we cannot add HT iterators to zend_empty_array.

Fixed incorrect behavior of observer API.

ZEND_HANDLE_EXCEPTION might call zend_observer_fcall_end() even if exception is cought by function. The fix moved zend_observer_fcall_end() into a r

Fixed incorrect behavior of observer API.

ZEND_HANDLE_EXCEPTION might call zend_observer_fcall_end() even if exception is cought by function. The fix moved zend_observer_fcall_end() into a right place and remove OBSERVER sepecialization for ZEND_HANDLE_EXCEPTION handler.

show more ...

Promote count() warning to TypeError

Closes GH-6180

Synchronize GET_CLASS/GET_CALLED_CLASS opcodes with functions

These error conditions throw in the function implementations,
make the opcodes match.

Cleanup observer API and add JIT support

Remove specialization of SPEC(OBSERVER) handlers

Fix OSS Fuzz issue: yielding from an aborted generator

Fix undef var exception handling in JMP_NULL

We need to initialize the result variable in the exceptional
case as well.

Fixes oss-fuzz #25526.

Improve error messages mentioning parameters instead of arguments

Closes GH-5999

micro-optimization

Merge branch 'PHP-7.4'

* PHP-7.4:
Fixed bug #80049

Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
Fixed bug #80049

Fixed bug #80049

Type checking may convert to refcounted values, so force freeing
of extra args.

Micro-optimization

Add zend_observer API

Closes GH-5857.

Co-authored-by: Nikita Popov <nikita.ppv@gmail.com>
Co-authored-by: Sammy Powers <sammyk@datadoghq.com>

Fix FE_FETCH_R_SIMPLE specialization

After a99d08b5d135fffa1d83b08b056e0080d295d863 the type can
include UNDEF. However, UNDEF can only reach FE_FREE, not FE_FETCH.
As such, simply i

Fix FE_FETCH_R_SIMPLE specialization

After a99d08b5d135fffa1d83b08b056e0080d295d863 the type can
include UNDEF. However, UNDEF can only reach FE_FREE, not FE_FETCH.
As such, simply ignore this type.

show more ...

Fix unused variable warning

Remove unnecessary cache_slot arguments

zend_verify_type_error_common() no longer needs the cache_slot,
so drop it there and from all users.

Improve type declarations for Zend APIs

Voidification of Zend API which always succeeded
Use bool argument types instead of int for boolean arguments
Use bool return type for functio

Improve type declarations for Zend APIs

Voidification of Zend API which always succeeded
Use bool argument types instead of int for boolean arguments
Use bool return type for functions which return true/false (1/0)
Use zend_result return type for functions which return SUCCESS/FAILURE as they don't follow normal boolean semantics

Closes GH-6002

show more ...

Fix pass by ref error for named params