Add error notification callbacks to UPGRADING.INTERNALS

Remove type argument from zend_get_zval_ptr

As pointed out by Levi, this is unused, and we already changed
the signature of this function for PHP 8.

Use consistent types

uint32_t type for argument count
size_t for length of char*
zend_bool for a zval bool arg

Closes GH-5845

Add upgrading note

[ci skip]

Voidify some ZEND_API functions

Closes GH-5805

Remove no_separation flag

[skip ci] add upgrade note

Closes GH-5798

[ci skip] (Hopefully) clarify meaning

Document zend_hash_sort and zend_ts_hash_sort signature change

Cf. <https://github.com/php/php-src/pull/3936>.

Update UPGRADING.INTERNALS re: removed --disable-inline-optimization switch

This build configuration switch was removed in 3a19726bce.

Introduce InternalIterator

Userland classes that implement Traversable must do so either
through Iterator or IteratorAggregate. The same requirement does
not exist for internal class

Introduce InternalIterator

Userland classes that implement Traversable must do so either
through Iterator or IteratorAggregate. The same requirement does
not exist for internal classes: They can implement the internal
get_iterator mechanism, without exposing either the Iterator or
IteratorAggregate APIs. This makes them usable in get_iterator(),
but incompatible with any Iterator based APIs.

A lot of internal classes do this, because exposing the userland
APIs is simply a lot of work. This patch alleviates this issue by
providing a generic InternalIterator class, which acts as an
adapater between get_iterator and Iterator, and can be easily
used by many internal classes. At the same time, we extend the
requirement that Traversable implies Iterator or IteratorAggregate
to internal classes as well.

Closes GH-5216.

show more ...

Fix typo

Added note

Control VCRT leak reporting via environment variable in debug builds

Formerly, this had to be enabled by passing the configuration flag
`--enable-crt-debug`; now it can be enabled by set

Control VCRT leak reporting via environment variable in debug builds

Formerly, this had to be enabled by passing the configuration flag
`--enable-crt-debug`; now it can be enabled by setting the environment
variable `PHP_WIN32_DEBUG_HEAP`. The advantage is that it is no longer
necessary to do separate builds, at the cost of a very minor
performance penalty during process startup.

show more ...

Remove old ARG_COUNT() macro

Use ZEND_NUM_ARGS() instead.

Clsoes GH-5551

Make cast_object handler required

Avoid subtle differences in behavior depending on whether the
handler is absent or returns FAILURE.

If you previously set cast_object to NULL,

Make cast_object handler required

Avoid subtle differences in behavior depending on whether the
handler is absent or returns FAILURE.

If you previously set cast_object to NULL, create a handler that
always returns FAILURE instead.

show more ...

Use separate typedef for bucket comparison function

Avoid performing the same casting dance inside each sort compare
function.

Require all internal functions to have arginfo

[skip ci] Fix typos in UPGRADING

Closes GH-5183

Make ASSIGN, ASSIGN_OP, INC and DEC opcodes to return IS_TMP_VAR instead of IS_VAR.

This helps to avoid unnecessary IS_REFERENCE checks.
This changes some notices "Only variables should

Make ASSIGN, ASSIGN_OP, INC and DEC opcodes to return IS_TMP_VAR instead of IS_VAR.

This helps to avoid unnecessary IS_REFERENCE checks.
This changes some notices "Only variables should be passed by reference" to exception "Cannot pass parameter %d by reference".

Also, for consistency, compile-time fatal error "Only variables can be passed by reference" was converted to exception "Cannot pass parameter %d by reference"

show more ...

Apply custom format/length modifier removal to spprintf

This mimicks the changes made to the custom snprintf implementation
by removing the custom 'v' format and custom 'I' length modifi

Apply custom format/length modifier removal to spprintf

This mimicks the changes made to the custom snprintf implementation
by removing the custom 'v' format and custom 'I' length modifier
from the spprintf implementation.

Closes GH-5108

show more ...

Drop the custom 'v' format from snprintf custom implementation.

Extensions should instead use the standard 's' format.

Closes GH-5100

Drop the custom I length modifier from snprintf custom implementation.

Extensions should rather use the ZEND_LONG_FMT, ZEND_ULONG_FMT and
ZEND_XLONG_FMT macros defined in php-src/Zend/ze

Drop the custom I length modifier from snprintf custom implementation.

Extensions should rather use the ZEND_LONG_FMT, ZEND_ULONG_FMT and
ZEND_XLONG_FMT macros defined in php-src/Zend/zend_long.h

Closes GH-5089

show more ...

uint/ulong removal may affect other platforms as well

Fix typo [ci skip]