Fix GH-15868: Assertion failure in xml_parse_into_struct after exception

Upon unwinding from an exception, the parser state is not stable, we
should not continue updating the values if a

Fix GH-15868: Assertion failure in xml_parse_into_struct after exception

Upon unwinding from an exception, the parser state is not stable, we
should not continue updating the values if an exception was thrown.

Closes GH-15879.

show more ...

Fix GH-14124: Segmentation fault on unknown address 0x0001ffff8041 with XML extension under certain memory limit (#14126)

The ltags were not initialized, so when an OOM happens before the ne

Fix GH-14124: Segmentation fault on unknown address 0x0001ffff8041 with XML extension under certain memory limit (#14126)

The ltags were not initialized, so when an OOM happens before the new value is written, uninitialized data is used.

show more ...

Convert ext/xml fields from int to bool (#12497)

Implement request #68325: parse huge option for xml_parser_create (#12256)

ext/xml: Refactor extension to use FCC instead of zvals for handlers (#12340)

To get proper errors and sensible behaviour, as the current behaviour is somewhat insane and part of it should b

ext/xml: Refactor extension to use FCC instead of zvals for handlers (#12340)

To get proper errors and sensible behaviour, as the current behaviour is somewhat insane and part of it should be axed ASAP.

The behaviour is mostly intact with some minor BC breaks which are mentioned in UPGRADING.

Co-authored-by: Niels Dossche <7771979+nielsdos@users.noreply.github.com>

show more ...

Remove always-true condition from xml_utf8_decode()

decoder is already checked above

More usage of known zend_str instead of C string (#11381)

Improve handling of XML options

Mark boolean options as such
Warn on invalid types
Stubs info

Closes GH-10675

Declare XML_SAX_IMPL constant in stubs (#9732)

Fix memory leak when calling xml_parse_into_struct() twice

Closes GH-12254.

The userland constants do not start with PHP_

Use true return type for XML functions which always return true

And fix xml_parser_set_option() which didn't return false on failure.

Closes GH-9539

Revert "Port all internally used classes to use default_object_handlers"

This reverts commit 94ee4f9834743ca74f6c9653863273277ce6c61a.

The commit was a bit too late to be included i

Revert "Port all internally used classes to use default_object_handlers"

This reverts commit 94ee4f9834743ca74f6c9653863273277ce6c61a.

The commit was a bit too late to be included in PHP 8.2 RC1. Given it's a massive ABI break, we decide to postpone the change to PHP 8.3.

show more ...

Do early returns in xml.c

This reduces nesting clarying what preconditions are needed in each of the handler functions

Mark _xml_decode_tag() as taking a const XML_Char*

As this is always the case and this removes unnecessary pointer casts

Refactor _xml_add_to_info()

Mark char* as const, and compute it's length once to save an expensive strlen() call

Port all internally used classes to use default_object_handlers

Signed-off-by: Bob Weinand <bobwei9@hotmail.com>

Declare ext/xml constants in stubs (#9131)

Refactor php_next_utf8_char() to use zend_result

Make strtolower() and strtoupper() do ASCII case conversion (#7506)

Implement RFC https://wiki.php.net/rfc/strtolower-ascii

Add upper case functions to zend_operators.c and use them (#7521)

Add a family of upper case conversion functions to zend_operators.c,
by analogy with the lower case functions.

Add upper case functions to zend_operators.c and use them (#7521)

Add a family of upper case conversion functions to zend_operators.c,
by analogy with the lower case functions.

Move the single-character conversion macros to the header so that they
can be used as a locale-independent replacement for tolower() and
toupper().

Factor out the ugly bits of the SSE2 case conversion so that the four
functions that use it are easy to read and processor-independent.

Use the new ASCII upper case functions in ext/xml, ext/pdo_dblib and as
an optimization for strtoupper() when the locale is "C".

show more ...

Fix #70962: XML_OPTION_SKIP_WHITE strips embedded whitespace

We must never strip embedded whitespace; we only need to skip values
when that option is set, and make sure that we keep BC r

Fix #70962: XML_OPTION_SKIP_WHITE strips embedded whitespace

We must never strip embedded whitespace; we only need to skip values
when that option is set, and make sure that we keep BC regarding the
different behavior for "cdata" and "complete" elements (for the former,
the whole element is skipped; for the latter only the "value" key).

We also fix erroneous `int` types which should actually be `size_t`.

Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>

Closes GH-7493.

show more ...

Remove full stop from error message

Error messages shouldn't have a full stop. Period.

Closes GH-7369.

Fix return value of xml_parse(_into_struct) for recursive parsing

As of PHP 8.0.0, these functions are supposed to return int, so we
cannot return `false`. Since calling the parser recu

Fix return value of xml_parse(_into_struct) for recursive parsing

As of PHP 8.0.0, these functions are supposed to return int, so we
cannot return `false`. Since calling the parser recursively is a
programmer error, we throw an `Error` in this case.

Cf. <https://github.com/php/php-src/pull/7363>.

show more ...

Fix #81351: xml_parse may fail, but has no error code

The fix for bug #73151[1] cured the symptoms, but not the root cause,
namely xmlParse() must not be called recursively. Since that

Fix #81351: xml_parse may fail, but has no error code

The fix for bug #73151[1] cured the symptoms, but not the root cause,
namely xmlParse() must not be called recursively. Since that bugfix
also messed up the error handling, we basically revert it (but also
simplify the return), and then prevent calling the parser recursively.

[1] <https://github.com/php/php-src/pull/2166/commits/f2a8a8c068995a5d780882c556cedd53bce3827d>

Co-authored-by: Nikita Popov <nikita.ppv@gmail.com>

Closes GH-7363.

show more ...