Make convert_to_*_ex simple aliases of convert_to_*

Historically, the _ex variants separated the zval first, if a
conversion was necessary. This distinction no longer makes sense
sin

Make convert_to_*_ex simple aliases of convert_to_*

Historically, the _ex variants separated the zval first, if a
conversion was necessary. This distinction no longer makes sense
since PHP 7.

The only difference that was still left is that _ex checked whether
the type is the same first, but the usage of these macros did not
actually distinguish on whether such an inlined check is valuable
or not in a given context.

Also drop the unused convert_to_explicit_type macros.

show more ...

Remove some INDIRECT handling in standard library

Fix edge case serializing __PHP_Incomplete_Class properties.

This was using strcmp instead of zend_string_equals_literal.
As a result, the property count didn't match the number of prope

Fix edge case serializing __PHP_Incomplete_Class properties.

This was using strcmp instead of zend_string_equals_literal.
As a result, the property count didn't match the number of properties
being serialized if properties started with
"__PHP_Incomplete_Class\0" (unlikely)

(before, `'O:8:"Missing_":1:{}'` would be serialized, which failed to
unserialize)

Everywhere else expects the MAGIC_MEMBER to match exactly,
and this should use zend_string_equals_literal as an example for other code.

This has used strcmp since 2004 in deb84befae4bbc3686a4f2ed82b04e2cabae5dc0

Closes GH-6555

show more ...

Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
Fixed bug #80411

Fixed bug #80411

References to null-serializations are stored as null, and as such
are part of the reference count.

Reminds me that we really need to deprecate the mess that is

Fixed bug #80411

References to null-serializations are stored as null, and as such
are part of the reference count.

Reminds me that we really need to deprecate the mess that is
Serializable.

show more ...

Promote a few remaining errors in ext/standard

Closes GH-6110

[RFC] Only unserialize Phar metadata when getMetadata() is called

In other words, don't automatically unserialize when the magic
phar:// stream wrappers are used.
RFC: https://wiki.p

[RFC] Only unserialize Phar metadata when getMetadata() is called

In other words, don't automatically unserialize when the magic
phar:// stream wrappers are used.
RFC: https://wiki.php.net/rfc/phar_stop_autoloading_metadata

Also, change the signature from `getMetadata()`
to `getMetadata(array $unserialize_options = [])`.
Start throwing earlier if setMetadata() is called and serialization threw.

See https://externals.io/message/110856 and
https://bugs.php.net/bug.php?id=76774

This was refactored to add a phar_metadata_tracker for the following reasons:
- The way to properly copy a zval was previously implicit and undocumented
(e.g. is it a pointer to a raw string or an actual value)
- Avoid unnecessary serialization and unserialization in the most common case
- If a metadata value is serialized once while saving a new/modified phar file,
this allows reusing the same serialized string.
- Have as few ways to copy/clone/lazily parse metadata (etc.) as possible,
so that code changes can be limited to only a few places in the future.
- Performance is hopefully not a concern - copying a string should be faster
than unserializing a value, and metadata should be rare in most cases.

Remove unnecessary skip in a test(Compression's unused)

Add additional assertions about usage of persistent phars

Improve robustness of `Phar*->setMetadata()`

- Add sanity checks for edge cases freeing metadata, when destructors
or serializers modify the phar recursively.
- Typical use cases of php have phar.readonly=1 and would not be affected.

Closes GH-5855

show more ...

Fix warnings of strict-prototypes

Closes GH-5887.

debug_zval_dump(): Don't skip recursion detection on first level

A complement to ae6f45ad45e072260d93f828d81fee9548123044

Closes GH-5843.

Merge branch 'PHP-7.4'

* PHP-7.4:
Fixed BC break of php_debug_zval_dump

Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
Fixed BC break of php_debug_zval_dump

Fixed BC break of php_debug_zval_dump

It introduced by fixing bug #79830

Merge branch 'PHP-7.4'

* PHP-7.4:
Fixed bug #79830 introduced by fixing bug #79821

# Conflicts:
# ext/standard/var.c

Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
Fixed bug #79830 introduced by fixing bug #79821

Fixed bug #79830 introduced by fixing bug #79821

This also fixes memory error in debug_zval_dump and var_export.

Merge branch 'PHP-7.4'

* PHP-7.4:
Fixed bug #79821

Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
Fixed bug #79821

Fixed bug #79821

HashTable was reallocated (zend_hash_packed_grow) during php_var_dump, so we should call GC_ADDREF to make SEPARATE_ARRAY work.

Closes GH-5837.

Review the usage of apostrophes in error messages

Closes GH-5590

Remove proto comments from C files

Closes GH-5758

Cache __unserialize() instead of unserialize()

We should use these cache slots for the new object serialization
mechanism rather than the old one.

Add ZVAL_OBJ_COPY macro

For the common ZVAL_OBJ + GC_ADDREF pattern.
This mirrors the existing ZVAL_STR_COPY API.

Make float to string casts locale-independent

From now on, float to string casting will always behave locale-independently.
RFC: https://wiki.php.net/rfc/locale_independent_float_to_stri

Make float to string casts locale-independent

From now on, float to string casting will always behave locale-independently.
RFC: https://wiki.php.net/rfc/locale_independent_float_to_string
Closes GH-5224

Co-authored-by: George Peter Banyard <girgias@php.net>

show more ...

Fixed bug #79526 (`__sleep` error message doesn't include the name of the class)

Merge branch 'PHP-7.4'

* PHP-7.4:
Fix bug #79447